October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: Makefile.am: Drop duplicated LIBOSMOMGCPCLIENT_LIBS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29807 ) Change subject: Makefile.am: Drop duplicated LIBOSMOMGCPCLIENT_LIBS ...................................................................... Makefile.am: Drop duplicated LIBOSMOMGCPCLIENT_LIBS Change-Id: Ie52f27bcacca60cc16b49142edb79a3e58dff131 --- M src/osmo-hnbgw/Makefile.am 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-hnbgw/Makefile.am b/src/osmo-hnbgw/Makefile.am index 1d907ba..a6cf5ea 100644 --- a/src/osmo-hnbgw/Makefile.am +++ b/src/osmo-hnbgw/Makefile.am @@ -55,7 +55,6 @@ $(LIBOSMORUA_LIBS) \ $(LIBOSMORANAP_LIBS) \ $(LIBOSMOHNBAP_LIBS) \ - $(LIBOSMOMGCPCLIENT_LIBS) \ $(LIBSCTP_LIBS) \ $(LIBOSMOMGCPCLIENT_LIBS) \ $(NULL) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29807 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ie52f27bcacca60cc16b49142edb79a3e58dff131 Gerrit-Change-Number: 29807 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-hnbgw[master]: Introduce support for libosmo-mgcp-client MGW pooling

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29806 ) Change subject: Introduce support for libosmo-mgcp-client MGW pooling ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > do we keep backwards compatibility of reading old config files? There are production deployments of […] Yes, we still call mgcp_client_vty_init(), same as in osmo-msc and osmo-bsc. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I371dc773b58788ee21037dc25d77f556c89c6b61 Gerrit-Change-Number: 29806 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 20 Oct 2022 12:19:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: tests/test_nodes.vty: Avoid listing commands provided by lib

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29802 ) Change subject: tests/test_nodes.vty: Avoid listing commands provided by lib ...................................................................... tests/test_nodes.vty: Avoid listing commands provided by lib Those commands are not controlled/implemented in this repository, so it's a bad idea having them show up here, since they may change. be modified, become deprecated, etc. They are actually becoming deprecated now in libosmo-mgcp-client (osmo-mgw.git Change-Id Id55af13d2ecde49d968b9dca6a2f8108a17ec484) and hence they don't appear anymore when listing the node. Change-Id: I5d908f9e3023f725d49ed039158bd3d09828f12c --- M tests/test_nodes.vty 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, approved diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty index 8ffb2bd..0c9e360 100644 --- a/tests/test_nodes.vty +++ b/tests/test_nodes.vty @@ -73,10 +73,6 @@ neighbor (a|iu) cgi <0-999> <0-999> <0-65535> <0-65535> (ran-pc|msc-ipa-name) RAN_PC_OR_MSC_IPA_NAME no neighbor (a|iu) (ran-pc|msc-ipa-name) RAN_PC_OR_MSC_IPA_NAME timer [(vlr|mgw|mncc|sccp|geran|utran|sgs)] [TNNNN] [(<0-2147483647>|default)] - mgw local-ip (A.B.C.D|X:X::X:X) - mgw local-port <0-65535> - mgw remote-ip (A.B.C.D|X:X::X:X) - mgw remote-port <0-65535> ... OsmoMSC(config-msc)# ncss? @@ -164,9 +160,7 @@ ... auth-tuple-max-reuse-count 3 auth-tuple-reuse-on-error 1 - mgw local-port 2728 - mgw remote-ip 127.0.0.1 - mgw remote-port 2427 +... mncc-int default-codec tch-f fr default-codec tch-h hr -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d908f9e3023f725d49ed039158bd3d09828f12c Gerrit-Change-Number: 29802 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29811 ) Change subject: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2126578c4e64c9f336e8a1f6ee98de970866b8dc Gerrit-Change-Number: 29811 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 09:28:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Use new mgcp-client VTY commands under mgw node

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29803 ) Change subject: Use new mgcp-client VTY commands under mgw node ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8ac11388e9493416b644812638e1374251725584 Gerrit-Change-Number: 29803 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 09:26:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: vty: Make use of new mgcp_client_pool_config_write() API

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29796 ) Change subject: vty: Make use of new mgcp_client_pool_config_write() API ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29796 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic473fe05c55e8df3eddedf0260ec04b6fefc501f Gerrit-Change-Number: 29796 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 09:25:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: tests/test_nodes.vty: Avoid listing commands provided by lib

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29802 ) Change subject: tests/test_nodes.vty: Avoid listing commands provided by lib ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d908f9e3023f725d49ed039158bd3d09828f12c Gerrit-Change-Number: 29802 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 09:24:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Introduce support for libosmo-mgcp-client MGW pooling

by osmith

Attention is currently required from: pespin, fixeria, daniel, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29782 ) Change subject: Introduce support for libosmo-mgcp-client MGW pooling ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff Gerrit-Change-Number: 29782 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 09:24:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci-on-slaves: set wipe-workspace

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29773 ) Change subject: jobs/update-osmo-ci-on-slaves: set wipe-workspace ...................................................................... jobs/update-osmo-ci-on-slaves: set wipe-workspace Wipe the workspace before running the job, so the _docker_playground clone gets recreated (and e.g. doesn't have the old clone url). Change-Id: I5626c4728ebd7f6b693484c7801963985832398d --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 41181cd..39afb46 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -30,6 +30,7 @@ skip-tag: true branches: - 'origin/master' + wipe-workspace: true triggers: - pollscm: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5626c4728ebd7f6b693484c7801963985832398d Gerrit-Change-Number: 29773 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: contrib/jenkins.sh: run …rebuild.sh from workspace

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29772 ) Change subject: contrib/jenkins.sh: run …rebuild.sh from workspace ...................................................................... contrib/jenkins.sh: run …rebuild.sh from workspace After cloning a repository, go back into the workspace directory. Run scripts/osmo-ci-docker-rebuild.sh from there, instead of the version cloned into ~/osmo-ci. This is the behavior one would expect. Without this patch, a _docker_playground temporary git clone gets created/used in ~/osmo-ci, although it would make much more sense to have it in the workspace dir. Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85 --- M contrib/jenkins.sh 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 300d38c..6512af9 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -1,5 +1,6 @@ #!/bin/sh set -e -x +WORKSPACE_DIR="$(realpath "$(dirname "$0")/..")" # Clone repository to ~/, or update existing # $1: name of osmocom project @@ -12,12 +13,13 @@ git rev-parse HEAD git status + + cd "$WORKSPACE_DIR" } clone_repo osmo-ci clone_repo osmo-gsm-manuals if [ `uname` = "Linux" ] && [ "x${OSMO_CI_NO_DOCKER}" != "x1" ]; then - cd ~/osmo-ci scripts/osmo-ci-docker-rebuild.sh fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29772 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I998c0d47ee5ce6f9978d1a6c9e195d5ce40e4e85 Gerrit-Change-Number: 29772 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022