October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: Avoid loosing DL tbf from old_ms when rx premier UL data

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29845 ) Change subject: Avoid loosing DL tbf from old_ms when rx premier UL data ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/29845/comment/c67a76cb_d267768d PS2, Line 10: MS has UL TBF to attach to the network in FINISHED state, PCU received DL data (if you put a bit less in each line, it's more convenient to read this in gerrit) https://gerrit.osmocom.org/c/osmo-pcu/+/29845/comment/fc0e33ac_92367c01 PS2, Line 14: earns learns -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9a989af89f9469d7894b9e70a2ea01989b9dbb75 Gerrit-Change-Number: 29845 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 12:08:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: gprs_ms: Move creating string name of object to a function

by osmith

Attention is currently required from: pespin, keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29844 ) Change subject: gprs_ms: Move creating string name of object to a function ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8ab713154c8f308878f3e85b6f7e8afc5c4be249 Gerrit-Change-Number: 29844 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 24 Oct 2022 11:47:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcu[master]: Call ms_store->get_ms() with GSM_RESERVED_TMSI instead of 0

by osmith

Attention is currently required from: pespin, keith. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29839 ) Change subject: Call ms_store->get_ms() with GSM_RESERVED_TMSI instead of 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I364d238ff8a82abb14281140fe18b273c0e8f541 Gerrit-Change-Number: 29839 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 24 Oct 2022 11:42:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: set PYTHONUNBUFFERED=1

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29842 ) Change subject: contrib/jenkins.sh: set PYTHONUNBUFFERED=1 ...................................................................... contrib/jenkins.sh: set PYTHONUNBUFFERED=1 Make sure all python output is printed immediatelly. Change-Id: I5d334bbc34e4df39ac54472642299c567894f449 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fbcd73c..0ade9b4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -6,6 +6,8 @@ # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") # +export PYTHONUNBUFFERED=1 + if [ ! -d "./pysim-testdata/" ] ; then echo "###############################################" echo "Please call from pySim-prog top directory" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5d334bbc34e4df39ac54472642299c567894f449 Gerrit-Change-Number: 29842 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in pysim[master]: docs: allow overriding OSMO_GSM_MANUALS_DIR

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29843 ) Change subject: docs: allow overriding OSMO_GSM_MANUALS_DIR ...................................................................... docs: allow overriding OSMO_GSM_MANUALS_DIR Related: OS#5497 Change-Id: I433217b7aa1cdcddc52a89721e03e44b417bacb1 --- M docs/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/docs/Makefile b/docs/Makefile index e594851..550d4e7 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -9,7 +9,7 @@ BUILDDIR = _build # for osmo-gsm-manuals -OSMO_GSM_MANUALS_DIR=$(shell pkg-config osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null) +OSMO_GSM_MANUALS_DIR ?= $(shell pkg-config osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null) OSMO_REPOSITORY = "pysim" UPLOAD_FILES = $(BUILDDIR)/latex/osmopysim-usermanual.pdf CLEAN_FILES = $(UPLOAD_FILES) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I433217b7aa1cdcddc52a89721e03e44b417bacb1 Gerrit-Change-Number: 29843 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: add TC_ho_meas_rep_multi_band

by osmith

Attention is currently required from: neels, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 ) Change subject: BSC: add TC_ho_meas_rep_multi_band ...................................................................... Patch Set 3: (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/856d721e_5b3d… PS3, Line 898: cid_list := * > This parameter should be '(present)' and set to '?' by default, because PDU_BSSMAP_HandoverRequired. […] Wouldn't this break existing code using this? $ git grep tr_BSSMAP_HandoverRequired BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired(exp_oldToNewBSSIEs)); BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired); BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired); BSC_Tests.ttcn: BSSAP.receive(tr_BSSMAP_HandoverRequired); BSC_Tests.ttcn: [] BSSAP.receive(tr_BSSMAP_HandoverRequired) { BSC_Tests.ttcn: [] BSSAP.receive(tr_BSSMAP_HandoverRequired(cid_list := cid_list)) { BSC_Tests.ttcn: [] BSSAP.receive(tr_BSSMAP_HandoverRequired()) { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Gerrit-Change-Number: 29837 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 11:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: add TC_ho_meas_rep_multi_band

by fixeria

Attention is currently required from: osmith, neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 ) Change subject: BSC: add TC_ho_meas_rep_multi_band ...................................................................... Patch Set 3: (1 comment) File library/BSSMAP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/b44046df_56ce… PS3, Line 898: cid_list := * This parameter should be '(present)' and set to '?' by default, because PDU_BSSMAP_HandoverRequired.cellIdentifierList is *not* optional, and thus always present. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Gerrit-Change-Number: 29837 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 11:20:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: extend TC_ho_meas_rep_multi_band for ARFCN=0

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858 ) Change subject: BSC: extend TC_ho_meas_rep_multi_band for ARFCN=0 ...................................................................... Patch Set 1: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858/comment/08aba771_5232… PS1, Line 11979: 40 For some reason, the testsuite seems to encode this wrong: https://nextcloud.sysmocom.de/s/C4DoX5tNAjeHSwp Instead of giving the third entry an rxlev of 40, the second entry has this level. OsmoBSC with my patch then decodes it as it's in the measurement report, but the test fails. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia8f94d72651061427afc9e34f678544f89d0149b Gerrit-Change-Number: 29858 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 24 Oct 2022 11:18:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in pysim[master]: docs: allow overriding OSMO_GSM_MANUALS_DIR

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29843 ) Change subject: docs: allow overriding OSMO_GSM_MANUALS_DIR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I433217b7aa1cdcddc52a89721e03e44b417bacb1 Gerrit-Change-Number: 29843 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 11:10:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: set PYTHONUNBUFFERED=1

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29842 ) Change subject: contrib/jenkins.sh: set PYTHONUNBUFFERED=1 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5d334bbc34e4df39ac54472642299c567894f449 Gerrit-Change-Number: 29842 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 11:10:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022