October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29936 ) Change subject: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a9c80dd12252e7befe9c9bc8e8f7ee8648b5465 Gerrit-Change-Number: 29936 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Oct 2022 20:50:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29935 ) Change subject: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196 Gerrit-Change-Number: 29935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Oct 2022 20:50:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: fixup! Migrate to libosmocsn1 and libosmo-gprs-rlcmac

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29938 ) Change subject: fixup! Migrate to libosmocsn1 and libosmo-gprs-rlcmac ...................................................................... fixup! Migrate to libosmocsn1 and libosmo-gprs-rlcmac Change-Id: I2f7b409288635e3405e86438772cb6fa143120ec --- M contrib/osmo-pcu.spec.in M debian/control 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/38/29938/1 diff --git a/contrib/osmo-pcu.spec.in b/contrib/osmo-pcu.spec.in index 0314b12..30f703f 100644 --- a/contrib/osmo-pcu.spec.in +++ b/contrib/osmo-pcu.spec.in @@ -33,6 +33,7 @@ BuildRequires: pkgconfig(libosmogsm) >= 1.7.0 BuildRequires: pkgconfig(libosmovty) >= 1.7.0 BuildRequires: pkgconfig(libosmoctrl) >= 1.7.0 +BuildRequires: pkgconfig(libosmo-csn1-dev) BuildRequires: pkgconfig(libosmo-gprs-rlcmac) %{?systemd_requires} diff --git a/debian/control b/debian/control index cad1cdc..1a6b7ca 100644 --- a/debian/control +++ b/debian/control @@ -6,6 +6,7 @@ dh-autoreconf, autotools-dev, pkg-config, + libosmo-csn1-dev, libosmo-gprs-rlcmac-dev, libosmocore-dev (>= 1.7.0), osmo-gsm-manuals-dev (>= 1.3.0) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2f7b409288635e3405e86438772cb6fa143120ec Gerrit-Change-Number: 29938 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix TC_conn_fail_crit: tune the MS back to BCCH

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29937 ) Change subject: BTS_Tests: fix TC_conn_fail_crit: tune the MS back to BCCH ...................................................................... BTS_Tests: fix TC_conn_fail_crit: tune the MS back to BCCH osmo-bts-trx declares a connection failure when the radio link counter S reaches 0. This counter is decreased every time the Viterbi decoder yields a decoding error on the Uplink SACCH. For more details, see 3GPP TS 45.008, section 5.2. The scheduler in osmo-bts-trx expects NOPE indications to be sent by the transceiver in the absence of valid Uplink bursts. However, due to the asynchronous nature of TRXD link, our virtual Um interface implementation, fake_trx.py, does not generate NOPE indications on it's own. Instead, trxcon is sending empty TRXDv0 PDUs (BURST.req), which are then translated to proper TRXDv1 NOPE.ind by fake_trx.py. The TC_conn_fail_crit currently sends L1CTL_DM_REL_REQ in order to simulate connection loss, what makes trxcon disable all active timeslots and thus stop sending NOPE.req to fake_trx.py. Let's tune trxcon back to BCCH, in order to ensure that NOPE.req messages are still being sent, so that osmo-bts-trx will be able to declare a connection failure over the RSL as expected. Change-Id: I34aee95111eafea90eeeea861682f1b4547d7b03 Related: Ic292d180ba64206fb4d88adb284f9f9d058b4587 --- M bts/BTS_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/29937/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index cecdda1..9baee40 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -3945,6 +3945,7 @@ f_est_dchan(); f_sleep(2.0); L1CTL.send(ts_L1CTL_DM_REL_REQ(g_chan_nr)); + f_l1_tune(L1CTL); /* tune back to BCCH */ timer T := 40.0; T.start; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I34aee95111eafea90eeeea861682f1b4547d7b03 Gerrit-Change-Number: 29937 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29935 ) Change subject: osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink ...................................................................... osmo-bts-trx: use lookup tables for checking AMR CMI/CMR on Downlink Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196 --- M src/osmo-bts-trx/sched_lchan_tchf.c M src/osmo-bts-trx/sched_lchan_tchh.c 2 files changed, 30 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/35/29935/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index bf6703a..6a6331f 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -61,6 +61,15 @@ [24] = 1, /* TCH/F: a=17 / h=24 */ }; +/* TDMA frame number of burst 'a' should be used as the table index. */ +static const uint8_t sched_tchf_dl_amr_cmi_map[26] = { + [4] = 1, /* TCH/F: a=4 */ + [13] = 1, /* TCH/F: a=13 */ + [21] = 1, /* TCH/F: a=21 */ +}; + +extern const uint8_t sched_tchh_dl_amr_cmi_map[26]; + /*! \brief a single TCH/F burst was received by the PHY, process it */ int rx_tchf_fn(struct l1sched_ts *l1ts, const struct trx_ul_burst_ind *bi) { @@ -392,7 +401,7 @@ enum osmo_amr_type ft_codec; enum osmo_amr_quality bfi; int8_t sti, cmi; - bool amr_is_cmr = !dl_amr_fn_is_cmi(br->fn); + bool amr_is_cmr; if (rsl_cmode != RSL_CMOD_SPD_SPEECH) { LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Dropping speech frame, " @@ -430,6 +439,10 @@ "Codec (FT = %d) of RTP frame not in list\n", ft_codec); goto free_bad_msg; } + if (br->chan == TRXC_TCHF) + amr_is_cmr = !sched_tchf_dl_amr_cmi_map[br->fn % 26]; + else /* TRXC_TCHH_0 or TRXC_TCHH_1 */ + amr_is_cmr = !sched_tchh_dl_amr_cmi_map[br->fn % 26]; if (amr_is_cmr && chan_state->dl_ft != ft) { LOGL1SB(DL1P, LOGL_NOTICE, l1ts, br, "Codec (FT = %d) " " of RTP cannot be changed now, but in next frame\n", ft_codec); @@ -514,7 +527,8 @@ * the first FN 0,8,17 defines that CMR is included in frame. */ gsm0503_tch_afs_encode(*bursts_p, msg->l2h + sizeof(struct amr_hdr), - msgb_l2len(msg) - sizeof(struct amr_hdr), !dl_amr_fn_is_cmi(br->fn), + msgb_l2len(msg) - sizeof(struct amr_hdr), + !sched_tchf_dl_amr_cmi_map[br->fn % 26], chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); diff --git a/src/osmo-bts-trx/sched_lchan_tchh.c b/src/osmo-bts-trx/sched_lchan_tchh.c index 17073e0..37fd59d 100644 --- a/src/osmo-bts-trx/sched_lchan_tchh.c +++ b/src/osmo-bts-trx/sched_lchan_tchh.c @@ -66,6 +66,18 @@ [3] = 1, /* TCH/H(1): a=18 / d=24 / f=3 */ }; +/* TDMA frame number of burst 'a' should be used as the table index. + * This mapping is valid for both FACCH/H(0) and FACCH/H(1). */ +const uint8_t sched_tchh_dl_amr_cmi_map[26] = { + [4] = 1, /* TCH/H(0): a=4 */ + [13] = 1, /* TCH/H(0): a=13 */ + [21] = 1, /* TCH/H(0): a=21 */ + + [5] = 1, /* TCH/H(1): a=5 */ + [14] = 1, /* TCH/H(1): a=14 */ + [22] = 1, /* TCH/H(1): a=22 */ +}; + /* 3GPP TS 45.002, table 1 in clause 7: Mapping tables. * TDMA frame number of burst 'f' is always used as the table index. */ static const uint8_t sched_tchh_ul_facch_map[26] = { @@ -439,7 +451,8 @@ * in frame, the first FN 0,8,17 or 1,9,18 defines that CMR is * included in frame. */ gsm0503_tch_ahs_encode(*bursts_p, msg->l2h + sizeof(struct amr_hdr), - msgb_l2len(msg) - sizeof(struct amr_hdr), !dl_amr_fn_is_cmi(br->fn), + msgb_l2len(msg) - sizeof(struct amr_hdr), + !sched_tchh_dl_amr_cmi_map[br->fn % 26], chan_state->codec, chan_state->codecs, chan_state->dl_ft, chan_state->dl_cmr); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29935 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I75ecf5369f31c8b8e9519d2b580355fa80c24196 Gerrit-Change-Number: 29935 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29936 ) Change subject: osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi() ...................................................................... osmo-bts-trx: drop ul_amr_fn_is_cmi() / dl_amr_fn_is_cmi() The scheduler is now using the lookup tables instead of these functions. The only part using them is the AMR unit test. Change-Id: I1a9c80dd12252e7befe9c9bc8e8f7ee8648b5465 --- M src/osmo-bts-trx/sched_utils.h M tests/amr/amr_test.c M tests/amr/amr_test.ok 3 files changed, 1 insertion(+), 350 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/36/29936/1 diff --git a/src/osmo-bts-trx/sched_utils.h b/src/osmo-bts-trx/sched_utils.h index f76e49b..95f4a77 100644 --- a/src/osmo-bts-trx/sched_utils.h +++ b/src/osmo-bts-trx/sched_utils.h @@ -22,9 +22,6 @@ #pragma once #include <stdint.h> -#include <errno.h> -#include <stdbool.h> -#include <osmo-bts/scheduler.h> extern void *tall_bts_ctx; @@ -36,77 +33,3 @@ else return 10000 * n_errors / n_bits_total; } - -/*! determine whether an uplink AMR block is CMI according to 3GPP TS 45.009. - * \param[in] fn_begin frame number of the beginning of the block. - * \returns true in case of CMI; false otherwise. */ -static inline bool ul_amr_fn_is_cmi(uint32_t fn_begin) -{ - switch (fn_begin % 26) { - /*! See also: 3GPP TS 45.009, section 3.2.1.3 Transmitter/Receiver Synchronisation */ - /* valid for AHS subslot 0 and AFS: */ - case 0: - case 8: - case 17: - /* valid for AHS subslot 1: */ - case 1: - case 9: - case 18: - return true; - break; - /* Complementary values for sanity check */ - /* valid for AHS subslot 0 and AFS: */ - case 4: - case 13: - case 21: - /* valid for AHS subslot 1: */ - case 5: - case 14: - case 22: - return false; - break; - default: - LOGP(DL1P, LOGL_DEBUG, - "uplink frame number fn_begin=%u does not mark the beginning of a voice block!\n", fn_begin); - OSMO_ASSERT(false); - return false; - break; - } -} - -/*! determine the whether a downlink AMR block is CMI according to 3GPP TS 45.009. - * \param[in] fn_begin frame number of the beginning of the block. - * \returns true in case of CMI; false otherwise. */ -static inline bool dl_amr_fn_is_cmi(uint32_t fn_begin) -{ - switch (fn_begin % 26) { - /*! See also: 3GPP TS 45.009, section 3.2.1.3 Transmitter/Receiver Synchronisation */ - /* valid for AHS subslot 0 and AFS: */ - case 4: - case 13: - case 21: - /* valid for AHS subslot 1: */ - case 5: - case 14: - case 22: - return true; - break; - /* Complementary values for sanity check */ - /* valid for AHS subslot 0 and AFS: */ - case 0: - case 8: - case 17: - /* valid for AHS subslot 1: */ - case 1: - case 9: - case 18: - return false; - break; - default: - LOGP(DL1P, LOGL_DEBUG, - "downlink frame number fn_begin=%u does not mark the beginning of a voice block!\n", fn_begin); - OSMO_ASSERT(false); - return false; - break; - } -} diff --git a/tests/amr/amr_test.c b/tests/amr/amr_test.c index 480ff73..0fc58e7 100644 --- a/tests/amr/amr_test.c +++ b/tests/amr/amr_test.c @@ -27,126 +27,7 @@ #include <stdlib.h> #include <stdio.h> -#include "../../src/osmo-bts-trx/sched_utils.h" - -struct amr_cmi_test_data { - /* Frame number that marks the beginning of the voice block */ - uint32_t gsm_fn; - /* In uplink: True, when the voice block is a CMI block, false otherwise. */ - /* In downlink: False, when the voice block is a CMI block, true otherwise. */ - bool is_cmi; -}; - -/* The behavior of AHS in subslot 0 and AFS is the same */ -static const struct amr_cmi_test_data testvec_ahs_h0_and_afs[] = { - { 0, true }, - { 4, false }, - { 8, true }, - { 13, false }, - { 17, true }, - { 21, false }, - { 26, true }, - { 30, false }, - { 34, true }, - { 39, false }, - { 43, true }, - { 47, false }, - { 52, true }, - { 56, false }, - { 60, true }, - { 65, false }, - { 69, true }, - { 73, false }, - { 78, true }, - { 82, false }, - { 86, true }, - { 91, false }, - { 95, true }, - { 99, false }, -}; - -static const struct amr_cmi_test_data testvec_ahs_h1[] = { - { 1, true }, - { 5, false }, - { 9, true }, - { 14, false }, - { 18, true }, - { 22, false }, - { 27, true }, - { 31, false }, - { 35, true }, - { 40, false }, - { 44, true }, - { 48, false }, - { 53, true }, - { 57, false }, - { 61, true }, - { 66, false }, - { 70, true }, - { 74, false }, - { 79, true }, - { 83, false }, - { 87, true }, - { 92, false }, - { 96, true }, - { 100, false }, -}; - -static void test_amr_cmi_sched(void) -{ - unsigned int i; - bool res; - - printf("AMR transmission phase (CMI) in relation to GSM FN:\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = ul_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Uplink, AMR AHS on HR subslot 0: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == testvec_ahs_h0_and_afs[i].is_cmi); - } - - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = dl_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Downlink, AMR AHS on HR subslot 0: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == !testvec_ahs_h0_and_afs[i].is_cmi); - } - - printf("\n"); - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h1); i++) { - res = ul_amr_fn_is_cmi(testvec_ahs_h1[i].gsm_fn); - printf("Uplink, AMR AHS on HR subslot 1: fn_begin=%u, CMI=%u\n", testvec_ahs_h1[i].gsm_fn, res); - OSMO_ASSERT(res == testvec_ahs_h1[i].is_cmi); - } - - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h1); i++) { - res = dl_amr_fn_is_cmi(testvec_ahs_h1[i].gsm_fn); - printf("Downlink, AMR AHS on HR subslot 1: fn_begin=%u, CMI=%u\n", testvec_ahs_h1[i].gsm_fn, res); - OSMO_ASSERT(res == !testvec_ahs_h1[i].is_cmi); - } - - printf("\n"); - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = ul_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Uplink, AMR AFS: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == testvec_ahs_h0_and_afs[i].is_cmi); - } - - printf("\n"); - - for (i = 0; i < ARRAY_SIZE(testvec_ahs_h0_and_afs); i++) { - res = dl_amr_fn_is_cmi(testvec_ahs_h0_and_afs[i].gsm_fn); - printf("Downlink, AMR AFS: fn_begin=%u, CMI=%u\n", testvec_ahs_h0_and_afs[i].gsm_fn, res); - OSMO_ASSERT(res == !testvec_ahs_h0_and_afs[i].is_cmi); - } -} +#include <errno.h> static void test_amr_parse_mr_conf(void) { @@ -185,7 +66,6 @@ log_set_print_level(osmo_stderr_target, 1); log_set_use_color(osmo_stderr_target, 0); - test_amr_cmi_sched(); test_amr_parse_mr_conf(); return EXIT_SUCCESS; } diff --git a/tests/amr/amr_test.ok b/tests/amr/amr_test.ok index f0d1830..921e8b9 100644 --- a/tests/amr/amr_test.ok +++ b/tests/amr/amr_test.ok @@ -1,155 +1,3 @@ -AMR transmission phase (CMI) in relation to GSM FN: -Uplink, AMR AHS on HR subslot 0: fn_begin=0, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=4, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=8, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=13, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=17, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=21, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=26, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=30, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=34, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=39, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=43, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=47, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=52, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=56, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=60, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=65, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=69, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=73, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=78, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=82, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=86, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=91, CMI=0 -Uplink, AMR AHS on HR subslot 0: fn_begin=95, CMI=1 -Uplink, AMR AHS on HR subslot 0: fn_begin=99, CMI=0 - -Downlink, AMR AHS on HR subslot 0: fn_begin=0, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=4, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=8, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=13, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=17, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=21, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=26, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=30, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=34, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=39, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=43, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=47, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=52, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=56, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=60, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=65, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=69, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=73, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=78, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=82, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=86, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=91, CMI=1 -Downlink, AMR AHS on HR subslot 0: fn_begin=95, CMI=0 -Downlink, AMR AHS on HR subslot 0: fn_begin=99, CMI=1 - - -Uplink, AMR AHS on HR subslot 1: fn_begin=1, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=5, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=9, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=14, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=18, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=22, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=27, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=31, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=35, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=40, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=44, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=48, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=53, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=57, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=61, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=66, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=70, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=74, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=79, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=83, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=87, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=92, CMI=0 -Uplink, AMR AHS on HR subslot 1: fn_begin=96, CMI=1 -Uplink, AMR AHS on HR subslot 1: fn_begin=100, CMI=0 - -Downlink, AMR AHS on HR subslot 1: fn_begin=1, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=5, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=9, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=14, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=18, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=22, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=27, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=31, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=35, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=40, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=44, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=48, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=53, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=57, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=61, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=66, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=70, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=74, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=79, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=83, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=87, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=92, CMI=1 -Downlink, AMR AHS on HR subslot 1: fn_begin=96, CMI=0 -Downlink, AMR AHS on HR subslot 1: fn_begin=100, CMI=1 - - -Uplink, AMR AFS: fn_begin=0, CMI=1 -Uplink, AMR AFS: fn_begin=4, CMI=0 -Uplink, AMR AFS: fn_begin=8, CMI=1 -Uplink, AMR AFS: fn_begin=13, CMI=0 -Uplink, AMR AFS: fn_begin=17, CMI=1 -Uplink, AMR AFS: fn_begin=21, CMI=0 -Uplink, AMR AFS: fn_begin=26, CMI=1 -Uplink, AMR AFS: fn_begin=30, CMI=0 -Uplink, AMR AFS: fn_begin=34, CMI=1 -Uplink, AMR AFS: fn_begin=39, CMI=0 -Uplink, AMR AFS: fn_begin=43, CMI=1 -Uplink, AMR AFS: fn_begin=47, CMI=0 -Uplink, AMR AFS: fn_begin=52, CMI=1 -Uplink, AMR AFS: fn_begin=56, CMI=0 -Uplink, AMR AFS: fn_begin=60, CMI=1 -Uplink, AMR AFS: fn_begin=65, CMI=0 -Uplink, AMR AFS: fn_begin=69, CMI=1 -Uplink, AMR AFS: fn_begin=73, CMI=0 -Uplink, AMR AFS: fn_begin=78, CMI=1 -Uplink, AMR AFS: fn_begin=82, CMI=0 -Uplink, AMR AFS: fn_begin=86, CMI=1 -Uplink, AMR AFS: fn_begin=91, CMI=0 -Uplink, AMR AFS: fn_begin=95, CMI=1 -Uplink, AMR AFS: fn_begin=99, CMI=0 - -Downlink, AMR AFS: fn_begin=0, CMI=0 -Downlink, AMR AFS: fn_begin=4, CMI=1 -Downlink, AMR AFS: fn_begin=8, CMI=0 -Downlink, AMR AFS: fn_begin=13, CMI=1 -Downlink, AMR AFS: fn_begin=17, CMI=0 -Downlink, AMR AFS: fn_begin=21, CMI=1 -Downlink, AMR AFS: fn_begin=26, CMI=0 -Downlink, AMR AFS: fn_begin=30, CMI=1 -Downlink, AMR AFS: fn_begin=34, CMI=0 -Downlink, AMR AFS: fn_begin=39, CMI=1 -Downlink, AMR AFS: fn_begin=43, CMI=0 -Downlink, AMR AFS: fn_begin=47, CMI=1 -Downlink, AMR AFS: fn_begin=52, CMI=0 -Downlink, AMR AFS: fn_begin=56, CMI=1 -Downlink, AMR AFS: fn_begin=60, CMI=0 -Downlink, AMR AFS: fn_begin=65, CMI=1 -Downlink, AMR AFS: fn_begin=69, CMI=0 -Downlink, AMR AFS: fn_begin=73, CMI=1 -Downlink, AMR AFS: fn_begin=78, CMI=0 -Downlink, AMR AFS: fn_begin=82, CMI=1 -Downlink, AMR AFS: fn_begin=86, CMI=0 -Downlink, AMR AFS: fn_begin=91, CMI=1 -Downlink, AMR AFS: fn_begin=95, CMI=0 -Downlink, AMR AFS: fn_begin=99, CMI=1 amr_parse_mr_conf() <- 20 a5 0d 46 52 54 amr_parse_mr_conf() -> num_modes=4 Mode[0] = 0/13/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29936 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1a9c80dd12252e7befe9c9bc8e8f7ee8648b5465 Gerrit-Change-Number: 29936 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests TC_ul_tbf_{1,2}phase_while_dl_ass_pch

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29934 ) Change subject: pcu: Introduce tests TC_ul_tbf_{1,2}phase_while_dl_ass_pch ...................................................................... Patch Set 1: (2 comments) File pcu/PCU_Tests.ttcn: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-610): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29934/comment/e6700f05_eded… PS1, Line 4046: /* We should finally receive the DL-data that was received previosuly from the SGSN: */ 'previosuly' may be misspelled - perhaps 'previously'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-610): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29934/comment/333fbb49_96bd… PS1, Line 4113: /* We should finally receive the DL-data that was received previosuly from the SGSN: */ 'previosuly' may be misspelled - perhaps 'previously'? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a72c36265bfdc757180cbb466492ad6bbbf16ad Gerrit-Change-Number: 29934 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Mon, 31 Oct 2022 16:41:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: Introduce tests TC_ul_tbf_{1,2}phase_while_dl_ass_pch

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29934 ) Change subject: pcu: Introduce tests TC_ul_tbf_{1,2}phase_while_dl_ass_pch ...................................................................... pcu: Introduce tests TC_ul_tbf_{1,2}phase_while_dl_ass_pch Related: OS#5700 Change-Id: I6a72c36265bfdc757180cbb466492ad6bbbf16ad --- M pcu/PCU_Tests.ttcn M pcu/expected-results.xml 2 files changed, 155 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/34/29934/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 6d17d96..049b0cd 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -3965,6 +3965,157 @@ f_shutdown(__BFILE__, __LINE__, final := true); } +/* Scenario: MS creates a UL TBF and + * finishes sending data (CV=0), which is forwarded to SGSN by PCU. PCU acks with + * FINAL_ACK=1 (hence UL TBF moves to FINISHED state). Then SGSN answers and PCU + * has to assign a DL TBF on PCH. While the network is waiting for the MS to + * move to PDCH before transmitting DL data (timer X2002), the MS finds out it + * needs to send new UL data and hence sends a RACH request to create a new UL + * TBF. + * Make sure the the MS is assigned a DL TBF through PACCH in that case even if + * no new DL data is received from the SGSN. OS#5700. + * This test validates the specific case where the 2nd UL TBF is done through + * 1phase-access. + */ +testcase TC_ul_tbf_1phase_while_dl_ass_pch() runs on RAW_PCU_Test_CT { + var RlcmacDlBlock dl_block; + var octetstring data := f_rnd_octstring(10); + var uint32_t sched_fn; + var uint32_t poll_fn; + var uint32_t dl_fn; + var GprsMS ms; + timer T; + var octetstring payload; + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS)); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + /* Establish an Uplink TBF */ + f_ms_establish_ul_tbf(ms); + + /* Send one UL block (with TLLI since we are in One-Phase Access + contention resolution) and make sure it is ACKED fine. */ + payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); + dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); + payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); + f_ms_tx_ul_data_block(ms, payload, cv := 0); + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); + + /* 1 UL block should be received in SGSN */ + BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.bvc[0].cell_id)); + /* Now SGSN sends some DL data, PCU will page on CCCH (PCH) */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); + + /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); + f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + + /* Now the PCU is waiting for the MS to move to PDCH in order to send data to it (timer X2002). + * The MS decides it want to send new Ul TBF so it send RACH req to ask for it: */ + f_ms_establish_ul_tbf(ms); + + /* Send one UL block (with TLLI since we are in One-Phase Access + * contention resolution) and make sure it is ACKED fine. */ + payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); + dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + + /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); + + /* The PCU considers the MS to have gone over Contention Resolution + * after having sent the first UL ACK/NACK to it, hence next it will try to + * assign the DL-TBF to send the data it received from the SGSN previously: */ + f_ms_rx_pkt_ass_pacch(ms, poll_fn, tr_RLCMAC_DL_PACKET_ASS); + /* the MS ACKs the PKT_DL_ASS: */ + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), poll_fn); + + /* We should finally receive the DL-data that was received previosuly from the SGSN: */ + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + + f_shutdown(__BFILE__, __LINE__, final := true); +} + +/* Same as TC_ul_tbf_2phase_while_dl_ass_pch, but this test validates the + * specific case where the 2nd UL TBF is done through 2phase-access. */ +testcase TC_ul_tbf_2phase_while_dl_ass_pch() runs on RAW_PCU_Test_CT { + var RlcmacDlBlock dl_block; + var octetstring data := f_rnd_octstring(10); + var uint32_t sched_fn; + var uint32_t poll_fn; + var uint32_t dl_fn; + var GprsMS ms; + timer T; + var octetstring payload; + var PollFnCtx pollctx; + + /* Initialize NS/BSSGP side */ + f_init_bssgp(); + /* Initialize GPRS MS side */ + f_init_gprs_ms(); + ms := g_ms[0]; /* We only use first MS in this test */ + + /* Initialize the PCU interface abstraction */ + f_init_raw(testcasename(), ts_PCUIF_INFO_default(c_PCUIF_Flags_noMCS)); + + /* Establish BSSGP connection to the PCU */ + f_bssgp_establish(); + f_bssgp_client_llgmm_assign(TLLI_UNUSED, ms.tlli); + + /* Establish an Uplink TBF */ + f_ms_establish_ul_tbf(ms); + + /* Send one UL block (with TLLI since we are in One-Phase Access + contention resolution) and make sure it is ACKED fine. */ + payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); + dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); + payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); + f_ms_tx_ul_data_block(ms, payload, cv := 0); + f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); + + /* 1 UL block should be received in SGSN */ + BSSGP[0].receive(tr_BSSGP_UL_UD(ms.tlli, mp_gb_cfg.bvc[0].cell_id)); + /* Now SGSN sends some DL data, PCU will page on CCCH (PCH) */ + BSSGP[0].send(ts_BSSGP_DL_UD(ms.tlli, data)); + + /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), sched_fn); + f_ms_exp_dl_tbf_ass_ccch(ms, PCU_IF_SAPI_PCH); + + /* Now the PCU is waiting for the MS to move to PDCH in order to send data to it (timer X2002). + * The MS decides it want to send new Ul TBF so it send RACH req to ask for it: */ + pollctx := f_ms_establish_ul_tbf_2phase_access(ms, ts_RlcMacUlCtrl_PKT_RES_REQ(ms.tlli, ms_racap_gprs_def)); + + /* Pkt Uplink Assignment above sets poll+rrbp requesting PACKET CONTROL ACK */ + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), pollctx.fn, nr := pollctx.tstrxbts); + + /* Now that MS seized the UL-TBF, PCU sends DL-TBF Assignment on PACCH */ + f_ms_rx_pkt_ass_pacch(ms, poll_fn, tr_RLCMAC_DL_PACKET_ASS); + /* the MS ACKs the PKT_DL_ASS: */ + f_ms_tx_ul_block(ms, ts_RLCMAC_CTRL_ACK(ms.tlli), poll_fn); + + /* We should finally receive the DL-data that was received previosuly from the SGSN: */ + f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0); + + f_shutdown(__BFILE__, __LINE__, final := true); +} + private function f_TC_egprs_pkt_chan_req(in EGPRSPktChRequest req, template GsmRrMessage t_imm_ass := ?, PCUIF_BurstType bt := BURST_TYPE_1) @@ -6900,6 +7051,8 @@ execute( TC_dl_egprs_data_no_llc_ui_dummy() ); execute( TC_ul_tbf_finished_pkt_dl_ass_pch() ); + execute( TC_ul_tbf_1phase_while_dl_ass_pch() ); + execute( TC_ul_tbf_2phase_while_dl_ass_pch() ); /* EGPRS specific test cases */ execute( TC_egprs_pkt_chan_req_signalling() ); diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml index c666ff7..1f953aa 100644 --- a/pcu/expected-results.xml +++ b/pcu/expected-results.xml @@ -71,6 +71,8 @@ <testcase classname='PCU_Tests' name='TC_dl_gprs_data_no_llc_ui_dummy' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_dl_egprs_data_no_llc_ui_dummy' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ul_tbf_finished_pkt_dl_ass_pch' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_ul_tbf_1phase_while_dl_ass_pch' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_ul_tbf_2phase_while_dl_ass_pch' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_egprs_pkt_chan_req_signalling' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_egprs_pkt_chan_req_one_phase' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_egprs_pkt_chan_req_two_phase' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a72c36265bfdc757180cbb466492ad6bbbf16ad Gerrit-Change-Number: 29934 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: tbf_fsm: Introduce new event to act upon contention resolution success

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29932 ) Change subject: tbf_fsm: Introduce new event to act upon contention resolution success ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8b9555864d3615ce0a024b641c67921f82273a8d Gerrit-Change-Number: 29932 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Oct 2022 16:34:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Avoid losing DL-TBF during MS merge

by dexter

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29931 ) Change subject: Avoid losing DL-TBF during MS merge ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I29f4ffa904d79d58275c6596cc5ef6790b6e68c6 Gerrit-Change-Number: 29931 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Oct 2022 16:32:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022