October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: usb: Add support for new GPSDO status field "Accumulated error"

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29618 ) Change subject: usb: Add support for new GPSDO status field "Accumulated error" ...................................................................... Patch Set 5: (1 comment) File src/usb.c: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-e1d-lint-200): https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/bbcbc68d_8a7b7da2 PS5, Line 713: /* trailing whitespace -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 Gerrit-Change-Number: 29618 Gerrit-PatchSet: 5 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:41:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: cosmetic: Fix indentation

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29642 ) Change subject: osmux: cosmetic: Fix indentation ...................................................................... osmux: cosmetic: Fix indentation Change-Id: Ic7087e7907c1078d134d7d9b11ed6a6bf1941308 --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/42/29642/1 diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index c2b6ba1..d9a10a9 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -535,21 +535,21 @@ /* Wait until we have the connection information from MDCX */ if (!mgcp_rtp_end_remote_addr_available(&conn->end)) { LOGPCONN(conn->conn, DOSMUX, LOGL_INFO, - "Osmux remote address/port still unknown\n"); + "Osmux remote address/port still unknown\n"); return -1; } conn->osmux.in = osmux_handle_find_or_create(conn, rem_addr); if (!conn->osmux.in) { LOGPCONN(conn->conn, DOSMUX, LOGL_ERROR, - "Cannot allocate input osmux handle for conn:%s\n", - mgcp_conn_dump(conn->conn)); + "Cannot allocate input osmux handle for conn:%s\n", + mgcp_conn_dump(conn->conn)); return -1; } if (osmux_xfrm_input_open_circuit(conn->osmux.in, conn->osmux.remote_cid, osmux_dummy) < 0) { LOGPCONN(conn->conn, DOSMUX, LOGL_ERROR, - "Cannot open osmux circuit %u for conn:%s\n", - conn->osmux.remote_cid, mgcp_conn_dump(conn->conn)); + "Cannot open osmux circuit %u for conn:%s\n", + conn->osmux.remote_cid, mgcp_conn_dump(conn->conn)); return -1; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic7087e7907c1078d134d7d9b11ed6a6bf1941308 Gerrit-Change-Number: 29642 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Drop unused role parameter

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29641 ) Change subject: osmux: Drop unused role parameter ...................................................................... osmux: Drop unused role parameter Change-Id: I39c2852bb60aaba4f85188c55f157e4abec47a0e --- M include/osmocom/mgcp/osmux.h M src/libosmo-mgcp/mgcp_osmux.c M src/libosmo-mgcp/mgcp_protocol.c 3 files changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/41/29641/1 diff --git a/include/osmocom/mgcp/osmux.h b/include/osmocom/mgcp/osmux.h index 1da7c8b..903d58b 100644 --- a/include/osmocom/mgcp/osmux.h +++ b/include/osmocom/mgcp/osmux.h @@ -4,16 +4,11 @@ #include <osmocom/netif/osmux.h> struct mgcp_conn_rtp; -enum { - OSMUX_ROLE_BSC = 0, - OSMUX_ROLE_BSC_NAT, -}; - struct mgcp_trunk; struct mgcp_endpoint; struct mgcp_conn_rtp; -int osmux_init(int role, struct mgcp_trunk *trunk); +int osmux_init(struct mgcp_trunk *trunk); int osmux_init_conn(struct mgcp_conn_rtp *conn); int osmux_enable_conn(struct mgcp_endpoint *endp, struct mgcp_conn_rtp *conn, const struct osmo_sockaddr *addr); diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 302fd4d..c2b6ba1 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -440,7 +440,7 @@ return 0; } -int osmux_init(int role, struct mgcp_trunk *trunk) +int osmux_init(struct mgcp_trunk *trunk) { int ret; struct mgcp_config *cfg = trunk->cfg; diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 67a185a..1d286ed 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -741,7 +741,7 @@ static int mgcp_osmux_setup(struct mgcp_endpoint *endp, const char *line) { if (!endp->trunk->cfg->osmux_initialized) { - if (osmux_init(OSMUX_ROLE_BSC, endp->trunk) < 0) { + if (osmux_init(endp->trunk) < 0) { LOGPENDP(endp, DOSMUX, LOGL_ERROR, "Cannot init OSMUX\n"); return -3; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29641 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I39c2852bb60aaba4f85188c55f157e4abec47a0e Gerrit-Change-Number: 29641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Change couple log lines to OSMUX category

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29639 to look at the new patch set (#2). Change subject: osmux: Change couple log lines to OSMUX category ...................................................................... osmux: Change couple log lines to OSMUX category Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/39/29639/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf Gerrit-Change-Number: 29639 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Add claudators around IPv6 address to distinguish port in log ...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29640 ) Change subject: osmux: Add claudators around IPv6 address to distinguish port in log line ...................................................................... osmux: Add claudators around IPv6 address to distinguish port in log line Change-Id: I811ac5b4386f06c224f29f44f10dce4008fa7a4f --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/40/29640/1 diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 3be6d78..302fd4d 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -473,7 +473,7 @@ ret = mgcp_create_bind(cfg->osmux_addr_v6, &osmux_fd_v6, cfg->osmux_port, cfg->endp_dscp, cfg->endp_priority); if (ret < 0) { - LOGP(DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv6 socket to %s:%u\n", + LOGP(DOSMUX, LOGL_ERROR, "Cannot bind OSMUX IPv6 socket to [%s]:%u\n", cfg->osmux_addr_v6, cfg->osmux_port); return ret; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I811ac5b4386f06c224f29f44f10dce4008fa7a4f Gerrit-Change-Number: 29640 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Change couple log lines to OSMUX category

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29639 ) Change subject: osmux: Change couple log lines to OSMUX category ...................................................................... osmux: Change couple log lines to OSMUX category Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/39/29639/1 diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 46e1d6b..adfc448 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -741,10 +741,10 @@ { if (!endp->trunk->cfg->osmux_initialized) { if (osmux_init(OSMUX_ROLE_BSC, endp->trunk) < 0) { - LOGPENDP(endp, DLMGCP, LOGL_ERROR, "Cannot init OSMUX\n"); + LOGPENDP(endp, DOSMUX, LOGL_ERROR, "Cannot init OSMUX\n"); return -3; } - LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "OSMUX socket has been set up\n"); + LOGPENDP(endp, DOSMUX, LOGL_NOTICE, "OSMUX socket has been set up\n"); } return mgcp_parse_osmux_cid(line); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29639 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia04d08099f0b1e81707699d872779108f22522bf Gerrit-Change-Number: 29639 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: Log unexpected RSL message

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 ) Change subject: bts: Log unexpected RSL message ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/6f02d399_2853… PS2, Line 786: RSL PDU > But saying RSL PDU here? I thought you meant PDU as a generic thing so I put it here. I don't think it's really clarifying anything, in the end you end up looking at the code, the important part is printing the RSL message when available... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4 Gerrit-Change-Number: 29582 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:26:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bts: Log unexpected RSL message

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 ) Change subject: bts: Log unexpected RSL message ...................................................................... Patch Set 2: Code-Review-1 (2 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/b02712c6_38bb… PS2, Line 782: RSL_Message You're matching RSL PDU here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/01242d74_0c32… PS2, Line 786: RSL PDU But saying RSL PDU here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4 Gerrit-Change-Number: 29582 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:24:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29638 ) Change subject: osmux: Use setsockopt(IPV6_V6ONLY) on IPv6 socket ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Strange, when I run this in TTCN3 MGW_Tests docker setup, the sockopt fails with EINVAL: DOSMUX ERROR <0002> setsockopt(IPV6_V6ONLY, 1) failed on socket r=NULL<->l=fd02:db8:4::180:1984 errno=22 (mgcp_osmux.c:484) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29638 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0b120d016ff32369a8c077b601ec168928c38f0b Gerrit-Change-Number: 29638 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Oct 2022 08:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-e1d[master]: usb: Add support for new GPSDO status field "Accumulated error"

by tnt

Attention is currently required from: laforge. tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/29618 ) Change subject: usb: Add support for new GPSDO status field "Accumulated error" ...................................................................... Patch Set 4: (2 comments) File src/ice1usb_proto.h: https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/42d3e0ae_cc9420ce PS3, Line 68: int16_t err_acc; /*!< Accumulated error */ > I think it might make sense to add a comment that this field was added by firmware version `git desc […] I added a reference to the next (yet to be tagged/release) version (since it'll be the first to have it) and the exact commit. Note that this also means the ice1usb_proto.h here is different from the one in the firmware repo. Unless we add two commits for every ice1usb_proto.h change in the future (because you can't include the sha of the commit in the commit itself obviously unless you want to start looking for sha1 collisions ...) File src/usb.c: https://gerrit.osmocom.org/c/osmo-e1d/+/29618/comment/60ef83a1_92df85a4 PS3, Line 715: "Some values will be zeroed\n", > I don't think we want to send one NOTICE every status_cb. […] Yup notice is probably a bit much. Switched to DEBUG. Also added a wall of text explaining why this is needed and why the opposite case is not an issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/29618 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4222bf22267f8343abf1e97546111ceb1c299846 Gerrit-Change-Number: 29618 Gerrit-PatchSet: 4 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 08:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022