October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs/gerrit-binpkgs: new job for deb, rpm packages

by osmith

Attention is currently required from: fixeria, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29604 ) Change subject: jobs/gerrit-binpkgs: new job for deb, rpm packages ...................................................................... Patch Set 5: (1 comment) File jobs/gerrit-binpkgs.yml: https://gerrit.osmocom.org/c/osmo-ci/+/29604/comment/155a0829_edca1ee4 PS4, Line 86: rpm) distro="centos:8" ;; > I think it's better to avoid translation cause it's highly confusing while looking at the code. patch updated and added patch https://gerrit.osmocom.org/c/osmo-ci/+/29686/1 to fix this -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7ca8869c2e9f2e7c74a360933be12b5c2b47c2fc Gerrit-Change-Number: 29604 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Oct 2022 10:09:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: obs: build_binpkg: use almalinux:8 naming

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29686 ) Change subject: obs: build_binpkg: use almalinux:8 naming ...................................................................... obs: build_binpkg: use almalinux:8 naming Instead of using "--docker centos:8" as argument and translating it later on in the code to use "almalinux:8" as base distribution, use "--docker almalinux:8" as argument. It was brought up in code review that this makes it less confusing. Related: OS#2385 Change-Id: Id8298e8bafe065010f7bc00f1ff261aa6431ed4c --- M scripts/obs/data/build_binpkg.Dockerfile M scripts/obs/lib/config.py M scripts/obs/lib/docker.py 3 files changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/29686/1 diff --git a/scripts/obs/data/build_binpkg.Dockerfile b/scripts/obs/data/build_binpkg.Dockerfile index de53478..201c7e5 100644 --- a/scripts/obs/data/build_binpkg.Dockerfile +++ b/scripts/obs/data/build_binpkg.Dockerfile @@ -14,6 +14,7 @@ # https://build.opensuse.org/projects/CentOS:CentOS-8/prjconf # For debian, make sure we don't have man pages as otherwise it takes some time # to regenerate the manuals database when installing build dependencies. +# SYS#5818: using almalinux:8 instead of centos:8 RUN case "$DISTRO" in \ debian*) \ echo "path-exclude=/usr/share/man/*" \ @@ -29,7 +30,7 @@ && \ apt-get clean \ ;; \ - centos*) \ + almalinux*) \ dnf -y install \ autoconf \ automake \ @@ -58,7 +59,7 @@ echo "deb https://downloads.osmocom.org/packages/osmocom:/master/Debian_11/ ./" \ > /etc/apt/sources.list.d/osmocom-master.list \ ;; \ - centos:8) \ + almalinux:8) \ { echo "[network_osmocom_master]"; \ echo "name=Nightly packages of the Osmocom project (CentOS_8)"; \ echo "type=rpm-md"; \ diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index 393251b..d9f6bfe 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -113,5 +113,5 @@ docker_distro_default = "debian:11" docker_distro_other = [ - "centos:8", + "almalinux:8", # instead of centos:8 (SYS#5818) ] diff --git a/scripts/obs/lib/docker.py b/scripts/obs/lib/docker.py index 136aeeb..87611e3 100644 --- a/scripts/obs/lib/docker.py +++ b/scripts/obs/lib/docker.py @@ -19,10 +19,6 @@ if image_type.endswith("_manuals"): return get_image_name(distro, image_type.replace("_manuals", "")) - # CentOS 8 is EOL (SYS#5818) - if distro == "centos:8": - return "almalinux:8" - return distro -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id8298e8bafe065010f7bc00f1ff261aa6431ed4c Gerrit-Change-Number: 29686 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-binpkgs: new job for deb, rpm packages

by osmith

Attention is currently required from: osmith, fixeria. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/29604 to look at the new patch set (#5). Change subject: jobs/gerrit-binpkgs: new job for deb, rpm packages ...................................................................... jobs/gerrit-binpkgs: new job for deb, rpm packages Build deb and rpm packages for each patch submitted to gerrit for the projects in the list. Example: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 Related: OS#2385 Change-Id: I7ca8869c2e9f2e7c74a360933be12b5c2b47c2fc --- A jobs/gerrit-binpkgs.yml M jobs/gerrit-verifications.yml 2 files changed, 205 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/04/29604/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7ca8869c2e9f2e7c74a360933be12b5c2b47c2fc Gerrit-Change-Number: 29604 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-bsc-nat[master]: [do not merge] test rpm/deb CI

by Jenkins Builder

Attention is currently required from: osmith. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 ) Change subject: [do not merge] test rpm/deb CI ...................................................................... Patch Set 5: Verified+1 4 passed: [build] https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-bsc-nat-build/a1=defaul… [rpm] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-rpm/10/consoleFull [deb] https://jenkins.osmocom.org/jenkins/job/gerrit-binpkgs-deb/8/consoleFull [lint] https://jenkins.osmocom.org/jenkins/job/gerrit-lint/15/consoleFull Build Successful -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6842b5c641e6b6a0cfb428c7538e0a041751143e Gerrit-Change-Number: 29492 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Oct 2022 10:01:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc-nat[master]: [do not merge] test rpm/deb CI

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 to look at the new patch set (#5). Change subject: [do not merge] test rpm/deb CI ...................................................................... [do not merge] test rpm/deb CI Change-Id: I6842b5c641e6b6a0cfb428c7538e0a041751143e --- A test2 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/92/29492/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6842b5c641e6b6a0cfb428c7538e0a041751143e Gerrit-Change-Number: 29492 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: measurement: do not call msgb_l3len without checking

by dexter

Attention is currently required from: pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29651 ) Change subject: measurement: do not call msgb_l3len without checking ...................................................................... Patch Set 2: (1 comment) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/29651/comment/23bd9a10_d3f67220 PS1, Line 920: int l3_len; > I think the code is more readable when we use the variables. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie5a9fe1ba880e68edb74f5f4ca559ac191330d4f Gerrit-Change-Number: 29651 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Oct 2022 09:53:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: rsl: use unsigned int

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/29685 ) Change subject: rsl: use unsigned int ...................................................................... rsl: use unsigned int The parameter l3_len in rsl_tx_meas_res() is defined as int, even though it can't be negative. Lets use unsigned int for l3_len. Change-Id: I99068a36e74a557000f406154dce32300615086c --- M include/osmo-bts/rsl.h M src/common/rsl.c 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/85/29685/1 diff --git a/include/osmo-bts/rsl.h b/include/osmo-bts/rsl.h index a530734..7f31ea9 100644 --- a/include/osmo-bts/rsl.h +++ b/include/osmo-bts/rsl.h @@ -30,6 +30,6 @@ int rsl_tx_cbch_load_indication(struct gsm_bts *bts, bool ext_cbch, bool overflow, uint8_t amount); -int rsl_tx_meas_res(struct gsm_lchan *lchan, const uint8_t *l3, int l3_len, int timing_offset); +int rsl_tx_meas_res(struct gsm_lchan *lchan, const uint8_t *l3, unsigned int l3_len, int timing_offset); #endif // _RSL_H */ diff --git a/src/common/rsl.c b/src/common/rsl.c index 8aa9b78..91af6cb 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -3493,7 +3493,7 @@ } __attribute__((packed)); /* Compose and send 8.4.8 MEASUREMENT RESult via RSL. (timing_offset=-1 -> not present) */ -int rsl_tx_meas_res(struct gsm_lchan *lchan, const uint8_t *l3, int l3_len, int timing_offset) +int rsl_tx_meas_res(struct gsm_lchan *lchan, const uint8_t *l3, unsigned int l3_len, int timing_offset) { struct msgb *msg; uint8_t meas_res[16]; @@ -3512,7 +3512,7 @@ return -ENOMEM; LOGPLCHAN(lchan, DRSL, LOGL_DEBUG, - "Send Meas RES: NUM:%u, RXLEV_FULL:%u, RXLEV_SUB:%u, RXQUAL_FULL:%u, RXQUAL_SUB:%u, MS_PWR:%u, UL_TA:%u, L3_LEN:%d, TimingOff:%u\n", + "Send Meas RES: NUM:%u, RXLEV_FULL:%u, RXLEV_SUB:%u, RXQUAL_FULL:%u, RXQUAL_SUB:%u, MS_PWR:%u, UL_TA:%u, L3_LEN:%u, TimingOff:%u\n", lchan->meas.res_nr, lchan->meas.ul_res.full.rx_lev, lchan->meas.ul_res.sub.rx_lev, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I99068a36e74a557000f406154dce32300615086c Gerrit-Change-Number: 29685 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: measurement: do not call msgb_l3len without checking

by dexter

Attention is currently required from: pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29651 ) Change subject: measurement: do not call msgb_l3len without checking ...................................................................... Patch Set 2: (2 comments) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/29651/comment/bb902927_849f53c3 PS1, Line 920: int l3_len; > That should be usigned. […] I think the code is more readable when we use the variables. https://gerrit.osmocom.org/c/osmo-bts/+/29651/comment/023a9241_3c64aa85 PS1, Line 951: l3_len = 0; > l3_len = l3 ? msgb_l3len(msg) : 0; Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie5a9fe1ba880e68edb74f5f4ca559ac191330d4f Gerrit-Change-Number: 29651 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Oct 2022 09:46:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: measurement: do not call msgb_l3len without checking

by dexter

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/29651 to look at the new patch set (#2). Change subject: measurement: do not call msgb_l3len without checking ...................................................................... measurement: do not call msgb_l3len without checking The function lchan_meas_handle_sacch() calls msgb_l3len without checking if l3h is even populated. Lets add a check to be sure. Change-Id: Ie5a9fe1ba880e68edb74f5f4ca559ac191330d4f --- M src/common/measurement.c 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/51/29651/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie5a9fe1ba880e68edb74f5f4ca559ac191330d4f Gerrit-Change-Number: 29651 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-bts[master]: l1sap: do not call msgb_l2hlen without checking

by dexter

Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/29650 ) Change subject: l1sap: do not call msgb_l2hlen without checking ...................................................................... Patch Set 2: (2 comments) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/29650/comment/ad0e92b5_706bec7b PS1, Line 352: *len = 0; > Agreed with Pau here. Done https://gerrit.osmocom.org/c/osmo-bts/+/29650/comment/b3302d05_5a7b02e0 PS1, Line 396: *len = 0; > Same Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/29650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie13d0724f183ff240714dcdbd24e5a21b4276bfe Gerrit-Change-Number: 29650 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 11 Oct 2022 09:46:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022