Attention is currently required from: dexter.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36324?usp=email )

Change subject: msgb: Also copy msgb {dst, lchan, cb} during msgb_copy_* ......................................................................

Patch Set 2:

(1 comment)

File src/core/msgb.c:

https://gerrit.osmocom.org/c/libosmocore/+/36324/comment/8d80ac34_4e0e9f4a PS1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied.

mh, ok. so the old function was *specified* not to copy the cb. That's weird. […]

I did a rather exhaustive study and could not find any osmocoom code that would rely on the existing behaviour of not copying the cb. It should therefore be safe to merge this patch, but of course the comment should be updated to reflect reality.

I still don't feel 100% allright with changing the semantics. Even if I believe the cb should always have been copied, we had different behaviour since the function was introduced in 2015...