Attention is currently required from: dexter.

View Change

1 comment:

• File src/core/msgb.c:

  • Patch Set #1, Line 320: * and adjusts the pointers (incl l1h-l4h) accordingly. The cb part is not copied.

    mh, ok. so the old function was *specified* not to copy the cb. That's weird. […]

    I did a rather exhaustive study and could not find any osmocoom code that would rely on the existing behaviour of not copying the cb. It should therefore be safe to merge this patch, but of course the comment should be updated to reflect reality.

    I still don't feel 100% allright with changing the semantics. Even if I believe the cb should always have been copied, we had different behaviour since the function was introduced in 2015...

To view, visit change 36324. To unsubscribe, or for help writing mail filters, visit settings.