Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32181 ) Change subject: tests: Add initial osmo_io tests ...................................................................... Patch Set 1: (8 comments) File tests/osmo_io/osmo_io_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/27eff49c_1e48ab40 PS1, Line 54: printf("%s: Write returned rc=%d\n",osmo_iofd_get_name(iofd), rc); space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/aa6f4db0_134bf382 PS1, Line 66: static void test_connected() { Bad function definition - void test_connected() should probably be void test_connected(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/0dbe83bf_f48cbef0 PS1, Line 66: static void test_connected() { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/4e42760b_a142fe08 PS1, Line 94: for (int i = 0; i < 128; i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/ff17bdc2_1fe03a63 PS1, Line 116: static void test_unconnected() { Bad function definition - void test_unconnected() should probably be void test_unconnected(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/9d32669c_dfbc20b2 PS1, Line 116: static void test_unconnected() { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/3d71b0aa_530e488b PS1, Line 144: for (int i = 0; i < 128; i++) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658): https://gerrit.osmocom.org/c/libosmocore/+/32181/comment/71fa8615_3e680c15 PS1, Line 172: } adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32181 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia67629e53f4d2e5784177250d58e268fdfcaa0c2 Gerrit-Change-Number: 32181 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 31 Mar 2023 15:50:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment