Attention is currently required from: osmith, Hoernchen, neels, laforge, pespin, fixeria.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30934 )
Change subject: Add osmo_io with initial poll backend
......................................................................
Patch Set 6:
(2 comments)
File include/osmocom/core/osmo_io.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5659):
https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/f96e35e9_08303690
PS6, Line 73: const char *osmo_iofd_get_name(const struct osmo_io_fd *iofd);
adding a line without newline at end of file
File src/core/osmo_io.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5659):
https://gerrit.osmocom.org/c/libosmocore/+/30934/comment/0dd7b7a0_4e84460c
PS6, Line 460: int osmo_iofd_unregister(struct osmo_io_fd *iofd)
please, no spaces at the start of a line
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30934
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I50d73cf550d6ce8154bf827bf47408131cf5b0a0
Gerrit-Change-Number: 30934
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 31 Mar 2023 15:50:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment