8 comments:
File tests/osmo_io/osmo_io_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
Patch Set #1, Line 54: printf("%s: Write returned rc=%d\n",osmo_iofd_get_name(iofd), rc);
space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
Patch Set #1, Line 66: static void test_connected() {
Bad function definition - void test_connected() should probably be void test_connected(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
Patch Set #1, Line 66: static void test_connected() {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
Patch Set #1, Line 94: for (int i = 0; i < 128; i++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
Patch Set #1, Line 116: static void test_unconnected() {
Bad function definition - void test_unconnected() should probably be void test_unconnected(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
Patch Set #1, Line 116: static void test_unconnected() {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
Patch Set #1, Line 144: for (int i = 0; i < 128; i++) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-5658):
adding a line without newline at end of file
To view, visit change 32181. To unsubscribe, or for help writing mail filters, visit settings.