Attention is currently required from: arehbein.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31595 )
Change subject: osmo_wqueue_init(): Fix parameter type
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
In general I agree, but I'm worried about potential fall-out in applications. It
really is an API Change, and if somebody compiles their software with strict integer type
checks, compilation might now fail after the patch applied.
So we have the option of
a) breaking the API, but think we can get away with it (we might)
b) introduce a new wqueue_init2() function (is it worth the effort)
c) doing nothing, keep it as-is. After all, there's no use case of a queue with more
than INT32_MAX entries, and wqueue_init() could and should check that no negative values
are passed in by the caller.
I personally would go for "c"
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31595
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c9295750e1755bf1d80f3a3b32efc2aefb11a57
Gerrit-Change-Number: 31595
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 18:18:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment