Attention is currently required from: arehbein.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    In general I agree, but I'm worried about potential fall-out in applications. It really is an API Change, and if somebody compiles their software with strict integer type checks, compilation might now fail after the patch applied.

    So we have the option of
    a) breaking the API, but think we can get away with it (we might)
    b) introduce a new wqueue_init2() function (is it worth the effort)
    c) doing nothing, keep it as-is. After all, there's no use case of a queue with more than INT32_MAX entries, and wqueue_init() could and should check that no negative values are passed in by the caller.

    I personally would go for "c"

To view, visit change 31595. To unsubscribe, or for help writing mail filters, visit settings.