Attention is currently required from: jolly, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31108 ) Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps. ...................................................................... Patch Set 4: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/aff45344_a90148a2 PS2, Line 26: gsmtap-category

tbh, I don't get the "sapi" vs "category" difference here. […] There's several topics here:

* "sapi" naming: I can rename this from "gsmtap-sapi" to "gsm-channel" or "lchan" as fixeria suggests, since indeed the "sapi" thing seems to come from l1 in sysmobts. * "sapi" vs "category": It's not really CS vs PS we are discussing here. The idea is that this VTY config severes purpose for any layer23 app, which is both CS and PS. The idea here is that in general the "sapi" level (aka now "lchan", eg "lchan pdtch") serves the purpose of enabling/disabling gsmtap sending messages received/sent on that lchan. For GPRS, we really want to have finer granularity on higher layer than simply enabling or disabling the entire lchan, and hence it is why we have an extra set of commands to enable/disable which type of messages are logged. So MY PROPOSAL: - (I already updated the code using the enum/value_string from libosmcoore) - rename "gsmtap-sapi" to "lchan" and "gsmtap-category" to "category gprs". I don't like the idea of having "category pdtch" here because for instance for "dl-unknown" one doesn't really know whether it's PDTCH or PACCH. In fact the PACCH is all a bit blurry to me, having to check too many levels to find out whether it's PACCH vs PDTCH. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31108 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839 Gerrit-Change-Number: 31108 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 12:04:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment