Attention is currently required from: jolly, laforge, fixeria.

View Change

1 comment:

• Commit Message:

  • Patch Set #2, Line 26: gsmtap-category

    tbh, I don't get the "sapi" vs "category" difference here. […]

    There's several topics here:

    • "sapi" naming: I can rename this from "gsmtap-sapi" to "gsm-channel" or "lchan" as fixeria suggests, since indeed the "sapi" thing seems to come from l1 in sysmobts.
    • "sapi" vs "category":
    • It's not really CS vs PS we are discussing here. The idea is that this VTY config severes purpose for any layer23 app, which is both CS and PS. The idea here is that in general the "sapi" level (aka now "lchan", eg "lchan pdtch") serves the purpose of enabling/disabling gsmtap sending messages received/sent on that lchan.

    For GPRS, we really want to have finer granularity on higher layer than simply enabling or disabling the entire lchan, and hence it is why we have an extra set of commands to enable/disable which type of messages are logged.

    So MY PROPOSAL:

    • (I already updated the code using the enum/value_string from libosmcoore)
    • rename "gsmtap-sapi" to "lchan" and "gsmtap-category" to "category gprs". I don't like the idea of having "category pdtch" here because for instance for "dl-unknown" one doesn't really know whether it's PDTCH or PACCH. In fact the PACCH is all a bit blurry to me, having to check too many levels to find out whether it's PACCH vs PDTCH.

To view, visit change 31108. To unsubscribe, or for help writing mail filters, visit settings.