Attention is currently required from: daniel, fixeria, jolly, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email )
Change subject: utils: Link with libosmoisdn to avoid undefined references
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Those symbols are needed for libosmogsm. In
`src/gsm/Makefile.am` we list `libosmoisdn. […]
Running `make -C utils/ V=s`
locally:
```
depbase=`echo osmo-arfcn.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../include -DBUILDING_LIBOSMOCORE -Wall -Wall
-pthread -std=gnu11 -DBUILDING_LIBOSMOCORE -Wall -MT osmo-arfcn.o -MD -MP -MF
$depbase.Tpo -c -o osmo-arfcn.o osmo-arfcn.c &&\
mv -f $depbase.Tpo $depbase.Po
/bin/sh ../libtool --tag=CC --mode=link gcc -Wall -pthread -std=gnu11
-DBUILDING_LIBOSMOCORE -Wall -o osmo-arfcn osmo-arfcn.o ../src/core/libosmocore.la
../src/gsm/libosmogsm.la
libtool: link: gcc -Wall -std=gnu11 -DBUILDING_LIBOSMOCORE -Wall -o .libs/osmo-arfcn
osmo-arfcn.o ../src/core/.libs/libosmocore.so ../src/gsm/.libs/libosmogsm.so
/home/fixeria/projects/osmocom/libosmocore/src/isdn/.libs/libosmoisdn.so
/home/fixeria/projects/osmocom/libosmocore/src/core/.libs/libosmocore.so -lsctp -luring
-lmnl -ltalloc -lgnutls -pthread -Wl,-rpath -Wl,/usr/local/lib
```
In my case `libosmoisdn.la` is listed, as expected. I can even remove `libosmocore.la`
from the `LDADD` and the build would still succeed, since it's also an implicit
dependency of `libosmogsm.la`.
```
fixeria@LEGION:~$ libtool --version
libtool (GNU libtool) 2.4.7.4-1ec8f-dirty
fixeria@LEGION:~$ /bin/ld -v
GNU ld (GNU Binutils) 2.41.0
fixeria@LEGION:~$ gcc -v
gcc version 13.2.1 20230801 (GCC)
```
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9e99231899b269a4ec0faf720aff4dc8d2b74323
Gerrit-Change-Number: 35163
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator(a)gmail.com>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: fixeria <axilirator(a)gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 21:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment