Attention is currently required from: daniel, fixeria, jolly, laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email )
Change subject: utils: Link with libosmoisdn to avoid undefined references
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/35163/comment/ec36a68b_72005910
PS1, Line 10: osmo-arfcn
Weird. osmo-arfcn is not calling any of these functions. It should not depend on LAPDm at
all, it's just a very simple "calculator". Perhaps it's the
`-no-undefined` in `libosmogsm_la_LDFLAGS` somehow triggering the linker? I am unable to
reproduce this when building libosmocore locally.
Patchset:
PS1:
I think this is wrong. […]
Those symbols are
needed for libosmogsm. In `src/gsm/Makefile.am` we list `libosmoisdn.la` as a dependency
of `libgsmint.la`, which in turn is a dependency of `libosmogsm.la`. I would expect
`libosmoisdn.la` to be an explicit dependency of `libosmogsm.la`, just like the
`libosmocore.la`.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I9e99231899b269a4ec0faf720aff4dc8d2b74323
Gerrit-Change-Number: 35163
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator(a)gmail.com>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: fixeria <axilirator(a)gmail.com>
Gerrit-Comment-Date: Wed, 29 Nov 2023 20:55:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment