Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27061 )
Change subject: ggsn: Set up diameter for open5gs
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27061
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iedadb98be2a2e851b75e4e67c22bca7047191fec
Gerrit-Change-Number: 27061
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 16:11:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27060 )
Change subject: ggsn: Add module parameter to run tests against open5gs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27060
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb3ed73f0f9a20c14d73891ba8b8051f823ab8
Gerrit-Change-Number: 27060
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 16:11:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27061
to look at the new patch set (#2).
Change subject: ggsn: Set up diameter for open5gs
......................................................................
ggsn: Set up diameter for open5gs
Change-Id: Iedadb98be2a2e851b75e4e67c22bca7047191fec
---
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
3 files changed, 84 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/27061/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27061
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iedadb98be2a2e851b75e4e67c22bca7047191fec
Gerrit-Change-Number: 27061
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/27066
to look at the new patch set (#2).
Change subject: jobs/gerrit-verifications-dahdi.yml: new file
......................................................................
jobs/gerrit-verifications-dahdi.yml: new file
Add gerrit verifications for the out-of-tree dahdi-linux kernel module.
Put this in a separate file (not gerrit-verifications.yml), because:
* not only gerrit git repo gets cloned, but also linux.git, and caching
needs to be done properly for it
* so we can have one separate job per linux version that gets tested
Test v4.19 and v5.10 for now, as suggested in the issue.
Related: OS#5407
Depends: docker-playground Id72d19ad08681cd7cb3194de2226292f19e96df5
Change-Id: I65c7663a6b8045796536a727e4adf5554f16b2a9
---
A jobs/gerrit-verifications-dahdi.yml
1 file changed, 98 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/66/27066/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27066
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I65c7663a6b8045796536a727e4adf5554f16b2a9
Gerrit-Change-Number: 27066
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27067 )
Change subject: debian-bullseye-titan: run 8 parallel jobs for 'make deps'
......................................................................
debian-bullseye-titan: run 8 parallel jobs for 'make deps'
This reduces the time required for building test suites.
Change-Id: I6349d8304a248c7ae2a5373bf23a691f3a1cb991
---
M debian-bullseye-titan/Dockerfile
M debian-bullseye-titan/ttcn3-docker-prepare.sh
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
fixeria: Verified
diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile
index 0b1fbda..1c22456 100644
--- a/debian-bullseye-titan/Dockerfile
+++ b/debian-bullseye-titan/Dockerfile
@@ -65,7 +65,7 @@
RUN if ! diff -q /tmp/deps-Makefile /osmo-ttcn3-hacks/deps/Makefile; then \
cd /osmo-ttcn3-hacks && \
git pull && \
- make deps; \
+ make -j8 deps; \
fi
ADD ttcn3-docker-prepare.sh /usr/local/bin/ttcn3-docker-prepare
diff --git a/debian-bullseye-titan/ttcn3-docker-prepare.sh b/debian-bullseye-titan/ttcn3-docker-prepare.sh
index e4144e2..c2b28b9 100755
--- a/debian-bullseye-titan/ttcn3-docker-prepare.sh
+++ b/debian-bullseye-titan/ttcn3-docker-prepare.sh
@@ -29,7 +29,7 @@
# OSMO_TTCN3_BRANCH is different). The Dockerfile does the initial 'make deps'
# and downloads /tmp/deps-Makefile.
if ! diff -q /tmp/deps-Makefile deps/Makefile; then
- make deps
+ make -j8 deps
fi
# Link start/stop scripts to /
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6349d8304a248c7ae2a5373bf23a691f3a1cb991
Gerrit-Change-Number: 27067
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: laforge, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27070 )
Change subject: open5gs-master: install dependencies using mk-build-deps
......................................................................
Patch Set 1: -Code-Review
(1 comment)
Patchset:
PS1:
(Added +1 by accident, I did have some comments that I suggest to address first.)
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27070
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I71ad7256116ee30f15aff38fd38588aa2bfab456
Gerrit-Change-Number: 27070
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 13:24:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27070 )
Change subject: open5gs-master: install dependencies using mk-build-deps
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File open5gs-master/Dockerfile:
https://gerrit.osmocom.org/c/docker-playground/+/27070/comment/ccc18beb_43f…
PS1, Line 31: RUN git clone https://github.com/$GITHUB_USER/$GITHUB_REPO
Maybe install dependencies here too? Then it wouldn't need to download all packages from debian/control each time the commit changes, only if new dependencies were added between when the docker container was created and the current master.
https://gerrit.osmocom.org/c/docker-playground/+/27070/comment/a0b25a59_c09…
PS1, Line 40: mk-build-deps -i -r -t 'apt-get --no-install-recommends -yV'
"apt-get build-dep ." should do the same, not sure if it internally uses mk-build-deps. If not, maybe we don't even need this dependency.
As mentioned here: https://osmocom.org/projects/cellular-infrastructure/wiki/Build_from_Source…
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27070
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I71ad7256116ee30f15aff38fd38588aa2bfab456
Gerrit-Change-Number: 27070
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 13:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27067 )
Change subject: debian-bullseye-titan: run 8 parallel jobs for 'make deps'
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6349d8304a248c7ae2a5373bf23a691f3a1cb991
Gerrit-Change-Number: 27067
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 13:15:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27067 )
Change subject: debian-bullseye-titan: run 8 parallel jobs for 'make deps'
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6349d8304a248c7ae2a5373bf23a691f3a1cb991
Gerrit-Change-Number: 27067
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 12:59:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27067 )
Change subject: debian-bullseye-titan: run 8 parallel jobs for 'make deps'
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6349d8304a248c7ae2a5373bf23a691f3a1cb991
Gerrit-Change-Number: 27067
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 12:56:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27067 )
Change subject: debian-bullseye-titan: run 8 parallel jobs for 'make deps'
......................................................................
debian-bullseye-titan: run 8 parallel jobs for 'make deps'
This reduces the time required for building test suites.
Change-Id: I6349d8304a248c7ae2a5373bf23a691f3a1cb991
---
M debian-bullseye-titan/Dockerfile
M debian-bullseye-titan/ttcn3-docker-prepare.sh
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/67/27067/1
diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile
index 0b1fbda..1c22456 100644
--- a/debian-bullseye-titan/Dockerfile
+++ b/debian-bullseye-titan/Dockerfile
@@ -65,7 +65,7 @@
RUN if ! diff -q /tmp/deps-Makefile /osmo-ttcn3-hacks/deps/Makefile; then \
cd /osmo-ttcn3-hacks && \
git pull && \
- make deps; \
+ make -j8 deps; \
fi
ADD ttcn3-docker-prepare.sh /usr/local/bin/ttcn3-docker-prepare
diff --git a/debian-bullseye-titan/ttcn3-docker-prepare.sh b/debian-bullseye-titan/ttcn3-docker-prepare.sh
index e4144e2..c2b28b9 100755
--- a/debian-bullseye-titan/ttcn3-docker-prepare.sh
+++ b/debian-bullseye-titan/ttcn3-docker-prepare.sh
@@ -29,7 +29,7 @@
# OSMO_TTCN3_BRANCH is different). The Dockerfile does the initial 'make deps'
# and downloads /tmp/deps-Makefile.
if ! diff -q /tmp/deps-Makefile deps/Makefile; then
- make deps
+ make -j8 deps
fi
# Link start/stop scripts to /
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27067
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6349d8304a248c7ae2a5373bf23a691f3a1cb991
Gerrit-Change-Number: 27067
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: osmith.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27059 )
Change subject: contrib/jenkins.sh: new file
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27059
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I904ab66a1ecd72492642ac2cc4cb102c7283c590
Gerrit-Change-Number: 27059
Gerrit-PatchSet: 7
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 11:46:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/27063
to look at the new patch set (#3).
Change subject: Add ttcn3-ggsn-ogs testsuite
......................................................................
Add ttcn3-ggsn-ogs testsuite
This new setup allows running TTCN3 GGSN_Tests against open5gs, which
will soon gain GTPv1C support.
Change-Id: Ia6c122fce951d369a5d2362cbe99d10d61c15f49
---
A ttcn3-ggsn-test-ogs/jenkins.sh
A ttcn3-ggsn-test-ogs/ogs
A ttcn3-ggsn-test/jenkins-ogs.sh
A ttcn3-ggsn-test/ogs/GGSN_Tests.cfg
A ttcn3-ggsn-test/ogs/freediameter.conf
A ttcn3-ggsn-test/ogs/smfd.yaml
A ttcn3-ggsn-test/ogs/upfd-setup.sh
A ttcn3-ggsn-test/ogs/upfd.sh
A ttcn3-ggsn-test/ogs/upfd.yaml
9 files changed, 1,166 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/63/27063/3
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c122fce951d369a5d2362cbe99d10d61c15f49
Gerrit-Change-Number: 27063
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
Hello fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/27063
to look at the new patch set (#2).
Change subject: Add ttcn3-ggsn-ogs testsuite
......................................................................
Add ttcn3-ggsn-ogs testsuite
This new setup allows running TTCN3 GGSN_Tests against open5gs, which
will soon gain GTPv1C support.
Change-Id: Ia6c122fce951d369a5d2362cbe99d10d61c15f49
---
A ttcn3-ggsn-test-ogs/jenkins.sh
A ttcn3-ggsn-test-ogs/ogs
A ttcn3-ggsn-test/jenkins-ogs.sh
A ttcn3-ggsn-test/ogs/GGSN_Tests.cfg
A ttcn3-ggsn-test/ogs/freediameter.conf
A ttcn3-ggsn-test/ogs/smfd.yaml
A ttcn3-ggsn-test/ogs/upfd-setup.sh
A ttcn3-ggsn-test/ogs/upfd.sh
A ttcn3-ggsn-test/ogs/upfd.yaml
9 files changed, 1,132 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/63/27063/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c122fce951d369a5d2362cbe99d10d61c15f49
Gerrit-Change-Number: 27063
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27063 )
Change subject: Add ttcn3-ggsn-ogs testsuite
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-ggsn-test/jenkins-ogs.sh:
https://gerrit.osmocom.org/c/docker-playground/+/27063/comment/05b75321_866…
PS1, Line 42: /data/open5gs-smfd.out
> What's the point of having /data/open5gs-smfd. […]
Yes, it really helped. Furthermore the out file seems to actually contains colors which make it also easier to read. Also it's easier plugging it gdb in ther eif the line already exists (I'm running it under gdb to get a backtrace automatically to stdout when the program exits/crashes).
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27063
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ia6c122fce951d369a5d2362cbe99d10d61c15f49
Gerrit-Change-Number: 27063
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 08:39:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27061 )
Change subject: ggsn: Set up diameter for open5gs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27061/comment/2b0f0627_ee97…
PS1, Line 194: friend
Why 'friend'? Is it [going to be] used by some other module?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27061
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iedadb98be2a2e851b75e4e67c22bca7047191fec
Gerrit-Change-Number: 27061
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 08:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27060 )
Change subject: ggsn: Add module parameter to run tests against open5gs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27060
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb3ed73f0f9a20c14d73891ba8b8051f823ab8
Gerrit-Change-Number: 27060
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 04 Feb 2022 08:36:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment