- gerrit-log - lists.osmocom.org

Change in docker-playground[master]: Remove debian-buster-erlang

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/27215 ) Change subject: Remove debian-buster-erlang ...................................................................... Remove debian-buster-erlang We don't need the image anymore, we use debian-bullseye-erlang. Change-Id: I6f22642f5f67a173b17db55aa7a7bda3d9debd54 --- D debian-buster-erlang/Dockerfile D debian-buster-erlang/Makefile 2 files changed, 0 insertions(+), 57 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/15/27215/1 diff --git a/debian-buster-erlang/Dockerfile b/debian-buster-erlang/Dockerfile deleted file mode 100644 index 10b2c88..0000000 --- a/debian-buster-erlang/Dockerfile +++ /dev/null @@ -1,54 +0,0 @@ -ARG REGISTRY=docker.io -FROM ${REGISTRY}/debian:buster -# Arguments used after FROM must be specified again -ARG OSMOCOM_REPO_MIRROR="http://download.opensuse.org" -ARG OSMOCOM_REPO_PATH="repositories/network:/osmocom:" - -MAINTAINER Harald Welte <laforge(a)gnumonks.org> - -ARG OSMOCOM_REPO="${OSMOCOM_REPO_MIRROR}/${OSMOCOM_REPO_PATH}/latest/Debian_10/" - -# install the erlang vm and rebar (2) -RUN apt-get update && \ - apt-get upgrade -y && \ - apt-get -y install \ - erlang \ - rebar - -# add rebar3 -ADD https://s3.amazonaws.com/rebar3/rebar3 /usr/bin/rebar3 -RUN chmod 0755 /usr/bin/rebar3 - -# install ninimal build utilities as well as system utilities -RUN apt-get update && \ - apt-get -y install \ - build-essential \ - git \ - procps \ - tcpdump \ - vim \ - netcat-openbsd \ - wget \ - && \ - apt-get clean - -# install additional C-language / system dependencies of our Erlang projects -RUN apt-get update && \ - apt-get -y install \ - libpcap-dev \ - && \ - apt-get clean - -# add osmocom latest repo, should we ever require packages from there -RUN apt-get update && apt-get install -y \ - gnupg -COPY .common/Release.key /tmp/Release.key -RUN apt-key add /tmp/Release.key && \ - rm /tmp/Release.key && \ - echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-latest.list -ADD $OSMOCOM_REPO/Release /tmp/Release - -# add a non-root user under which we will normaly execute build tests -RUN useradd -m build -WORKDIR /home/build -USER build diff --git a/debian-buster-erlang/Makefile b/debian-buster-erlang/Makefile deleted file mode 100644 index 67066b3..0000000 --- a/debian-buster-erlang/Makefile +++ /dev/null @@ -1,3 +0,0 @@ -UPSTREAM_DISTRO=debian:buster -DISTRO=debian-buster -include ../make/Makefile -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27215 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6f22642f5f67a173b17db55aa7a7bda3d9debd54 Gerrit-Change-Number: 27215 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in libosmocore[master]: gsm0808: Test if we properly decode a SRVCC cell identifier list

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27212 ) Change subject: gsm0808: Test if we properly decode a SRVCC cell identifier list ...................................................................... gsm0808: Test if we properly decode a SRVCC cell identifier list We don't handle this correctly, as we decided to overload the meaning of 0b1011 in a cell identifier list (defined by 3GPP as used in SRVCC) with something osmocom proprietary. Change-Id: I608220e8e5dd5a44f85c6bc5ea04622a2cad24ec --- M tests/gsm0808/gsm0808_test.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/27212/1 diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c index 3fff005..e0f8eb3 100644 --- a/tests/gsm0808/gsm0808_test.c +++ b/tests/gsm0808/gsm0808_test.c @@ -1072,6 +1072,17 @@ msgb_free(msg); } +static void test_gsm0808_dec_cell_id_list_srvcc() +{ + /* taken from a pcap file of a real-world 3rd party MSC (SYS#5838) */ + const uint8_t enc_cil[] = { 0x0b, 0x2, 0xf2, 0x10, 0x4e, 0x20, 0x15, 0xbe}; + struct gsm0808_cell_id_list2 dec_cil; + int rc; + + rc = gsm0808_dec_cell_id_list2(&dec_cil, enc_cil, sizeof(enc_cil)); + OSMO_ASSERT(rc == sizeof(dec_cil)); +} + static void test_gsm0808_enc_dec_cell_id_list_lac() { struct gsm0808_cell_id_list2 enc_cil; @@ -2490,6 +2501,7 @@ test_gsm0808_enc_dec_cell_id_list_multi_ci(); test_gsm0808_enc_dec_cell_id_list_multi_lac_and_ci(); test_gsm0808_enc_dec_cell_id_list_multi_global(); + test_gsm0808_dec_cell_id_list_srvcc(); test_cell_id_list_add(); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I608220e8e5dd5a44f85c6bc5ea04622a2cad24ec Gerrit-Change-Number: 27212 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: stats: New stats for lchan life duration.

by neels

Attention is currently required from: iedemam. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: New stats for lchan life duration. ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: sorry for the weird formatting of my prev comment in gerrit, seems i can't edit the comment to fix it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 8 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 15 Feb 2022 18:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-bsc[master]: stats: New stats for lchan life duration.

by neels

Attention is currently required from: iedemam. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: New stats for lchan life duration. ...................................................................... Patch Set 8: (11 comments) Patchset: PS8: Hi Michael! Good to see a patch from outside of sysmocom. And what a patch it is. Reporting time durations in statistics is a head-spinning mathematically challenging topic. When reviewing the patch I went from "oh, that's simple" and "why didn't I think of this and went for all the effort with osmo_time_cc?" at first, all the way to "wait, no, how does this work again??" and to "oh that's why I wrote osmo_time_cc". This stuff can be really confusing. Let me try to break down what I figured out so far: This current patch has these flaws: - (there should be no averaging, see below, but) The N to average over should be the released-count, not the currently-active-count, because the millis value is added only later upon channel release. In stats, when we report the TCH_ACTIVE_MILLISECONDS_TOTAL and the BTS_CTR_CHAN_ACT_TCH, that gives an inaccurate metric, because N increments a long time before the millis increment. The metric takes a dip upon each channel activation, and un-dips on each channel release. If there were a metric counting releases, the value would be much more accurate, updated only when a channel releases with the correct duration value. - The value written on vty_out reflects an average over the process lifetime, not the current situation. A useful value would gradually "forget" the values of past time periods, literature seems to suggest averaging over an hour or 15 minutes. Instead osmocom offers rate_ctr. See below. - For the ACTIVE_MILLISECONDS_TOTAL, a rate_ctr would be better suited. A stat item is designed for current absolute values that can decrease, like how many lchans are currently active. A rate counter reports increments of a value over-time, like how many releases have occured over time (per second, per minute, etc); this over-time is very desirable. If we report the nr of channel releases as a rate counter as well as the sum of active milliseconds as a rate counter, a stats engine can form an accurate average over any time period it chooses. However, think that a phone call is taking 2 hours to complete, then the trivial implementation would report those 2 hours worth of milliseconds only when the call is hung up. Or extrapolated, if *all* channels are occupied with calls going on for 2 hours, your dashboard will only flag a high Erlang value two hours after your entire network has become congested. With osmo_time_cc, the milliseconds count would gradually increase as the call continues, even before it is hung up, and the metric would also stay accurate the entire time (no dips from chan act). No dips because no averaging: IIUC for an Erlang we would not actually average, but simply add up all lchans. We could put a separate osmo_time_cc for each lchan in place, and report the sum of those per BTS and chan type. Then if we get 10 minutes of increase within one minute, that's 10 Erlangs, or 10 TCH were active concurrently. I think this is what we should go for. From explaining this, I've actually come to appreciate the simple yet powerful nature of the Erlang unit, had not realized this before. In detail, I would: - add a new rate counter per BTS and per chan type; each gradually reports the seconds of activity per second, added up over all lchans of that type. E.g. BTS_ACTIVE_TIME_TCH, _SDCCH,... - we add one time_cc per lchan, and make all of them accumulate to the same BTS-wide rate counter (one per channel type). - in lchan_st_established_onenter() we set the time_cc = true, on established_onleave() to false. Nothing else is required. The patch might actually become simpler this way. (maybe there could also be separate rate counters for each TRX, and also globally over the entire BSC; a bit of implementation detail would be involved there, skipping that for now.) I would advise against using the current patch as-is. It would provide an improved value, but there would still be the flaws I pointed out, and eventually we'd probably need to fix those and have compat issues with existing setups. What do you think? Am I making sense? (I could also imagine taking over, but not sure how soon that would work out; would need to ask about our current priorities). I also wrote a bunch of code review on details of this patch. I'll keep some for sharing, in case you're interested in the style differences that come up. File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/55df34cc_7eee50f1 PS8, Line 1130: unsigned long long gsm_lchan_active_duration_ms(const struct gsm_lchan *lchan); (idea: use uint64_t for a fixed size independent from arch. uint32_t spans 49 days of ms, uint64_t half a billion years) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/9e38af99_1efeb800 PS8, Line 1514: "Cummulative number of active milliseconds on TCH chans", ("Cumulative") doc reads a bit weird, as if the milliseconds are active, also leaves a lot of guessing about the nature of the metric. suggestion: "Average lchan activity duration per TCH lchan activation in milliseconds" File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/d479f6ec_6c688a6f PS8, Line 574: uint duration_s = (gsm_lchan_active_duration_ms(lchan) + 500) / 1000; the +500 acts as a round(), yet the reported descriptions below suggest that floor() should be used instead. IOW please drop the 500. File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/d3a14304_f147c16c PS8, Line 3826: uint64_t activations_tch = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_ACT_TCH)->current; osmocom style dictates that local variables are declared at the start of the function (or scope) File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/6b1bdb85_9746e7b5 PS8, Line 348: /* Get duration of active time for this lchan in milliseconds */ Rather: /* If the lchan is currently active, return the duration since activation in milliseconds. Otherwise return 0. */ https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/73cb38ff_8091843b PS8, Line 352: if (lchan->activate.concluded) { osmocom style asks for early-exit: struct timespec now; if (!lchan->activate.concluded) return 0; osmo_clock_gettime ... return elapsed.tv_sec * ... https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/cdcce2f6_c8642f83 PS8, Line 357: duration = elapsed.tv_sec * 1000LL + elapsed.tv_nsec / 1000000; the LL on the 1000 has no effect, the first operand defines the integer size for calculation. So you want one of these: (uint64_t)elapsed.tv_sec * 1000 + ... or 1000LL * elapsed.tv_sec + ... (i prefer the first) File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/af32bb7e_b5fe7283 PS8, Line 1810: You should rather put this bit in a new lchan_st_established_onleave() function. This is the single place that is absolutely guaranteed to be called whenever the lchan leaves the active state. If you want to also count the time that the lchan release process takes (including any error timeouts that may be), then you'd instead put this in lchan_st_unused_onenter(). In lchan_fsm.c:1628, add a new onleave cb: [LCHAN_ST_ESTABLISHED] = { .onleave = lchan_st_established_onleave, https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/ad4f3c23_f4db6493 PS8, Line 1811: /* Add active milliseconds to cummulative counts per channel type */ /* Report how long this lchan was active, to add to the average activity duration metric. */ https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/e0fc54f9_b83bf4f8 PS8, Line 1817: LOG_LCHAN(lchan, LOGL_INFO, "GSM_LCHAN_TCH was active for %llu milliseconds\n", duration_ms); i would rather just have a single LOG_LCHAN() that uses gsm_chan_t_name() above the switch, because then you don't need to duplicate which names we use for channel types in logging, and you can drop the weird 'default:' case. Also osmo_int_to_float_str() is nice. /* "TCH/H was active for 1.23 seconds" */ LOG_LCHAN("%s was active for %s seconds", gsm_chan_t_name(lchan), osmo_int_to_float_str_c(OTC_SELECT, millis, 3); switch(lchan->type) { osmo_stat_item_inc... break -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 8 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Tue, 15 Feb 2022 18:42:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Rework tests validating wrong ipv6 saddr on IPv4v6 APNs

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27189 ) Change subject: ggsn: Rework tests validating wrong ipv6 saddr on IPv4v6 APNs ...................................................................... ggsn: Rework tests validating wrong ipv6 saddr on IPv4v6 APNs The existing test TC_pdp46_act_deact_gtpu_access_wrong_global_saddr_ipv6 was wrong, because the global address was being finally encoded as a link local address by f_gen_icmpv6_router_solicitation(). Let's rewrite the test and add a new one for source link local addresses simlar to the ones used to test IPv6-only APNs. Change-Id: I3d0790104abea7acb4fa5e33109fe93cc51d94ea --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 26 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Vadim Yanitskiy: Looks good to me, approved Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 4ea7cf4..8f4e709 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -1512,15 +1512,36 @@ f_pdp_ctx_del(ctx, '1'B); } - /* Assert that packets with wrong ipv6 global src addr are dropped by GGSN on APN IPv4v6 */ - testcase TC_pdp46_act_deact_gtpu_access_wrong_global_saddr_ipv6() runs on GT_CT { + /* Check that attempting RA with another ll src addr won't work, packet dropped: */ + testcase TC_pdp46_act_deact_gtpu_access_wrong_ll_saddr_ipv6() runs on GT_CT { f_init(); var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInet46, valueof(t_EuaIPv4Dynv6Dyn))); ctx.pco_req := valueof(ts_PCO_IPv4_DNS_CONT); f_pdp_ctx_act(ctx); - var OCT16 saddr_v6 := f_inet6_addr("fde4:8dba:82e1:2000:1:2:3:4"); - f_send_gtpu(ctx, f_gen_icmpv6_router_solicitation(saddr_v6)); + var OCT16 saddr_ll := f_ipv6_link_local(ctx.eua.endUserAddress.endUserAddressIPv4andIPv6.ipv6_address); + var OCT16 saddr_ll_wrong := f_ipv6_mangle(saddr_ll, 8); + f_send_gtpu(ctx, f_gen_icmpv6_router_solicitation(saddr_ll_wrong)); + f_wait_gtpu_fail(ctx); + + f_pdp_ctx_del(ctx, '1'B); + } + + /* Assert that packets with wrong ipv6 global src addr are dropped by GGSN on APN IPv4v6 */ + testcase TC_pdp46_act_deact_gtpu_access_wrong_global_saddr_ipv6() runs on GT_CT { + f_init(); + var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInet46, valueof(t_EuaIPv4Dynv6Dyn))); + ctx.pco_req := valueof(ts_PCO_IPv6_DNS); + f_pdp_ctx_act(ctx); + + f_send_gtpu(ctx, f_icmpv6_rs_for_pdp(ctx)); + f_wait_rtr_adv(ctx); + f_send_gtpu(ctx, f_gen_icmpv6_neigh_solicit_for_pdp(ctx)); + + var OCT16 dns1_addr := f_PCO_extract_proto(ctx.pco_neg, '0003'O); + var OCT16 saddr_glob := f_ipv6_global(ctx.eua.endUserAddress.endUserAddressIPv4andIPv6.ipv6_address); + var OCT16 saddr_wrong := f_ipv6_mangle(saddr_glob); + f_send_gtpu(ctx, f_gen_icmpv6_echo(saddr_wrong, dns1_addr)); f_wait_gtpu_fail(ctx); f_pdp_ctx_del(ctx, '1'B); @@ -1713,6 +1734,7 @@ execute(TC_pdp46_act_deact_pcodns6()); execute(TC_pdp46_act_deact_gtpu_access()); execute(TC_pdp46_act_deact_gtpu_access_wrong_saddr_ipv4()); + execute(TC_pdp46_act_deact_gtpu_access_wrong_ll_saddr_ipv6()); execute(TC_pdp46_act_deact_gtpu_access_wrong_global_saddr_ipv6()); execute(TC_pdp46_clients_interact()); execute(TC_pdp46_act_deact_apn4()); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d0790104abea7acb4fa5e33109fe93cc51d94ea Gerrit-Change-Number: 27189 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Support IPv4v6 PDP contexts in helper icmpv6 functions

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27195 ) Change subject: ggsn: Support IPv4v6 PDP contexts in helper icmpv6 functions ...................................................................... ggsn: Support IPv4v6 PDP contexts in helper icmpv6 functions Change-Id: I564d51e02ea4b3cb5fedb79dfc1903c04619bd61 --- M ggsn_tests/GGSN_Tests.ttcn 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Vadim Yanitskiy: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index cebd6f2..4ea7cf4 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -750,9 +750,22 @@ return f_IPv6_enc(ip6); } + /* Get link-id from PDP Context EUA */ + function f_ctx_get_ipv6_interface_id(in PdpContext ctx) return OCT16 { + var OCT16 interface_id; + if (ischosen(ctx.eua.endUserAddress.endUserAddressIPv4andIPv6)) { + interface_id := ctx.eua.endUserAddress.endUserAddressIPv4andIPv6.ipv6_address; + } else if (ischosen(ctx.eua.endUserAddress.endUserAddressIPv6)) { + interface_id := ctx.eua.endUserAddress.endUserAddressIPv6.ipv6_address; + } else { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unexpected request to submit icmpv6 rs in IPv4 PDP context"); + } + return interface_id; + } + /* create ICMPv6 router solicitation deriving link-id from PDP Context EUA */ function f_icmpv6_rs_for_pdp(in PdpContext ctx) return octetstring { - var OCT16 interface_id := ctx.eua.endUserAddress.endUserAddressIPv6.ipv6_address; + var OCT16 interface_id := f_ctx_get_ipv6_interface_id(ctx); return f_gen_icmpv6_router_solicitation(interface_id); } @@ -766,7 +779,7 @@ /* generate and encode ICMPv6 neighbor solicitation for PDP Context */ function f_gen_icmpv6_neigh_solicit_for_pdp(in PdpContext ctx) return octetstring { - var OCT16 interface_id := ctx.eua.endUserAddress.endUserAddressIPv6.ipv6_address; + var OCT16 interface_id := f_ctx_get_ipv6_interface_id(ctx); var OCT16 link_local := f_ipv6_link_local(interface_id); var OCT16 daddr := f_ipv6_sol_node_mcast(link_local); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27195 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I564d51e02ea4b3cb5fedb79dfc1903c04619bd61 Gerrit-Change-Number: 27195 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Rework tests validating wrong ipv6 saddr on IPv4v6 APNs

by Vadim Yanitskiy

Attention is currently required from: osmith, pespin. Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27189 ) Change subject: ggsn: Rework tests validating wrong ipv6 saddr on IPv4v6 APNs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27189 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3d0790104abea7acb4fa5e33109fe93cc51d94ea Gerrit-Change-Number: 27189 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 16:54:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in libosmo-netif[master]: amr: cosmetic: fix grammer in comment

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/27210 ) Change subject: amr: cosmetic: fix grammer in comment ...................................................................... amr: cosmetic: fix grammer in comment Change-Id: I01ad26986d925acdcdb3760f89b8a85dccdc3d5b --- M src/amr.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/amr.c b/src/amr.c index 7bc24f5..add4285 100644 --- a/src/amr.c +++ b/src/amr.c @@ -103,8 +103,8 @@ * mode normally relys on out of band methods that explicitly select * one of the two modes. (See also RFC 3267, chapter 3.8). However the * A interface in GSM does not provide ways to communicate which mode - * is used exactly used. The following functions uses some heuristics - * to check if an AMR payload is octet aligned or not. */ + * is exactly used. The following functions uses some heuristics to + * check if an AMR payload is octet aligned or not. */ struct amr_hdr *oa_hdr = (struct amr_hdr *)payload; unsigned int frame_len; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/27210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I01ad26986d925acdcdb3760f89b8a85dccdc3d5b Gerrit-Change-Number: 27210 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in libosmo-netif[master]: amr_test: increase test coverage for oe / bwe conversation

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/27211 ) Change subject: amr_test: increase test coverage for oe / bwe conversation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/27211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I53bd574e1ce7349419553e3957fff19e81567b93 Gerrit-Change-Number: 27211 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 14:58:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in libosmo-netif[master]: amr: cosmetic: fix grammer in comment

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/27210 ) Change subject: amr: cosmetic: fix grammer in comment ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/27210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I01ad26986d925acdcdb3760f89b8a85dccdc3d5b Gerrit-Change-Number: 27210 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 14:58:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: ansible/ttcn3: don't install titan/libfftranscode

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27206 ) Change subject: ansible/ttcn3: don't install titan/libfftranscode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie46fe3dcb286a6258021fad9c35be10442544761 Gerrit-Change-Number: 27206 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 14:57:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: build ttcn3 in docker

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27205 ) Change subject: jobs/gerrit-verifications: build ttcn3 in docker ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a667255bb55a945b4c6279d711142aa252c6996 Gerrit-Change-Number: 27205 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 14:57:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in libosmo-netif[master]: amr_test: increase test coverage for oe / bwe conversation

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/27211 ) Change subject: amr_test: increase test coverage for oe / bwe conversation ...................................................................... amr_test: increase test coverage for oe / bwe conversation The functions that convert between octet-aligned and bandwith-efficient AMR format have good coverage on the octet-aligned side, but the bandwith-efficient side has a very little number of sample packets. Lets add some more sample packets to increase coverage. Related: SYS#5834 Change-Id: I53bd574e1ce7349419553e3957fff19e81567b93 --- M tests/amr/amr_test.c M tests/amr/amr_test.ok 2 files changed, 131 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/11/27211/1 diff --git a/tests/amr/amr_test.c b/tests/amr/amr_test.c index 3d0d917..69ba723 100644 --- a/tests/amr/amr_test.c +++ b/tests/amr/amr_test.c @@ -29,6 +29,7 @@ "703c22f979890338540179209572624a0f8535871c2f7039cbf926b7e4425b6ef0", "703c2e671f3b1b0810412d5adae61e2b2a319885c6ced4e909b4eeaa2ea0f0cd80", "703cf8fc77356c948141686cda34d35220db719e36a359d86b64420dc64b563850", + "703c3eec9c37dfb201c093c57a1235a02af55ccc22f1c9593a6e058c368b4d7f50", "60344e300c0e6251342c2ae51fd8a698a945488d16c98922726f3e50", "60341fc722c7880328a9c280030bc9755c3ef519f80000295323e000", "60342c338655c00008efba03592419adf62478a79278b3e2d68ab0f0", @@ -47,7 +48,7 @@ "0004f89d67f1160935bde1996840", "0004633cc7f0630439ffe0000000", "0004eb81fc0758973b9edc782550", - "a078ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00fc", /* sample with invalid FT */ + "a078ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00fc", /* sample with invalid FT, will be detected as bandwith-efficient */ "END", }; @@ -55,10 +56,20 @@ char *bwe_amr_samples[] = { "f4495c7cda8f80", "f44aaa6c969780", + "7449c1e32c6780", + "74400000000380", + "703c493323b0bf68028086d15a00", + "703c59171697c53c01801fb6aa80", + "703c55029bb2e23a0020172e8b00", + "703c48f52442f08884a8050b8500", + "7038000000000000000000000000", + "7151434e01292c40c4735e4412204077", + "714eadbe13ac4694f4726f71985d64cd", "f3d09c20e32da600c025a72e0a9b360386e40f87e19282094adc1a11e397d1d4", "f3d39a49a09e7a802852e297e8c9246aadf5a45928bfc27177fed8404d97d3b8", "f3c2155b65131c68682079fab4810911200003b360ae0446000025f11e539dd0", "f3c381bc7061c9f8507f6029de6115c16e5fa470c243b21b6e35dbb48bd84c00", + "73c901b7a2004be7f85284b6ab7142acfe6872b1ae1c107d0588b551de7be650", "a7bfc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03f", /* sample with invalid FT */ "END", }; diff --git a/tests/amr/amr_test.ok b/tests/amr/amr_test.ok index c9cde1f..02e36d9 100644 --- a/tests/amr/amr_test.ok +++ b/tests/amr/amr_test.ok @@ -24,132 +24,139 @@ rc: 32 Sample No.: 3 + octet aligned: 703c3eec9c37dfb201c093c57a1235a02af55ccc22f1c9593a6e058c368b4d7f50 + 011100000011110000111110111011001001110000110111110111111011001000000001110000001001001111000101011110100001001000110101101000000010101011110101010111001100110000100010111100011100100101011001001110100110111000000101100011000011011010001011010011010111111101010000 + bw-efficient: 73cfbb270df7ec807024f15e848d680abd573308bc72564e9b81630da2d35fd4 + 0111001111001111101110110010011100001101111101111110110010000000011100000010010011110001010111101000010010001101011010000000101010111101010101110011001100001000101111000111001001010110010011101001101110000001011000110000110110100010110100110101111111010100 + rc: 32 + +Sample No.: 4 octet aligned: 60344e300c0e6251342c2ae51fd8a698a945488d16c98922726f3e50 01100000001101000100111000110000000011000000111001100010010100010011010000101100001010101110010100011111110110001010011010011000101010010100010101001000100011010001011011001001100010010010001001110010011011110011111001010000 bw-efficient: 63538c030398944d0b0ab947f629a62a51522345b262489c9bcf94 011000110101001110001100000000110000001110011000100101000100110100001011000010101011100101000111111101100010100110100110001010100101000101010010001000110100010110110010011000100100100010011100100110111100111110010100 rc: 27 -Sample No.: 4 +Sample No.: 5 octet aligned: 60341fc722c7880328a9c280030bc9755c3ef519f80000295323e000 01100000001101000001111111000111001000101100011110001000000000110010100010101001110000101000000000000011000010111100100101110101010111000011111011110101000110011111100000000000000000000010100101010011001000111110000000000000 bw-efficient: 6347f1c8b1e200ca2a70a000c2f25d570fbd467e00000a54c8f800 011000110100011111110001110010001011000111100010000000001100101000101010011100001010000000000000110000101111001001011101010101110000111110111101010001100111111000000000000000000000101001010100110010001111100000000000 rc: 27 -Sample No.: 5 +Sample No.: 6 octet aligned: 60342c338655c00008efba03592419adf62478a79278b3e2d68ab0f0 01100000001101000010110000110011100001100101010111000000000000000000100011101111101110100000001101011001001001000001100110101101111101100010010001111000101001111001001001111000101100111110001011010110100010101011000011110000 bw-efficient: 634b0ce1957000023bee80d649066b7d891e29e49e2cf8b5a2ac3c 011000110100101100001100111000011001010101110000000000000000001000111011111011101000000011010110010010010000011001101011011111011000100100011110001010011110010010011110001011001111100010110101101000101010110000111100 rc: 27 -Sample No.: 6 +Sample No.: 7 octet aligned: 502c98ab841e491ff7a1a555016a32a3c7f913210630 01010000001011001001100010101011100001000001111001001001000111111111011110100001101001010101010100000001011010100011001010100011110001111111100100010011001000010000011000110000 bw-efficient: 52e62ae1079247fde86955405a8ca8f1fe44c8418c00 01010010111001100010101011100001000001111001001001000111111111011110100001101001010101010100000001011010100011001010100011110001111111100100010011001000010000011000110000000000 rc: 22 -Sample No.: 7 +Sample No.: 8 octet aligned: 502cc5459a0d200e7097c4dfe86ec8d27f1756d776f0 01010000001011001100010101000101100110100000110100100000000011100111000010010111110001001101111111101000011011101100100011010010011111110001011101010110110101110111011011110000 bw-efficient: 52f151668348039c25f137fa1bb2349fc5d5b5ddbc00 01010010111100010101000101100110100000110100100000000011100111000010010111110001001101111111101000011011101100100011010010011111110001011101010110110101110111011011110000000000 rc: 22 -Sample No.: 8 +Sample No.: 9 octet aligned: 502c42b332081813d7e916e7aa5e80d7fde812b8c080 01010000001011000100001010110011001100100000100000011000000100111101011111101001000101101110011110101010010111101000000011010111111111011110100000010010101110001100000010000000 bw-efficient: 52d0accc820604f5fa45b9ea97a035ff7a04ae302000 01010010110100001010110011001100100000100000011000000100111101011111101001000101101110011110101010010111101000000011010111111111011110100000010010101110001100000010000000000000 rc: 22 -Sample No.: 9 +Sample No.: 10 octet aligned: 40240343e959c79bacd20c77501054880a718db200 010000000010010000000011010000111110100101011001110001111001101110101100110100100000110001110111010100000001000001010100100010000000101001110001100011011011001000000000 bw-efficient: 4240d0fa5671e6eb34831dd4041522029c636c80 0100001001000000110100001111101001010110011100011110011011101011001101001000001100011101110101000000010000010101001000100000001010011100011000110110110010000000 rc: 20 -Sample No.: 10 +Sample No.: 11 octet aligned: 4024172c53401e39115ceecd12606df5689bdd0ca0 010000000010010000010111001011000101001101000000000111100011100100010001010111001110111011001101000100100110000001101101111101010110100010011011110111010000110010100000 bw-efficient: 4245cb14d0078e44573bb344981b7d5a26f74328 0100001001000101110010110001010011010000000001111000111001000100010101110011101110110011010001001001100000011011011111010101101000100110111101110100001100101000 rc: 20 -Sample No.: 11 +Sample No.: 12 octet aligned: 4024f871cf48801ec427f0fc3f7318898622062200 010000000010010011111000011100011100111101001000100000000001111011000100001001111111000011111100001111110111001100011000100010011000011000100010000001100010001000000000 bw-efficient: 427e1c73d22007b109fc3f0fdcc6226188818880 0100001001111110000111000111001111010010001000000000011110110001000010011111110000111111000011111101110011000110001000100110000110001000100000011000100010000000 rc: 20 -Sample No.: 12 +Sample No.: 13 octet aligned: 20141fd4c02667c742b164aef659ffe708 0010000000010100000111111101010011000000001001100110011111000111010000101011000101100100101011101111011001011001111111111110011100001000 bw-efficient: 2147f5300999f1d0ac592bbd967ff9c2 00100001010001111111010100110000000010011001100111110001110100001010110001011001001010111011110110010110011111111111100111000010 rc: 16 -Sample No.: 13 +Sample No.: 14 octet aligned: 2014197e10ead7b250bccbbf3b81887c64 0010000000010100000110010111111000010000111010101101011110110010010100001011110011001011101111110011101110000001100010000111110001100100 bw-efficient: 21465f843ab5ec942f32efcee0621f19 00100001010001100101111110000100001110101011010111101100100101000010111100110010111011111100111011100000011000100001111100011001 rc: 16 -Sample No.: 14 +Sample No.: 15 octet aligned: 2014e959f35fdfe5e9667ffbc088818088 0010000000010100111010010101100111110011010111111101111111100101111010010110011001111111111110111100000010001000100000011000000010001000 bw-efficient: 217a567cd7f7f97a599ffef022206022 00100001011110100101011001111100110101111111011111111001011110100101100110011111111111101111000000100010001000000110000000100010 rc: 16 -Sample No.: 15 +Sample No.: 16 octet aligned: 100c4e9ba850e30d5d53d04de41e7c 000100000000110001001110100110111010100001010000111000110000110101011101010100111101000001001101111001000001111001111100 bw-efficient: 10d3a6ea1438c35754f41379079f00 000100001101001110100110111010100001010000111000110000110101011101010100111101000001001101111001000001111001111100000000 rc: 15 -Sample No.: 16 +Sample No.: 17 octet aligned: 100c6c18e7b7fff53aeb055e7d1c54 000100000000110001101100000110001110011110110111111111111111010100111010111010110000010101011110011111010001110001010100 bw-efficient: 10db0639edfffd4ebac1579f471500 000100001101101100000110001110011110110111111111111111010100111010111010110000010101011110011111010001110001010100000000 rc: 15 -Sample No.: 17 +Sample No.: 18 octet aligned: 100c1fb967f7f1fdf547bf2e61c060 000100000000110000011111101110010110011111110111111100011111110111110101010001111011111100101110011000011100000001100000 bw-efficient: 10c7ee59fdfc7f7d51efcb98701800 000100001100011111101110010110011111110111111100011111110111110101010001111011111100101110011000011100000001100000000000 rc: 15 -Sample No.: 18 +Sample No.: 19 octet aligned: 0004f89d67f1160935bde1996840 0000000000000100111110001001110101100111111100010001011000001001001101011011110111100001100110010110100001000000 bw-efficient: 007e2759fc45824d6f78665a1000 0000000001111110001001110101100111111100010001011000001001001101011011110111100001100110010110100001000000000000 rc: 14 -Sample No.: 19 +Sample No.: 20 octet aligned: 0004633cc7f0630439ffe0000000 0000000000000100011000110011110011000111111100000110001100000100001110011111111111100000000000000000000000000000 bw-efficient: 0058cf31fc18c10e7ff800000000 0000000001011000110011110011000111111100000110001100000100001110011111111111100000000000000000000000000000000000 rc: 14 -Sample No.: 20 +Sample No.: 21 octet aligned: 0004eb81fc0758973b9edc782550 0000000000000100111010111000000111111100000001110101100010010111001110111001111011011100011110000010010101010000 bw-efficient: 007ae07f01d625cee7b71e095400 0000000001111010111000000111111100000001110101100010010111001110111001111011011100011110000010010101010000000000 rc: 14 -Sample No.: 21 +Sample No.: 22 octet aligned: a078ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00ff00fc 101000000111100011111111000000001111111100000000111111110000000011111111000000001111111100000000111111110000000011111111000000001111111100000000111111110000000011111111000000001111111100000000111111110000000011111111000000001111111100000000111111110000000011111100 bw-efficient: @@ -174,34 +181,104 @@ rc: 7 Sample No.: 2 + bw-efficient: 7449c1e32c6780 + 01110100010010011100000111100011001011000110011110000000 + octet aligned: 704427078cb19c + 01110000010001000010011100000111100011001011000110011100 + rc: 7 + +Sample No.: 3 + bw-efficient: 74400000000380 + 01110100010000000000000000000000000000000000001110000000 + octet aligned: 7044000000000c + 01110000010001000000000000000000000000000000000000001100 + rc: 7 + +Sample No.: 4 + bw-efficient: 703c493323b0bf68028086d15a00 + 0111000000111100010010010011001100100011101100001011111101101000000000101000000010000110110100010101101000000000 + octet aligned: 7000f124cc8ec2fda00a021b4568 + 0111000000000000111100010010010011001100100011101100001011111101101000000000101000000010000110110100010101101000 + rc: 14 + +Sample No.: 5 + bw-efficient: 703c59171697c53c01801fb6aa80 + 0111000000111100010110010001011100010110100101111100010100111100000000011000000000011111101101101010101010000000 + octet aligned: 7000f1645c5a5f14f006007edaa8 + 0111000000000000111100010110010001011100010110100101111100010100111100000000011000000000011111101101101010101000 + rc: 14 + +Sample No.: 6 + bw-efficient: 703c55029bb2e23a0020172e8b00 + 0111000000111100010101010000001010011011101100101110001000111010000000000010000000010111001011101000101100000000 + octet aligned: 7000f1540a6ecb88e800805cba2c + 0111000000000000111100010101010000001010011011101100101110001000111010000000000010000000010111001011101000101100 + rc: 14 + +Sample No.: 7 + bw-efficient: 703c48f52442f08884a8050b8500 + 0111000000111100010010001111010100100100010000101111000010001000100001001010100000000101000010111000010100000000 + octet aligned: 7000f123d4910bc22212a0142e14 + 0111000000000000111100010010001111010100100100010000101111000010001000100001001010100000000101000010111000010100 + rc: 14 + +Sample No.: 8 + bw-efficient: 7038000000000000000000000000 + 0111000000111000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 + octet aligned: 7000e00000000000000000000000 + 0111000000000000111000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 + rc: 14 + +Sample No.: 9 + bw-efficient: 7151434e01292c40c4735e4412204077 + 01110001010100010100001101001110000000010010100100101100010000001100010001110011010111100100010000010010001000000100000001110111 + octet aligned: 7014450d3804a4b10311cd7910488101dc + 0111000000010100010001010000110100111000000001001010010010110001000000110001000111001101011110010001000001001000100000010000000111011100 + rc: 17 + +Sample No.: 10 + bw-efficient: 714eadbe13ac4694f4726f71985d64cd + 01110001010011101010110110111110000100111010110001000110100101001111010001110010011011110111000110011000010111010110010011001101 + octet aligned: 70143ab6f84eb11a53d1c9bdc661759334 + 0111000000010100001110101011011011111000010011101011000100011010010100111101000111001001101111011100011001100001011101011001001100110100 + rc: 17 + +Sample No.: 11 bw-efficient: f3d09c20e32da600c025a72e0a9b360386e40f87e19282094adc1a11e397d1d4 1111001111010000100111000010000011100011001011011010011000000000110000000010010110100111001011100000101010011011001101100000001110000110111001000000111110000111111000011001001010000010000010010100101011011100000110100001000111100011100101111101000111010100 octet aligned: f03c4270838cb6980300969cb82a6cd80e1b903e1f864a08252b7068478e5f4750 111100000011110001000010011100001000001110001100101101101001100000000011000000001001011010011100101110000010101001101100110110000000111000011011100100000011111000011111100001100100101000001000001001010010101101110000011010000100011110001110010111110100011101010000 rc: 33 -Sample No.: 3 +Sample No.: 12 bw-efficient: f3d39a49a09e7a802852e297e8c9246aadf5a45928bfc27177fed8404d97d3b8 1111001111010011100110100100100110100000100111100111101010000000001010000101001011100010100101111110100011001001001001000110101010101101111101011010010001011001001010001011111111000010011100010111011111111110110110000100000001001101100101111101001110111000 octet aligned: f03c4e69268279ea00a14b8a5fa32491aab7d69164a2ff09c5dffb6101365f4ee0 111100000011110001001110011010010010011010000010011110011110101000000000101000010100101110001010010111111010001100100100100100011010101010110111110101101001000101100100101000101111111100001001110001011101111111111011011000010000000100110110010111110100111011100000 rc: 33 -Sample No.: 4 +Sample No.: 13 bw-efficient: f3c2155b65131c68682079fab4810911200003b360ae0446000025f11e539dd0 1111001111000010000101010101101101100101000100110001110001101000011010000010000001111001111110101011010010000001000010010001000100100000000000000000001110110011011000001010111000000100010001100000000000000000001001011111000100011110010100111001110111010000 octet aligned: f03c08556d944c71a1a081e7ead204244480000ecd82b81118000097c4794e7740 111100000011110000001000010101010110110110010100010011000111000110100001101000001000000111100111111010101101001000000100001001000100010010000000000000000000111011001101100000101011100000010001000110000000000000000000100101111100010001111001010011100111011101000000 rc: 33 -Sample No.: 5 +Sample No.: 14 bw-efficient: f3c381bc7061c9f8507f6029de6115c16e5fa470c243b21b6e35dbb48bd84c00 1111001111000011100000011011110001110000011000011100100111111000010100000111111101100000001010011101111001100001000101011100000101101110010111111010010001110000110000100100001110110010000110110110111000110101110110111011010010001011110110000100110000000000 octet aligned: f03c0e06f1c18727e141fd80a779845705b97e91c3090ec86db8d76ed22f613000 111100000011110000001110000001101111000111000001100001110010011111100001010000011111110110000000101001110111100110000100010101110000010110111001011111101001000111000011000010010000111011001000011011011011100011010111011011101101001000101111011000010011000000000000 rc: 33 -Sample No.: 6 +Sample No.: 15 + bw-efficient: 73c901b7a2004be7f85284b6ab7142acfe6872b1ae1c107d0588b551de7be650 + 0111001111001001000000011011011110100010000000000100101111100111111110000101001010000100101101101010101101110001010000101010110011111110011010000111001010110001101011100001110000010000011111010000010110001000101101010101000111011110011110111110011001010000 + octet aligned: 703c2406de88012f9fe14a12daadc50ab3f9a1cac6b87041f41622d54779ef9940 + 011100000011110000100100000001101101111010001000000000010010111110011111111000010100101000010010110110101010110111000101000010101011001111111001101000011100101011000110101110000111000001000001111101000001011000100010110101010100011101111001111011111001100101000000 + rc: 33 + +Sample No.: 16 bw-efficient: a7bfc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03fc03f 1010011110111111110000000011111111000000001111111100000000111111110000000011111111000000001111111100000000111111110000000011111111000000001111111100000000111111110000000011111111000000001111111100000000111111110000000011111111000000001111111100000000111111 octet aligned: @@ -213,25 +290,26 @@ Sample No.: 0... AMR mode: 7, OA: 33 bytes, BE: 32 bytes, OA: 33 bytes Sample No.: 1... AMR mode: 7, OA: 33 bytes, BE: 32 bytes, OA: 33 bytes Sample No.: 2... AMR mode: 7, OA: 33 bytes, BE: 32 bytes, OA: 33 bytes -Sample No.: 3... AMR mode: 6, OA: 28 bytes, BE: 27 bytes, OA: 28 bytes +Sample No.: 3... AMR mode: 7, OA: 33 bytes, BE: 32 bytes, OA: 33 bytes Sample No.: 4... AMR mode: 6, OA: 28 bytes, BE: 27 bytes, OA: 28 bytes Sample No.: 5... AMR mode: 6, OA: 28 bytes, BE: 27 bytes, OA: 28 bytes -Sample No.: 6... AMR mode: 5, OA: 22 bytes, BE: 22 bytes, OA: 22 bytes +Sample No.: 6... AMR mode: 6, OA: 28 bytes, BE: 27 bytes, OA: 28 bytes Sample No.: 7... AMR mode: 5, OA: 22 bytes, BE: 22 bytes, OA: 22 bytes Sample No.: 8... AMR mode: 5, OA: 22 bytes, BE: 22 bytes, OA: 22 bytes -Sample No.: 9... AMR mode: 4, OA: 21 bytes, BE: 20 bytes, OA: 21 bytes +Sample No.: 9... AMR mode: 5, OA: 22 bytes, BE: 22 bytes, OA: 22 bytes Sample No.: 10... AMR mode: 4, OA: 21 bytes, BE: 20 bytes, OA: 21 bytes Sample No.: 11... AMR mode: 4, OA: 21 bytes, BE: 20 bytes, OA: 21 bytes -Sample No.: 12... AMR mode: 2, OA: 17 bytes, BE: 16 bytes, OA: 17 bytes +Sample No.: 12... AMR mode: 4, OA: 21 bytes, BE: 20 bytes, OA: 21 bytes Sample No.: 13... AMR mode: 2, OA: 17 bytes, BE: 16 bytes, OA: 17 bytes Sample No.: 14... AMR mode: 2, OA: 17 bytes, BE: 16 bytes, OA: 17 bytes -Sample No.: 15... AMR mode: 1, OA: 15 bytes, BE: 15 bytes, OA: 15 bytes +Sample No.: 15... AMR mode: 2, OA: 17 bytes, BE: 16 bytes, OA: 17 bytes Sample No.: 16... AMR mode: 1, OA: 15 bytes, BE: 15 bytes, OA: 15 bytes Sample No.: 17... AMR mode: 1, OA: 15 bytes, BE: 15 bytes, OA: 15 bytes -Sample No.: 18... AMR mode: 0, OA: 14 bytes, BE: 14 bytes, OA: 14 bytes +Sample No.: 18... AMR mode: 1, OA: 15 bytes, BE: 15 bytes, OA: 15 bytes Sample No.: 19... AMR mode: 0, OA: 14 bytes, BE: 14 bytes, OA: 14 bytes Sample No.: 20... AMR mode: 0, OA: 14 bytes, BE: 14 bytes, OA: 14 bytes -Sample No.: 21... skipping a sample with a wrong FT +Sample No.: 21... AMR mode: 0, OA: 14 bytes, BE: 14 bytes, OA: 14 bytes +Sample No.: 22... skipping a sample with a wrong FT Testing conversion from IuUP to bw-efficient and inverse: @@ -262,7 +340,8 @@ Sample No.: 18 ==>octet aligned Sample No.: 19 ==>octet aligned Sample No.: 20 ==>octet aligned -Sample No.: 21 ==>bandwith efficient +Sample No.: 21 ==>octet aligned +Sample No.: 22 ==>bandwith efficient Sample No.: 0 ==>bandwith efficient Sample No.: 1 ==>bandwith efficient Sample No.: 2 ==>bandwith efficient @@ -270,4 +349,14 @@ Sample No.: 4 ==>bandwith efficient Sample No.: 5 ==>bandwith efficient Sample No.: 6 ==>bandwith efficient +Sample No.: 7 ==>bandwith efficient +Sample No.: 8 ==>bandwith efficient +Sample No.: 9 ==>bandwith efficient +Sample No.: 10 ==>bandwith efficient +Sample No.: 11 ==>bandwith efficient +Sample No.: 12 ==>bandwith efficient +Sample No.: 13 ==>bandwith efficient +Sample No.: 14 ==>bandwith efficient +Sample No.: 15 ==>bandwith efficient +Sample No.: 16 ==>bandwith efficient OK: Test passed -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/27211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I53bd574e1ce7349419553e3957fff19e81567b93 Gerrit-Change-Number: 27211 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in libosmo-netif[master]: amr: cosmetic: fix grammer in comment

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/27210 ) Change subject: amr: cosmetic: fix grammer in comment ...................................................................... amr: cosmetic: fix grammer in comment Change-Id: I01ad26986d925acdcdb3760f89b8a85dccdc3d5b --- M src/amr.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/10/27210/1 diff --git a/src/amr.c b/src/amr.c index 7bc24f5..add4285 100644 --- a/src/amr.c +++ b/src/amr.c @@ -103,8 +103,8 @@ * mode normally relys on out of band methods that explicitly select * one of the two modes. (See also RFC 3267, chapter 3.8). However the * A interface in GSM does not provide ways to communicate which mode - * is used exactly used. The following functions uses some heuristics - * to check if an AMR payload is octet aligned or not. */ + * is exactly used. The following functions uses some heuristics to + * check if an AMR payload is octet aligned or not. */ struct amr_hdr *oa_hdr = (struct amr_hdr *)payload; unsigned int frame_len; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/27210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I01ad26986d925acdcdb3760f89b8a85dccdc3d5b Gerrit-Change-Number: 27210 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in pysim[master]: pySim-shell: export: Add FCP template to export

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27209 ) Change subject: pySim-shell: export: Add FCP template to export ...................................................................... pySim-shell: export: Add FCP template to export The FCP template provides us a lot of context, like the permissions of a given file. Let's make it part of the 'export' output, both in raw and in decoded form. Change-Id: I05f17bbebd7a9b3535204b821900851a5f66e88f Closes: OS#5457 --- M pySim-shell.py M pySim/filesystem.py 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/09/27209/1 diff --git a/pySim-shell.py b/pySim-shell.py index 12f35fd..ad76ba0 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -532,6 +532,8 @@ structure = self._cmd.rs.selected_file_structure() self._cmd.poutput("# structure: %s" % str(structure)) + self._cmd.poutput("# RAW FCP Template: %s" % str(self._cmd.rs.selected_file_fcp_hex)) + self._cmd.poutput("# Decoded FCP Template: %s" % str(self._cmd.rs.selected_file_fcp)) for f in df_path_list: self._cmd.poutput("select " + str(f)) diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 8303a4b..f8b86c5 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1221,6 +1221,8 @@ self.card = card self.selected_file = self.mf # type: CardDF self.profile = profile + self.selected_file_fcp = None + self.selected_file_fcp_hex = None # make sure the class and selection control bytes, which are specified # by the card profile are used @@ -1464,7 +1466,8 @@ select_resp = f.decode_select_response(data) else: select_resp = self.probe_file(name, cmd_app) - # store the decoded FCP for later reference + # store the raw + decoded FCP for later reference + self.selected_file_fcp_hex = data self.selected_file_fcp = select_resp self._select_post(cmd_app) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I05f17bbebd7a9b3535204b821900851a5f66e88f Gerrit-Change-Number: 27209 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in pysim[master]: docs/legcay.txt: Point to pySim-shell as replacement

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27208 ) Change subject: docs/legcay.txt: Point to pySim-shell as replacement ...................................................................... docs/legcay.txt: Point to pySim-shell as replacement Change-Id: I9ca6b9d8c35e23be2ec8752107bb7d1e4f6f9bc1 --- M docs/legacy.rst 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/08/27208/1 diff --git a/docs/legacy.rst b/docs/legacy.rst index ec3ddfc..d93358f 100644 --- a/docs/legacy.rst +++ b/docs/legacy.rst @@ -4,6 +4,9 @@ *legacy tools* are the classic ``pySim-prog`` and ``pySim-read`` programs that existed long before ``pySim-shell``. +These days, you should primarily use ``pySim-shell`` instead of these +legacy tools. + pySim-prog ---------- @@ -45,6 +48,11 @@ ``pySim-read`` allows you to read some data from a SIM card. It will only some files of the card, and will only read files accessible to a normal user (without any special authentication) +These days, you should use the ``export`` command of ``pySim-shell`` +instead. It performs a much more comprehensive export of all of the +[standard] files that can be found on the card. To get a human-readable +decode instead of the raw hex export, you can use ``export --json``. + Specifically, pySim-read will dump the following: * MF -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ca6b9d8c35e23be2ec8752107bb7d1e4f6f9bc1 Gerrit-Change-Number: 27208 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in pysim[master]: README.md: Remove old usage examples, refer to user manual instead

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27207 ) Change subject: README.md: Remove old usage examples, refer to user manual instead ...................................................................... README.md: Remove old usage examples, refer to user manual instead We want people to use pySim-shell and should not mislead them by having usage examples of old tools in README.md. Also, all documentation should be in the manuals, let's try to have bits and pieces in various places. Change-Id: I8c07a2e0778ab95fb42be6074acb80874e681d20 --- M README.md 1 file changed, 20 insertions(+), 36 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/README.md b/README.md index 7f46085..5e1937e 100644 --- a/README.md +++ b/README.md @@ -93,46 +93,30 @@ <https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit> -Usage Examples --------------- +Documentation +------------- - * Program customizable SIMs. Two modes are possible: +The pySim user manual can be built from this very source code by means +of sphinx (with sphinxcontrib-napoleon and sphinx-argparse). See the +Makefile in the 'docs' directory. - - one where you specify every parameter manually: -``` -./pySim-prog.py -n 26C3 -c 49 -x 262 -y 42 -i <IMSI> -s <ICCID> -``` +A pre-rendered HTML user manual of the current pySim 'git master' is +available from <https://downloads.osmocom.org/docs/latest/pysim/> and +a downloadable PDF version is published at +<https://downloads.osmocom.org/docs/latest/osmopysim-usermanual.pdf>. - - one where they are generated from some minimal set: -``` -./pySim-prog.py -n 26C3 -c 49 -x 262 -y 42 -z <random_string_of_choice> -j <card_num> -``` +A slightly dated video presentation about pySim-shell can be found at +<https://media.ccc.de/v/osmodevcall-20210409-laforge-pysim-shell>. -With ``<random_string_of_choice>`` and ``<card_num>``, the soft will generate -'predictable' IMSI and ICCID, so make sure you choose them so as not to -conflict with anyone. (for e.g. your name as ``<random_string_of_choice>`` and -0 1 2 ... for ``<card num>``). -You also need to enter some parameters to select the device: +pySim-shell vs. legacy tools +---------------------------- - -t TYPE : type of card (``supersim``, ``magicsim``, ``fakemagicsim`` or try ``auto``) - -d DEV : Serial port device (default ``/dev/ttyUSB0``) - -b BAUD : Baudrate (default 9600) +While you will find a lot of online resources still describing the use of +pySim-prog.py and pySim-read.py, those tools are considered legacy by +now and have by far been superseded by the much more capable +pySim-shell. We strongly encourage users to adopt pySim-shell, unless +they have very specific requirements like batch programming of large +quantities of cards, which is about the only remaining use case for the +legacy tools. - * Interact with SIMs from a python interactive shell (e.g. ipython): - -``` -from pySim.transport.serial import SerialSimLink -from pySim.commands import SimCardCommands - -sl = SerialSimLink(device='/dev/ttyUSB0', baudrate=9600) -sc = SimCardCommands(sl) - -sl.wait_for_card() - - # Print IMSI -print(sc.read_binary(['3f00', '7f20', '6f07'])) - - # Run A3/A8 -print(sc.run_gsm('00112233445566778899aabbccddeeff')) -``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c07a2e0778ab95fb42be6074acb80874e681d20 Gerrit-Change-Number: 27207 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in pysim[master]: README.md: Remove old usage examples, refer to user manual instead

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27207 ) Change subject: README.md: Remove old usage examples, refer to user manual instead ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c07a2e0778ab95fb42be6074acb80874e681d20 Gerrit-Change-Number: 27207 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Feb 2022 14:46:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in pysim[master]: README.md: Remove old usage examples, refer to user manual instead

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27207 ) Change subject: README.md: Remove old usage examples, refer to user manual instead ...................................................................... README.md: Remove old usage examples, refer to user manual instead We want people to use pySim-shell and should not mislead them by having usage examples of old tools in README.md. Also, all documentation should be in the manuals, let's try to have bits and pieces in various places. Change-Id: I8c07a2e0778ab95fb42be6074acb80874e681d20 --- M README.md 1 file changed, 20 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/07/27207/1 diff --git a/README.md b/README.md index 7f46085..5e1937e 100644 --- a/README.md +++ b/README.md @@ -93,46 +93,30 @@ <https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit> -Usage Examples --------------- +Documentation +------------- - * Program customizable SIMs. Two modes are possible: +The pySim user manual can be built from this very source code by means +of sphinx (with sphinxcontrib-napoleon and sphinx-argparse). See the +Makefile in the 'docs' directory. - - one where you specify every parameter manually: -``` -./pySim-prog.py -n 26C3 -c 49 -x 262 -y 42 -i <IMSI> -s <ICCID> -``` +A pre-rendered HTML user manual of the current pySim 'git master' is +available from <https://downloads.osmocom.org/docs/latest/pysim/> and +a downloadable PDF version is published at +<https://downloads.osmocom.org/docs/latest/osmopysim-usermanual.pdf>. - - one where they are generated from some minimal set: -``` -./pySim-prog.py -n 26C3 -c 49 -x 262 -y 42 -z <random_string_of_choice> -j <card_num> -``` +A slightly dated video presentation about pySim-shell can be found at +<https://media.ccc.de/v/osmodevcall-20210409-laforge-pysim-shell>. -With ``<random_string_of_choice>`` and ``<card_num>``, the soft will generate -'predictable' IMSI and ICCID, so make sure you choose them so as not to -conflict with anyone. (for e.g. your name as ``<random_string_of_choice>`` and -0 1 2 ... for ``<card num>``). -You also need to enter some parameters to select the device: +pySim-shell vs. legacy tools +---------------------------- - -t TYPE : type of card (``supersim``, ``magicsim``, ``fakemagicsim`` or try ``auto``) - -d DEV : Serial port device (default ``/dev/ttyUSB0``) - -b BAUD : Baudrate (default 9600) +While you will find a lot of online resources still describing the use of +pySim-prog.py and pySim-read.py, those tools are considered legacy by +now and have by far been superseded by the much more capable +pySim-shell. We strongly encourage users to adopt pySim-shell, unless +they have very specific requirements like batch programming of large +quantities of cards, which is about the only remaining use case for the +legacy tools. - * Interact with SIMs from a python interactive shell (e.g. ipython): - -``` -from pySim.transport.serial import SerialSimLink -from pySim.commands import SimCardCommands - -sl = SerialSimLink(device='/dev/ttyUSB0', baudrate=9600) -sc = SimCardCommands(sl) - -sl.wait_for_card() - - # Print IMSI -print(sc.read_binary(['3f00', '7f20', '6f07'])) - - # Run A3/A8 -print(sc.run_gsm('00112233445566778899aabbccddeeff')) -``` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27207 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8c07a2e0778ab95fb42be6074acb80874e681d20 Gerrit-Change-Number: 27207 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: ansible/ttcn3: don't install titan/libfftranscode

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27206 ) Change subject: ansible/ttcn3: don't install titan/libfftranscode ...................................................................... ansible/ttcn3: don't install titan/libfftranscode With the last patch, the jenkins infrastructure will always run eclipse-titan in docker. Therefore do not install eclipse-titan and libfftranscode on jenkins nodes anymore. This avoids the problem that we couldn't upgrade libfftranscode with the existing ansible rules. libosmocore-utils is still being installed, as osmo-config-merge must be installed on the jenkins nodes. Closes: OS#5452 Change-Id: Ie46fe3dcb286a6258021fad9c35be10442544761 --- M ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml 1 file changed, 1 insertion(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/06/27206/1 diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml index 5e15254..fc4fcc3 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/ttcn3-slave.yml @@ -24,22 +24,9 @@ filename: obs_osmocom update_cache: yes -- name: install titan and libosmocore-utils +- name: install libosmocore-utils apt: name: - - eclipse-titan - libosmocore-utils update_cache: yes cache_valid_time: 3600 - -- name: Get DEB architecture - shell: dpkg --print-architecture - register: deb_architecture - -- name: Install libfftranscode0 - apt: - deb: https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode0_0.3_{{deb_a… - -- name: Install libfftranscode-dev - apt: - deb: https://ftp.osmocom.org/binaries/libfftranscode/libfftranscode-dev_0.3_{{de… -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie46fe3dcb286a6258021fad9c35be10442544761 Gerrit-Change-Number: 27206 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-verifications: build ttcn3 in docker

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27205 ) Change subject: jobs/gerrit-verifications: build ttcn3 in docker ...................................................................... jobs/gerrit-verifications: build ttcn3 in docker Build the testsuites in the same docker container during gerrit verification, as it will be the case when building and running the testsuites in the various ttcn3-* jenkins jobs. This avoids the need to install eclipse-titan and libfftranscode on the jenkins nodes. Related: OS#5452 Change-Id: I6a667255bb55a945b4c6279d711142aa252c6996 --- M jobs/gerrit-verifications.yml 1 file changed, 12 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/05/27205/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 84fe805..9481047 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -261,12 +261,20 @@ cmd: '{timeout_cmd} ./contrib/jenkins.sh' - osmo-ttcn3-hacks: - repos_url: 'https://gerrit.osmocom.org/{repos}' slave_axis: !!python/tuple [ttcn3] - concurrent: false cmd: | - set -e - make deps; make clean; make compile + docker run \ + --rm \ + -v "$PWD:/build" \ + "registry.osmocom.org/osmocom-build/debian-bullseye-titan" \ + {timeout_cmd} \ + sh -e -x -c " + useradd --uid=1000 build; + cd /build; + su build -c 'make deps'; + su build -c 'make clean'; + su build -c 'make compile'; + " jobs: - 'gerrit-{repos}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27205 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6a667255bb55a945b4c6279d711142aa252c6996 Gerrit-Change-Number: 27205 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in dahdi-linux[master]: icE1usb: GPSDO status support in sysfs

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27093 ) Change subject: icE1usb: GPSDO status support in sysfs ...................................................................... icE1usb: GPSDO status support in sysfs * ability to read GPSDO related bits via sysfs and ioctl * ability to set GPSDO mode via sysfs * show firmware build during driver start and expose it to sysfs Change-Id: I7bc7daa4738b1db37fdd67945d7e976e2581b417 --- M drivers/dahdi/icE1usb/icE1usb.c 1 file changed, 380 insertions(+), 11 deletions(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c index 87a7422..4ce29c6 100644 --- a/drivers/dahdi/icE1usb/icE1usb.c +++ b/drivers/dahdi/icE1usb/icE1usb.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* Osmocom icE1usb driver - * Copyright (C) 2020 by Harald Welte <laforge(a)osmocom.org> + * Copyright (C) 2020-2022 by Harald Welte <laforge(a)osmocom.org> * inspired by osmo-e1d by Sylvain Munaut */ /* The Osmocom icE1usb is a modern, software-defined open hardware and @@ -52,15 +52,39 @@ #define ieu_err(x, fmt, args ...) \ dev_err(&((x)->usb_intf->dev), fmt, ## args) +static const struct usb_device_id ice1usb_products[] = { + { + USB_DEVICE(0x1d50, 0x6145), + }, + {} +}; + /*********************************************************************** * data structures ***********************************************************************/ +/* per-device global state */ +struct ice1usb_gpsdo { + /* USB device we operate on */ + struct usb_device *usb_dev; + struct usb_interface *usb_intf; + + struct e1usb_gpsdo_status gpsdo_status; + char fw_build[128]; + + /* is the device still present (true) or already absent/unplugged (false) */ + bool present; + /* spinlock protecting concurrent access to fc, {read,write}chunk_idx, ... */ + spinlock_t lock; +}; + + enum ice1usb_flags { ICE1USB_ISOC_RUNNING, ICE1USB_IRQ_RUNNING, }; +/* per-interface state */ struct ice1usb { /* USB device and interface we operate on */ struct usb_device *usb_dev; @@ -197,11 +221,13 @@ } #define USB_RT_VEND_IF (USB_TYPE_VENDOR | USB_RECIP_INTERFACE) +#define USB_RT_VEND_DEV (USB_TYPE_VENDOR | USB_RECIP_DEVICE) /* synchronous request, may block up to 1s, only called from process context! */ static int ice1usb_tx_config(struct ice1usb *ieu) { int rc; + uint8_t if_num = ieu->usb_intf->cur_altsetting->desc.bInterfaceNumber; ieu_info(ieu, "TX-CONFIG (crc4=%s, timing=%s, ext_loopback=%s, tx_yellow_alarm=%u)\n", tx_mode_str(ieu->cfg.tx.mode), tx_timing_str(ieu->cfg.tx.timing), @@ -209,7 +235,7 @@ rc = usb_control_msg(ieu->usb_dev, usb_sndctrlpipe(ieu->usb_dev, 0), ICE1USB_INTF_SET_TX_CFG, USB_RT_VEND_IF, - 0, 0, &ieu->cfg.tx, sizeof(ieu->cfg.tx), + 0, if_num, &ieu->cfg.tx, sizeof(ieu->cfg.tx), USB_CTRL_SET_TIMEOUT); if (rc < 0) return rc; @@ -849,7 +875,327 @@ }; /*********************************************************************** - * kernel USB integration / probing +* USB GPSDO driver (sysfs files) - NOT _interface_ driver +***********************************************************************/ + +static void ice1usb_gpsdo_free(struct ice1usb_gpsdo *e1d) +{ + usb_put_dev(e1d->usb_dev); + kfree(e1d); +} + +/* The GPS-DO exists only once for the entire USB device, while all the E1 related + * bits exist once per USB interface! */ + +/* update our internal, cached GPS-DO state */ +static int e1u_update_gpsdo(struct ice1usb_gpsdo *e1d) +{ + uint8_t if_num = e1d->usb_intf->cur_altsetting->desc.bInterfaceNumber; + int rc; + + rc = usb_control_msg(e1d->usb_dev, usb_rcvctrlpipe(e1d->usb_dev, 0), + ICE1USB_INTF_GET_GPSDO_STATUS, USB_DIR_IN | USB_RT_VEND_IF, + 0, if_num, &e1d->gpsdo_status, sizeof(e1d->gpsdo_status), + USB_CTRL_SET_TIMEOUT); + if (rc < 0) { + dev_err(&e1d->usb_intf->dev, "Error during GPSDO CTRL GET transfer: %d\n", rc); + return rc; + } + if (rc != sizeof(e1d->gpsdo_status)) { + dev_err(&e1d->usb_dev->dev, "Short read during GPSDO CTRL GET transfer: %d\n", rc); + return -EIO; + } + + return 0; +} + +static const char *gpsdo_mode_str(enum ice1usb_gpsdo_mode mode) +{ + switch (mode) { + case ICE1USB_GPSDO_MODE_DISABLED: + return "disabled"; + case ICE1USB_GPSDO_MODE_AUTO: + return "auto"; + default: + return "invalid"; + } +} + +static const char *gpsdo_antenna_state_str(enum ice1usb_gpsdo_antenna_state st) +{ + switch (st) { + case ICE1USB_GPSDO_ANT_UNKNOWN: + return "unknown"; + case ICE1USB_GPSDO_ANT_OK: + return "ok"; + case ICE1USB_GPSDO_ANT_OPEN: + return "open"; + case ICE1USB_GPSDO_ANT_SHORT: + return "short"; + default: + return "invalid"; + } +} + +static const char *gpsdo_state_str(enum ice1usb_gpsdo_state st) +{ + switch (st) { + case ICE1USB_GPSDO_STATE_DISABLED: + return "disabled"; + case ICE1USB_GPSDO_STATE_CALIBRATE: + return "calibrate"; + case ICE1USB_GPSDO_STATE_HOLD_OVER: + return "hold_over"; + case ICE1USB_GPSDO_STATE_TUNE_COARSE: + return "tune_coarse"; + case ICE1USB_GPSDO_STATE_TUNE_FINE: + return "tune_fine"; + default: + return "invalid"; + } +} + + +static ssize_t e1u_gpsdo_mode_show(struct device *dev, struct device_attribute *attr, + char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + int rc = e1u_update_gpsdo(e1d); + if (rc < 0) + return rc; + return sprintf(buf, "%s\n", gpsdo_mode_str(e1d->gpsdo_status.mode)); +} + +static ssize_t e1u_gpsdo_mode_store(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + uint8_t if_num = e1d->usb_intf->cur_altsetting->desc.bInterfaceNumber; + uint16_t imode; + int rc; + + if (!strcmp(buf, "disabled")) + imode = ICE1USB_GPSDO_MODE_DISABLED; + else if (!strcmp(buf, "auto")) + imode = ICE1USB_GPSDO_MODE_AUTO; + else + return -EINVAL; + + rc = usb_control_msg(e1d->usb_dev, usb_sndctrlpipe(e1d->usb_dev, 0), + ICE1USB_INTF_SET_GPSDO_MODE, USB_RT_VEND_IF, + imode, if_num, NULL, 0, USB_CTRL_SET_TIMEOUT); + if (rc < 0) { + dev_err(&e1d->usb_intf->dev, "Error during GPSDO CTRL SET transfer: %d\n", rc); + return -EIO; + } + e1d->gpsdo_status.mode = imode; + + return count; +} + +static DEVICE_ATTR(gpsdo_mode, 0644, e1u_gpsdo_mode_show, e1u_gpsdo_mode_store); + +static ssize_t e1u_gpsdo_ant_state_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + int rc = e1u_update_gpsdo(e1d); + if (rc < 0) + return rc; + return sprintf(buf, "%s\n", gpsdo_antenna_state_str(e1d->gpsdo_status.antenna_state)); +} + +static DEVICE_ATTR(gpsdo_antenna_state, 0444, e1u_gpsdo_ant_state_show, NULL); + +static ssize_t e1u_gpsdo_state_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + int rc = e1u_update_gpsdo(e1d); + if (rc < 0) + return rc; + return sprintf(buf, "%s\n", gpsdo_state_str(e1d->gpsdo_status.state)); +} + +static DEVICE_ATTR(gpsdo_state, 0444, e1u_gpsdo_state_show, NULL); + +static ssize_t e1u_gpsdo_valid_fix_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + int rc = e1u_update_gpsdo(e1d); + if (rc < 0) + return rc; + return sprintf(buf, "%u\n", e1d->gpsdo_status.valid_fix); +} + +static DEVICE_ATTR(gpsdo_valid_fix, 0444, e1u_gpsdo_valid_fix_show, NULL); + + +static ssize_t e1u_gpsdo_tune_coarse_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + int rc = e1u_update_gpsdo(e1d); + if (rc < 0) + return rc; + return sprintf(buf, "%u\n", e1d->gpsdo_status.tune.coarse); +} + +/* TODO: set tuning */ +static DEVICE_ATTR(gpsdo_tune_coarse, 0444, e1u_gpsdo_tune_coarse_show, NULL); + + +static ssize_t e1u_gpsdo_tune_fine_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + int rc = e1u_update_gpsdo(e1d); + if (rc < 0) + return rc; + return sprintf(buf, "%u\n", e1d->gpsdo_status.tune.fine); +} + +/* TODO: set tuning */ +static DEVICE_ATTR(gpsdo_tune_fine, 0444, e1u_gpsdo_tune_fine_show, NULL); + +static ssize_t e1u_gpsdo_freq_est_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + int rc = e1u_update_gpsdo(e1d); + if (rc < 0) + return rc; + return sprintf(buf, "%u\n", e1d->gpsdo_status.freq_est); +} + +static DEVICE_ATTR(gpsdo_freq_est, 0444, e1u_gpsdo_freq_est_show, NULL); + +static ssize_t e1u_fw_build_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct ice1usb_gpsdo *e1d = dev_get_drvdata(dev); + + return sprintf(buf, "%s\n", e1d->fw_build); +} + +static DEVICE_ATTR(fw_build, 0444, e1u_fw_build_show, NULL); + +static void create_sysfs_files(struct ice1usb_gpsdo *e1d) +{ + device_create_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_mode); + device_create_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_antenna_state); + device_create_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_state); + device_create_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_valid_fix); + device_create_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_tune_coarse); + device_create_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_tune_fine); + device_create_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_freq_est); + device_create_file(&e1d->usb_intf->dev, &dev_attr_fw_build); +} + +static void remove_sysfs_files(struct ice1usb_gpsdo *e1d) +{ + device_remove_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_mode); + device_remove_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_antenna_state); + device_remove_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_state); + device_remove_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_valid_fix); + device_remove_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_tune_coarse); + device_remove_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_tune_fine); + device_remove_file(&e1d->usb_intf->dev, &dev_attr_gpsdo_freq_est); + device_remove_file(&e1d->usb_intf->dev, &dev_attr_fw_build); +} + +static int ice1usb_gpsdo_probe(struct usb_interface *intf, const struct usb_device_id *prod) +{ + struct usb_device *usb_dev = usb_get_dev(interface_to_usbdev(intf)); + const struct usb_interface_descriptor *ifdesc = &intf->altsetting->desc; + struct ice1usb_gpsdo *e1d; + int ret = -ENODEV; + int rc; + + dev_dbg(&intf->dev, "entering %s", __FUNCTION__); + + if (ifdesc->bInterfaceClass != 0xff || ifdesc->bInterfaceSubClass != 0xE1) { + dev_dbg(&intf->dev, "Unsupported Interface Class/SubClass %02x/%02x", + ifdesc->bInterfaceClass, ifdesc->bInterfaceSubClass); + ret = -ENODEV; + goto error; + } + + /* we only support protocol 0 so far */ + if (ifdesc->bInterfaceProtocol != 0xd0) { + ret = -ENODEV; + goto error; + } + + e1d = kzalloc(sizeof(*e1d), GFP_KERNEL); + if (!e1d) { + dev_err(&intf->dev, "Out of memory\n"); + ret = -ENOMEM; + goto error; + } + + e1d->usb_dev = usb_dev; + e1d->usb_intf = intf; + e1d->present = true; + spin_lock_init(&e1d->lock); + + usb_set_intfdata(intf, e1d); + + /* obtain firmware build information */ + e1d->fw_build[0] = '\0'; + rc = usb_control_msg(e1d->usb_dev, usb_rcvctrlpipe(e1d->usb_dev, 0), + ICE1USB_DEV_GET_FW_BUILD, USB_DIR_IN | USB_RT_VEND_DEV, + 0, 0, e1d->fw_build, sizeof(e1d->fw_build), USB_CTRL_SET_TIMEOUT); + if (rc < 0) { + dev_err(&e1d->usb_intf->dev, "Error during FW BUILD CTRL GET transfer: %d\n", rc); + ret = rc; + goto error_free; + } + e1d->fw_build[sizeof(e1d->fw_build)-1] = '\0'; + dev_info(&e1d->usb_intf->dev, "icE1usb firmware build: '%s'\n", e1d->fw_build); + + create_sysfs_files(e1d); + + return 0; + +error_free: + usb_set_intfdata(intf, NULL); + kfree(e1d); +error: + usb_put_dev(usb_dev); + return ret; +} + +static void ice1usb_gpsdo_disconnect(struct usb_interface *intf) +{ + struct ice1usb_gpsdo *e1d = usb_get_intfdata(intf); + + dev_dbg(&intf->dev, "entering %s", __FUNCTION__); + + if (!e1d) + return; + + /* avoid any shutdown code from submitting further I/O */ + e1d->present = false; + + remove_sysfs_files(e1d); + + usb_set_intfdata(intf, NULL); + + ice1usb_gpsdo_free(e1d); +} + + +static struct usb_driver ice1usb_gpsdo_driver = { + .name = "icE1usb-GPSDO", + .id_table = ice1usb_products, + .probe = ice1usb_gpsdo_probe, + .disconnect = ice1usb_gpsdo_disconnect, +}; + +/*********************************************************************** + * kernel USB integration / probing ***********************************************************************/ /* does the given altsetting contain an EP with wMaxPacketSize == 0 ? */ @@ -989,6 +1335,10 @@ return -ENODEV; } + /* we only support protocol 0 so far */ + if (ifdesc->bInterfaceProtocol != 0x00) + return -ENODEV; + ieu = kzalloc(sizeof(*ieu), GFP_KERNEL); if (!ieu) { dev_err(&intf->dev, "Out of memory\n"); @@ -1119,13 +1469,6 @@ } #endif -static const struct usb_device_id ice1usb_products[] = { - { - USB_DEVICE(0x1d50, 0x6145), - }, - {} -}; - static struct usb_driver ice1usb_driver = { .name = "icE1usb", .id_table = ice1usb_products, @@ -1135,7 +1478,33 @@ //.resume = ice1usb_resume, }; -module_usb_driver(ice1usb_driver); + +/* cannot use module_usb_driver() as we have both E1 and GPS-DO drivers */ +static int __init __ice1usb_init(void) +{ + int rc; + + rc = usb_register_driver(&ice1usb_gpsdo_driver, THIS_MODULE, KBUILD_MODNAME); + if (rc < 0) + return rc; + + rc = usb_register_driver(&ice1usb_driver, THIS_MODULE, KBUILD_MODNAME); + if (rc < 0) { + usb_deregister(&ice1usb_gpsdo_driver); + return rc; + } + + return rc; +} + +static void __exit __ice1usb_exit(void) +{ + usb_deregister(&ice1usb_gpsdo_driver); + usb_deregister(&ice1usb_driver); +} + +module_init(__ice1usb_init); +module_exit(__ice1usb_exit); MODULE_AUTHOR("Harald Welte <laforge(a)osmocom.org>"); MODULE_DESCRIPTION("Osmocom icE1usb USB E1 interface"); -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7bc7daa4738b1db37fdd67945d7e976e2581b417 Gerrit-Change-Number: 27093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in dahdi-linux[master]: icE1usb: update ice1usb_proto.h to firmware 0.2-8

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/26967 ) Change subject: icE1usb: update ice1usb_proto.h to firmware 0.2-8 ...................................................................... icE1usb: update ice1usb_proto.h to firmware 0.2-8 git revision cac342af6bccc9820a8617f900afaf663ad608ed of https://git.osmocom.org/osmo-e1-hardware Change-Id: I1423531470a1c9165d713108fb6a87ff47ff6e29 --- M drivers/dahdi/icE1usb/icE1usb.c M drivers/dahdi/icE1usb/ice1usb_proto.h 2 files changed, 51 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c index 13af6fc..87a7422 100644 --- a/drivers/dahdi/icE1usb/icE1usb.c +++ b/drivers/dahdi/icE1usb/icE1usb.c @@ -1013,6 +1013,8 @@ dev_err(&intf->dev, "Cannot find ON altsetting"); goto error; } + dev_info(&intf->dev, "altsetting off=%u, on=%u\n", + ieu->alt_off->desc.bAlternateSetting, ieu->alt_on->desc.bAlternateSetting); /* locate ON / OFF altsettings */ if (find_endpoints(ieu, ieu->alt_on) < 4) { @@ -1035,6 +1037,7 @@ //ddev->location = USB_BUS_PATH; dspan = &ieu->dahdi.span; + /* TODO: include USB path info? */ snprintf(dspan->name, sizeof(dspan->name), "icE1usb/1/%d", ieu->alt_on->desc.bInterfaceNumber); //TDOO: device != 1 snprintf(dspan->desc, sizeof(dspan->desc), "Osmocom icE1USB Card 1 Span %d", diff --git a/drivers/dahdi/icE1usb/ice1usb_proto.h b/drivers/dahdi/icE1usb/ice1usb_proto.h index d0d7304..3170d55 100644 --- a/drivers/dahdi/icE1usb/ice1usb_proto.h +++ b/drivers/dahdi/icE1usb/ice1usb_proto.h @@ -23,8 +23,54 @@ ICE1USB_DEV_CAP_GPSDO, }; +/*********************************************************************** + * Control Endpoint / GPS-DO Interface Requests + ***********************************************************************/ -/* Interface Requests */ +#define ICE1USB_INTF_GET_GPSDO_STATUS 0x10 +#define ICE1USB_INTF_GET_GPSDO_MODE 0x12 /*!< uint8_t */ +#define ICE1USB_INTF_SET_GPSDO_MODE 0x13 /*!< wValue = mode */ +#define ICE1USB_INTF_GET_GPSDO_TUNE 0x14 /*!< data = struct e1usb_gpsdo_tune */ +#define ICE1USB_INTF_SET_GPSDO_TUNE 0x15 /*!< data = struct e1usb_gpsdo_tune */ + +enum ice1usb_gpsdo_mode { + ICE1USB_GPSDO_MODE_DISABLED = 0, + ICE1USB_GPSDO_MODE_AUTO = 1, +}; + +enum ice1usb_gpsdo_antenna_state { + ICE1USB_GPSDO_ANT_UNKNOWN = 0, + ICE1USB_GPSDO_ANT_OK = 1, + ICE1USB_GPSDO_ANT_OPEN = 2, + ICE1USB_GPSDO_ANT_SHORT = 3, +}; + +enum ice1usb_gpsdo_state { + ICE1USB_GPSDO_STATE_DISABLED = 0, + ICE1USB_GPSDO_STATE_CALIBRATE = 1, + ICE1USB_GPSDO_STATE_HOLD_OVER = 2, + ICE1USB_GPSDO_STATE_TUNE_COARSE = 3, + ICE1USB_GPSDO_STATE_TUNE_FINE = 4, +}; + +struct e1usb_gpsdo_tune { + uint16_t coarse; + uint16_t fine; +} __attribute__((packed)); + +struct e1usb_gpsdo_status { + uint8_t state; + uint8_t antenna_state; /*!< Antenna state */ + uint8_t valid_fix; /*!< Valid GPS Fix (0/1) */ + uint8_t mode; /*!< Current configured operating mode */ + struct e1usb_gpsdo_tune tune; /*!< Current VCXO tuning values */ + uint32_t freq_est; /*!< Latest frequency estimate measurement */ +} __attribute__((packed)); + + +/*********************************************************************** + * Control Endpoint / E1 Interface Requests + ***********************************************************************/ /*! returns a bit-mask of optional device capabilities (see enum e1usb_intf_capability) */ #define ICE1USB_INTF_GET_CAPABILITIES 0x01 @@ -32,6 +78,7 @@ #define ICE1USB_INTF_GET_TX_CFG 0x03 /*!< struct ice1usb_tx_config */ #define ICE1USB_INTF_SET_RX_CFG 0x04 /*!< struct ice1usb_rx_config */ #define ICE1USB_INTF_GET_RX_CFG 0x05 /*!< struct ice1usb_rx_config */ +#define ICE1USB_INTF_GET_ERRORS 0x06 /*!< struct ice1usb_irq_err */ //enum e1usb_intf_capability { }; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/26967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I1423531470a1c9165d713108fb6a87ff47ff6e29 Gerrit-Change-Number: 26967 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in dahdi-linux[master]: icE1usb: GPSDO status support in sysfs

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27093 ) Change subject: icE1usb: GPSDO status support in sysfs ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7bc7daa4738b1db37fdd67945d7e976e2581b417 Gerrit-Change-Number: 27093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Feb 2022 14:00:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in dahdi-linux[master]: icE1usb: GPSDO status support in sysfs

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27093 ) Change subject: icE1usb: GPSDO status support in sysfs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7bc7daa4738b1db37fdd67945d7e976e2581b417 Gerrit-Change-Number: 27093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Feb 2022 14:00:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in dahdi-linux[master]: icE1usb: GPSDO status support in sysfs

by laforge

Attention is currently required from: laforge. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27093 ) Change subject: icE1usb: GPSDO status support in sysfs ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I7bc7daa4738b1db37fdd67945d7e976e2581b417 Gerrit-Change-Number: 27093 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

2 years, 3 months

1
0
0 0

Change in libosmocore[master]: stats: sanitize tcp stat name identifiers

by laforge

Attention is currently required from: iedemam, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: sanitize tcp stat name identifiers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I somehow forgot to send this: […] sounds like a good plan, daniel. I would even allow the user to set a sanitized name (overriding the internal automatic/implicit sanitization, in case the caller has a better way than the automatic one). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:58:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: show hint about typedefs_osmo.txt

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27203 ) Change subject: lint: checkpatch: show hint about typedefs_osmo.txt ...................................................................... lint: checkpatch: show hint about typedefs_osmo.txt Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 --- M lint/checkpatch/checkpatch.pl 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index 51c406e..d98d79c 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -5151,7 +5151,7 @@ } } elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { if (ERROR("SPACING", - "need consistent spacing around '$op' $at\n" . $hereptr)) { + "need consistent spacing around '$op' $at (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)\n" . $hereptr)) { $good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " "; if (defined $fix_elements[$n + 2]) { $fix_elements[$n + 2] =~ s/^\s+//; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 Gerrit-Change-Number: 27203 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: show hint about typedefs_osmo.txt

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27203 ) Change subject: lint: checkpatch: show hint about typedefs_osmo.txt ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 Gerrit-Change-Number: 27203 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:56:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: [DO NOT MERGE] test-change: new file

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27204 ) Change subject: [DO NOT MERGE] test-change: new file ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I46d4801d85f77bc88e0c527fec753d1e0b17f9a0 Gerrit-Change-Number: 27204 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: abandon

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: [DO NOT MERGE] test-change: new file

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27204 ) Change subject: [DO NOT MERGE] test-change: new file ...................................................................... [DO NOT MERGE] test-change: new file Related: OS#5452 Change-Id: I46d4801d85f77bc88e0c527fec753d1e0b17f9a0 --- A test-change.txt 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/27204/1 diff --git a/test-change.txt b/test-change.txt new file mode 100644 index 0000000..22206fc --- /dev/null +++ b/test-change.txt @@ -0,0 +1 @@ +test change for https://osmocom.org/issues/5452 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I46d4801d85f77bc88e0c527fec753d1e0b17f9a0 Gerrit-Change-Number: 27204 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: show hint about typedefs_osmo.txt

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27203 ) Change subject: lint: checkpatch: show hint about typedefs_osmo.txt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 Gerrit-Change-Number: 27203 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:34:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in libosmocore[master]: stats: sanitize tcp stat name identifiers

by daniel

Attention is currently required from: iedemam, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: sanitize tcp stat name identifiers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, the patch is simple but I don't really think the generated strings are less ugly. […] I somehow forgot to send this: The NSVCs currently set a name like this: NSE00102-NSVC-UDP-127_0_0_1:23000-127_0_0_11:8888 This seems wrong for statsd as well, because a colon separates the name from the value - so we already have this issue in other places. How about we: * Keep a statg->name as well as a statg->sanitized_name around * Let the user set any name through set_name() * Internally sanitize the name and save it to sanitized_name, keep the original in name This way we don't need to remember to properly sanitize at every caller and VTY code can still show the pretty name. The control interface could choose to use the (statsd-sanitized) name or sanitize the original name itself. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:31:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by daniel

Attention is currently required from: laforge, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:26:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by dexter

Attention is currently required from: laforge, daniel. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/ranap_rab_ass.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199/comment/306d1186_235c204e PS2, Line 603: Response > Request, above as well Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by dexter

Attention is currently required from: laforge, daniel. Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 to look at the new patch set (#3). Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... ranap_rab_ass: add function to check if RAB is in ReleaseList A RANAP RAB-AssignmentRelease may contain a ReleaseList. In order to detect that a RAB is about to be released we need to be able to check if the RAB we are dealing with is contained in such a ReleaseList. Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Related: OS#5152 --- M include/osmocom/hnbgw/ranap_rab_ass.h M src/osmo-hnbgw/ranap_rab_ass.c M tests/ranap_rab_ass/ranap_rab_ass_test.c M tests/ranap_rab_ass/ranap_rab_ass_test.ok 4 files changed, 97 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/99/27199/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... lint: checkpatch: add typedefs_osmo.txt Fix false error: ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) in a line with a typedef: int handle_rab_ass_req(..., ranap_message *message); Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c --- M lint/checkpatch/checkpatch_osmo.sh A lint/checkpatch/typedefs_osmo.txt 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Verified dexter: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 8514f9c..93b601b 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -116,6 +116,7 @@ --ignore UNSPECIFIED_INT \ --ignore VOLATILE \ --max-line-length 120 \ + --typedefsfile "$SCRIPT_DIR/typedefs_osmo.txt" \ --no-signoff \ --no-tree \ "$@" diff --git a/lint/checkpatch/typedefs_osmo.txt b/lint/checkpatch/typedefs_osmo.txt new file mode 100644 index 0000000..5164368 --- /dev/null +++ b/lint/checkpatch/typedefs_osmo.txt @@ -0,0 +1 @@ +ranap_message -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:55:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by dexter

Attention is currently required from: osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:54:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... lint: checkpatch: add typedefs_osmo.txt Fix false error: ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) in a line with a typedef: int handle_rab_ass_req(..., ranap_message *message); Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c --- M lint/checkpatch/checkpatch_osmo.sh A lint/checkpatch/typedefs_osmo.txt 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/02/27202/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 8514f9c..93b601b 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -116,6 +116,7 @@ --ignore UNSPECIFIED_INT \ --ignore VOLATILE \ --max-line-length 120 \ + --typedefsfile "$SCRIPT_DIR/typedefs_osmo.txt" \ --no-signoff \ --no-tree \ "$@" diff --git a/lint/checkpatch/typedefs_osmo.txt b/lint/checkpatch/typedefs_osmo.txt new file mode 100644 index 0000000..5164368 --- /dev/null +++ b/lint/checkpatch/typedefs_osmo.txt @@ -0,0 +1 @@ +ranap_message -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: show hint about typedefs_osmo.txt

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27203 ) Change subject: lint: checkpatch: show hint about typedefs_osmo.txt ...................................................................... lint: checkpatch: show hint about typedefs_osmo.txt Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 --- M lint/checkpatch/checkpatch.pl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/03/27203/1 diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index 51c406e..d98d79c 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -5151,7 +5151,7 @@ } } elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { if (ERROR("SPACING", - "need consistent spacing around '$op' $at\n" . $hereptr)) { + "need consistent spacing around '$op' $at (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)\n" . $hereptr)) { $good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " "; if (defined $fix_elements[$n + 2]) { $fix_elements[$n + 2] =~ s/^\s+//; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 Gerrit-Change-Number: 27203 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ranap: Add templates for RAB Assignment ReleaseRequest

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27119 ) Change subject: ranap: Add templates for RAB Assignment ReleaseRequest ...................................................................... ranap: Add templates for RAB Assignment ReleaseRequest Change-Id: Ie22253c84651119c4da91053eb4d79ad8f4abe7d --- M library/ranap/RANAP_Templates.ttcn 1 file changed, 76 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, approved diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index ae762b9..7f9731b 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -1430,6 +1430,82 @@ } } +template (value) RAB_ReleaseList ts_RAB_RL(template (value) RAB_ID rab_id, + template (value) Cause cause) := { { + { + id := id_RAB_ReleaseItem, + criticality := ignore, + value_ := { + rAB_ReleaseItem := { + rAB_ID := rab_id, + cause := cause, + iE_Extensions := omit + } + } + } +} } + +template RAB_ReleaseList tr_RAB_RL(template RAB_ID rab_id, + template Cause cause := ?) := { { + { + id := id_RAB_ReleaseItem, + criticality := ignore, + value_ := { + rAB_ReleaseItem := { + rAB_ID := rab_id, + cause := cause, + iE_Extensions := * + } + } + } +} } + +template (value) RANAP_PDU +ts_RANAP_RabReleaseReq(template (value) RAB_ReleaseList rab_rl, + template (omit) RAB_ReleaseRequest.protocolExtensions exts := omit) := { + initiatingMessage := { + procedureCode := id_RAB_Assignment, + criticality := reject, + value_ := { + rAB_ReleaseRequest := { + protocolIEs := { + { + id := id_RAB_ReleaseList, + criticality := ignore, + value_ := { + rAB_ReleaseList := rab_rl + } + } + }, + protocolExtensions := exts + } + } + } +} + +template RANAP_PDU +tr_RANAP_RabReleaseReq(template RAB_ReleaseList rab_rl, + template RAB_ReleaseRequest.protocolExtensions exts := *) := { + initiatingMessage := { + procedureCode := id_RAB_Assignment, + criticality := reject, + value_ := { + rAB_ReleaseRequest := { + protocolIEs := { + { + id := id_RAB_ReleaseList, + criticality := ignore, + value_ := { + rAB_ReleaseList := rab_rl + } + } + }, + protocolExtensions := exts + } + } + } +} + /***************************************************************************************************** * -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie22253c84651119c4da91053eb4d79ad8f4abe7d Gerrit-Change-Number: 27119 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ranap: Add more RAB-related templates

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27113 ) Change subject: ranap: Add more RAB-related templates ...................................................................... ranap: Add more RAB-related templates Change-Id: I363428ab4af869bb1aa4470b33fa52366cbda8b4 --- M library/ranap/RANAP_Templates.ttcn 1 file changed, 61 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index a1b0a59..ae762b9 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -1,6 +1,8 @@ module RANAP_Templates { import from General_Types all; +import from Misc_Helpers all; +import from Native_Functions all; import from RANAP_IEs all; import from RANAP_CommonDataTypes all; @@ -487,6 +489,24 @@ * RAB Release *****************************************************************************************************/ +template (value) RAB_ID +t_RAB_id(integer rab_id) := int2bit(rab_id, 8); + +template (value) TransportLayerAddress ts_RAB_TLA4(OCT4 ip) := hex2bit('350001'H & oct2hex(ip) & '00000000000000000000000000'H); +template (value) TransportLayerAddress ts_RAB_TLA6(OCT16 ip) := hex2bit('350000'H & oct2hex(ip) & '00'H); +function f_ts_RAB_TLA(charstring addr) return template (value) TransportLayerAddress { + if (f_addr_is_ipv6(addr)) { + var OCT16 ip6 := f_inet6_addr(addr); + return ts_RAB_TLA6(ip6); + } else { + var OCT4 ip4 := f_inet_addr(addr); + return ts_RAB_TLA4(ip4); + } +} + +template (value) BindingID +t_RAB_binding_port(integer prt) := int2oct(prt, 2) & '0000'O; + template (value) RANAP_PDU ts_RANAP_RabReleaseRequest(template (value) RAB_ID rab_id, template (value) Cause cause, template (omit) RAB_ReleaseRequest.protocolExtensions exts := omit) := { @@ -522,7 +542,7 @@ } } template RANAP_PDU -tr_RANAP_RabReleaseRequest(template RAB_ID rab_id, template Cause cause, +tr_RANAP_RabReleaseRequest(template (present) RAB_ID rab_id, template Cause cause, template RAB_ReleaseRequest.protocolExtensions exts := *) := { initiatingMessage := { procedureCode := id_RAB_ReleaseRequest, @@ -1271,6 +1291,45 @@ } } } +template (value) RAB_SetupOrModifiedList ts_RAB_SMdL(template (value) RAB_ID rab_id, + template (value) TransportLayerAddress tla, + template (value) BindingID binding_id) := { { + { + id := id_RAB_SetupOrModifiedItem, + criticality := ignore, + value_ := { + rAB_SetupOrModifiedItem := { + rAB_ID := rab_id, + transportLayerAddress := tla, + iuTransportAssociation := { + bindingID := binding_id + }, + dl_dataVolumes := omit, + iE_Extensions := omit + } + } + } +} } + +template RAB_SetupOrModifiedList tr_RAB_SMdL(template RAB_ID rab_id, + template TransportLayerAddress tla, + template BindingID binding_id) := { { + { + id := id_RAB_SetupOrModifiedItem, + criticality := ignore, + value_ := { + rAB_SetupOrModifiedItem := { + rAB_ID := rab_id, + transportLayerAddress := tla, + iuTransportAssociation := { + bindingID := binding_id + }, + dl_dataVolumes := *, + iE_Extensions := * + } + } + } +} } template (value) RANAP_PDU ts_RANAP_RabAssReq(template (value) RAB_SetupOrModifyList rab_sml, @@ -1283,7 +1342,7 @@ protocolIEs := { { id := id_RAB_SetupOrModifyList, - criticality := reject, + criticality := ignore, value_ := { rAB_SetupOrModifyList := rab_sml } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I363428ab4af869bb1aa4470b33fa52366cbda8b4 Gerrit-Change-Number: 27113 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MGCP_Templates: Add receive templates for SDP and use those in {CR,MD}CX

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27117 ) Change subject: MGCP_Templates: Add receive templates for SDP and use those in {CR,MD}CX ...................................................................... MGCP_Templates: Add receive templates for SDP and use those in {CR,MD}CX Change-Id: Ibc46888b1b7913d399c79ab735841844ff0487ad --- M library/MGCP_Templates.ttcn 1 file changed, 52 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified Vadim Yanitskiy: Looks good to me, approved diff --git a/library/MGCP_Templates.ttcn b/library/MGCP_Templates.ttcn index 917ef89..2fd9b18 100644 --- a/library/MGCP_Templates.ttcn +++ b/library/MGCP_Templates.ttcn @@ -113,10 +113,10 @@ sdp := sdp } - template MgcpCommand tr_CRCX(template MgcpEndpoint ep := ?) := { + template MgcpCommand tr_CRCX(template MgcpEndpoint ep := ?, template SDP_Message sdp := *) := { line := t_MgcpCmdLine("CRCX", ?, ep), params := *, - sdp := * + sdp := sdp } template MgcpResponse tr_CRCX_ACK := { @@ -187,10 +187,10 @@ sdp := sdp } - template MgcpCommand tr_MDCX := { + template MgcpCommand tr_MDCX(template SDP_Message sdp := *) := { line := t_MgcpCmdLine("MDCX", ?, ?), params := *, - sdp := * + sdp := sdp } template MgcpResponse tr_MDCX_ACK := { @@ -284,6 +284,18 @@ } } + template SDP_connection tr_SDP_connection_IP(template charstring addr, template charstring addr_type := ?, + template integer ttl := *, + template integer num_of_addr := *) := { + net_type := "IN", + addr_type := addr_type, + conn_addr := { + addr := addr, + ttl := ttl, + num_of_addr := num_of_addr + } + } + template SDP_time ts_SDP_time(charstring beg, charstring end) := { time_field := { start_time := beg, @@ -310,6 +322,25 @@ attributes := attributes } + template SDP_media_desc tr_SDP_media_desc(template integer port_number := ?, + template SDP_fmt_list fmts := ?, + template SDP_attribute_list attributes := ?) := { + media_field := { + media := "audio", + ports := { + port_number := port_number, + num_of_ports := omit + }, + transport := "RTP/AVP", + fmts := fmts + }, + information := *, + connections := *, + bandwidth := *, + key := *, + attributes := attributes + } + /* master template for generating SDP based in template arguments */ template SDP_Message ts_SDP(charstring local_addr, charstring remote_addr, charstring session_id, charstring session_version, @@ -331,6 +362,23 @@ media_list := { ts_SDP_media_desc(rtp_port, fmts, attributes) } } + template SDP_Message tr_SDP(template charstring remote_addr := ?, template integer rtp_port := ?) := { + protocol_version := 0, + origin := ?, + session_name := ?, + information := *, + uri := *, + emails := *, + phone_numbers := *, + connection := tr_SDP_connection_IP(remote_addr, ?), + bandwidth := *, + times := ?, + timezone_adjustments := *, + key := *, + attributes := *, + media_list := { tr_SDP_media_desc(rtp_port) } + } + template SDP_attribute ts_SDP_rtpmap(integer fmt, charstring val) := { rtpmap := { attr_value := int2str(fmt) & " " & val -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc46888b1b7913d399c79ab735841844ff0487ad Gerrit-Change-Number: 27117 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ranap: Add more RAB-related templates

by daniel

Attention is currently required from: Vadim Yanitskiy, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27113 ) Change subject: ranap: Add more RAB-related templates ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: Readding +1 from pespin -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27113 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I363428ab4af869bb1aa4470b33fa52366cbda8b4 Gerrit-Change-Number: 27113 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:46:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by daniel

Attention is currently required from: laforge, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-hnbgw/ranap_rab_ass.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199/comment/79a9e070_c9dc291b PS2, Line 603: Response Request, above as well -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:44:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in FailureList

by daniel

Attention is currently required from: dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 ) Change subject: ranap_rab_ass: add function to check if RAB is in FailureList ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I4319f7caa45ea758ccd792cc8570521df075cf45 Gerrit-Change-Number: 27139 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:42:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Introduce test TC_pdp4_act_update_teid/teic

by pespin

Attention is currently required from: pespin, Vadim Yanitskiy. Hello Jenkins Builder, laforge, Vadim Yanitskiy, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197 to look at the new patch set (#4). Change subject: ggsn: Introduce test TC_pdp4_act_update_teid/teic ...................................................................... ggsn: Introduce test TC_pdp4_act_update_teid/teic This test validates that changing the local TEID through UpdatePDPContext is correctly followed by the GGSN. Change-Id: Ic6af25866bf7efc2cabf029e49abaf15d5857592 --- M ggsn_tests/GGSN_Tests.ttcn M library/GTP_Templates.ttcn 2 files changed, 160 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/27197/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic6af25866bf7efc2cabf029e49abaf15d5857592 Gerrit-Change-Number: 27197 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 3 months

1
0
0 0

Change in libosmocore[master]: stats: sanitize tcp stat name identifiers

by iedemam

Attention is currently required from: laforge, pespin, daniel. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: sanitize tcp stat name identifiers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, the patch is simple but I don't really think the generated strings are less ugly. […] I agree. Maybe a straightforward solution is to add a "dedup" flag to the sanitation function? After it replaces all unwanted characters with the safe character, it would then remove sequential instances of the safe character. By adding "-" to the unwanted character list, at least in this instance we then see: BEFORE: ipa-oml,r=127.0.0.1:45749<->l=127.0.0.1:3002 AFTER: ipa_oml_r_127_0_0_1_45749_l_127_0_0_1_3002 Either that or write sanitation logic for the IP connectivity string specifically. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:05:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: random comment to test gerrit mail notification, please ignore -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 11:17:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 3 months

1
0
0 0

2024

2023

2022

gerrit-log