Attention is currently required from: iedemam.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31617 )
Change subject: utils: fix incorrect string checks in meas_db_insert()
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Good catch, apologies for the miss. […]
No
worries, it's absolutely normal and we all make mistakes.
File src/utils/meas_db.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31617/comment/8b5c6a0b_ab216ab6
PS1, Line 97: if (mfm->imsi[0] != '\0')
The original checks before my refactor were using
strlen(). […]
Let's see what the others think. If people find `strlen()` more
readable, I can amend the patch. The compiler would optimize `strlen()` out anyway.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31617
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I8a41078070119bc22d594c0dfff5d98b5d16f970
Gerrit-Change-Number: 31617
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: iedemam <michael(a)kapsulate.com>
Gerrit-Attention: iedemam <michael(a)kapsulate.com>
Gerrit-Comment-Date: Wed, 01 Mar 2023 09:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael(a)kapsulate.com>
Gerrit-MessageType: comment