Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33892 ) Change subject: bsc (WIP): Make socket queue max. length configurable ...................................................................... Patch Set 2: (3 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/be28330f_ed6aefd5 PS1, Line 2487: if (fd >= 0 && ((ofd = osmo_fd_get_by_fd(fd)) != NULL)) { I guess it doesn't really matter here. I viewed it as a check to make sure `pcu_sock_init()` has been run before, in case there are any other states permitting `net->pcu_state` without `net->pcu_state->upqueue` being allocated. I checked the code and it looks like there are no such states. https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/8d91cc21_656855d8 PS1, Line 2491: } I suppose it's possible to check if the current wqueue length is larger than the new maximum right inside this command when it's called, and then drop extra messages. Otherwise.. why should there be a new API? What kind? Do we really want to drop messages from previously 'legal' enqueue actions though? File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/da802a47_9e38c4c5 PS1, Line 956: net->pcu_sock_fd = rc; Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33892 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b Gerrit-Change-Number: 33892 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 30 Jul 2023 18:33:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment