Attention is currently required from: fixeria, laforge, osmith. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email ) Change subject: soft_uart: implement modem status lines and flow control ...................................................................... Patch Set 3: (4 comments) File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/b72581a5_f5e0d8c6 PS2, Line 398: if (active) /* assert the given line */ Logic 1 is negative voltage on RS232 level and is the de-asserted (disabled) level on control lines. File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/cecaeddf_b45cd677 PS3, Line 214: OSMO_SUART_STATUS_F_RTS_RTR RX must continue. Due to round-trip delay, it takes a while until the remote site reacts on dropping RTS line. An application must drop RTS before the input buffer is full, to prevent loss of RX data after dropping RTS. The application must drop received characters if the buffer is full and the remote side continues to send. https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/0bd82084_3f096c3d PS3, Line 324: OSMO_SUART_STATUS_F_CTS The current character needs to be finished before the transmitter can stop transmitting. https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/8f418e2d_2d287173 PS3, Line 399: else If you de-assert DTR, you should reset the transmitter state. If you de-assert the DSR, you should reset the receiver state. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I26b93ce76f2f6b6fbf017f2684312007db3c6d48 Gerrit-Change-Number: 35172 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Nov 2023 10:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment