Attention is currently required from: osmith, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email )
Change subject: gprs_rlcmac_sched: check if we really use direct phy
......................................................................
Patch Set 3: Code-Review-2
(1 comment)
File src/gprs_rlcmac_sched.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/34575/comment/4a645dd1_d004c084
PS2, Line 491: if (bts->trx[trx].fl1h) {
> Osmo-bts would do this then. […]
As far as
I can see your concerns might be right. When the data is traveling up from pcu_sock.c over
l1sap.c it ends up in l1_if.c:bts_model_l1sap_down() of the respective BTS model. For
osmo-bts-trx I can see the data is passed into trx_sched_ph_data_req(), which is our
scheduler and I assume that this scheduler generates the idle frames.
For osmo-bts-sysmo I am not entirely sure but I see no mechanism that would substitute
missing frames. When there is nothing coming up from the PCUIF, then no frame is scheduled
into the phy.
In any case it may be that osmo-bts uses a BTS model that still requires a constant stream
of MAC blocks from the PCU through the PCUIF interface. Maybe we could add the BTS model
to struct gsm_pcu_if_info_ind, so that the PCU knows the exact BTS model it is dealing
with. This does not have to be a string. It can just be an uint8_t used with enum values.
In osmo-pcu we then could set an appropriate flag in struct gprs_rlcmac_bts. And based on
that flag we then would generate the idle frames or not. Eventually the fact if we
generate idle frames or not would not strongly depend on whether we use a direct phy
access or not. It would depend on the BTS model and if it is operated as direct phy or not
but this is something that is highly model specific.
One additional advantage we could draw if we signal the BTS model type to osmo-pcu is that
we can check if this model is even supported and reject it if necessary.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I0808950b1154bbb9a789c3f706ad9fb6618764ec
Gerrit-Change-Number: 34575
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Sep 2023 15:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment