Attention is currently required from: laforge, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31113
)
Change subject: pcuif_proto: add indication to communicate E1 parameters
......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/31113/comment/8f0bfb53_dda0c6d6
PS1, Line 10: setup. To avioud duplicate configuration the BSC has to communicate the
"avoid"
Done
Patchset:
PS1:
I have fixed the comments now (in both patches). Will post an updated version with the
next push. Unfortunately there are two patches like this with the same change ID. One for
osmo-bsc, and one for osmo-pcu. This is an error. I will keep the one for osmo-pcu and
abandon the one for osmo-bsc. The patch will then be pushed again with a new change ID.
File include/osmocom/bsc/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31113/comment/1299d256_444bc44e
PS1, Line 263: uint8_t pdch_trx_no;
this was not yet changed to trx_nr, why?
There
are two patches around with the same change id, I have seen it and I will change it.
https://gerrit.osmocom.org/c/osmo-bsc/+/31113/comment/d93ee48e_c69b35e4
PS1, Line 264: uint8_t pdch_ts;
this was not yet changed to ts_nr, why?
There
are two patches around with the same change id, I have seen it and I will change it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31113
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia7928489130c1205b06bb9b10de0fb1461843301
Gerrit-Change-Number: 31113
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Jan 2023 11:14:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment