Attention is currently required from: dexter, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email )
Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip
......................................................................
Patch Set 2:
(1 comment)
File src/gprs_rlcmac_sched.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/35151/comment/fe7bd69a_25c49d21
PS1, Line 486: * way we help BTS energy saving (on TRX!=C0) by sending nothing
This is how it works: […]
Oh, I overlooked the
`skip_idle && trx != 0` part in the old code (left side). I don't remember why
we had this constraint, but could you explain why are you removing it?
With this constraint we only have power saving on Cn (n > 0). On the BCCH carrier we
always transmit PDCH blocks at full power, no matter if there are active TBFs or not,
because we always get DATA.req for the C0.
By removing this constraint in your patch you're making osmo-bts-trx send Dummy Bursts
(carrying no info at all) instead of Normal Bursts. Like I explained in my previous
comment.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iadb62748b18605bf158169b317f880352bc0a5a6
Gerrit-Change-Number: 35151
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Nov 2023 22:38:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment