Attention is currently required from: osmith.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-dev/+/33381 )
Change subject: src/grd: Add option for cherry-picking
......................................................................
Patch Set 2:
(3 comments)
File src/grd:
https://gerrit.osmocom.org/c/osmo-dev/+/33381/comment/2e9f24d7_d2535db4
PS1, Line 73: cmd = ["git", "cherry-pick",
"FETCH_HEAD"];
for consistency: let's also print the command,
like in git_checkout_fetch_head()
Done
https://gerrit.osmocom.org/c/osmo-dev/+/33381/comment/06bb8847_541c5473
PS1, Line 95: , disabled by default
I'd remove the ", disabled by default"
part, it is redundant as this is an optional parameter and th […]
Done
https://gerrit.osmocom.org/c/osmo-dev/+/33381/comment/efdc5702_d11bee7a
PS1, Line 112: git_cherry_pick_fetch_head()
I'd switch the logic, so the non-inverted case
comes first: […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-dev/+/33381
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I85b1a2c4915e3da374e4b1201f2e977708fc7c4c
Gerrit-Change-Number: 33381
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jun 2023 13:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment