Attention is currently required from: arehbein.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/33892
)
Change subject: bsc (WIP): Make socket queue max. length configurable
......................................................................
Patch Set 4:
(2 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/75d5d4f9_f3c3c43d
PS1, Line 2491: }
I suppose it's possible to check if the current
wqueue length is larger than the new maximum right i […]
If you set a maximum len on
a queue, you definettly don't want your queue to be in a state where the len is over
that maximum.
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/33892/comment/4999ce07_f3d8c2ba
PS4, Line 2486: net->pcu_state->upqueue.max_length =
net->pcu_sock_wqueue_len_max;
use wqueue API which internally drops enqueued messages > max
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/33892
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f19f4613bccaf582997a4d02b689adee083a0b
Gerrit-Change-Number: 33892
Gerrit-PatchSet: 4
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 31 Jul 2023 09:23:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment