Attention is currently required from: laforge, pespin.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email )
Change subject: Automatically reset RIFO on underrun/overflow
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/78eadb4f_e93c920a
PS1, Line 18: twice the value of max_frame_count. It specifies when the RIFO will
max_frame_count is set to twice the value of
max_frame_count? Sounds wrong.
Done
File src/octoi/e1oip.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/93e3c19b_3430f7dc
PS1, Line 272: if (rc < 0) {
did you think about returning a specific error code to
signal this exact error? like -ERANGE.
Done
File src/octoi/frame_rifo.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/34554/comment/b45b7a14_caac05bc
PS1, Line 106: int frame_rifo_in(struct frame_rifo *rifo, const uint8_t *frame, uint32_t
fn, int max_frame_count)
can max_frame_count be negative? unsigned?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/34554?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Id7ccbfbdb288990c01f185dec79a1022a68b4748
Gerrit-Change-Number: 34554
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Sep 2023 19:30:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment