Attention is currently required from: neels, laforge.
keith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28342
)
Change subject: After RX of an SMPP Submit, send the SMS we just received.
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Out of many things I could understand I may have
miscommunicated, I can't see how I have suggested t […]
Uh.. reading this entire
thread.. I've ended up write essays on gerrit recently 😞
I realise there's an incongruency. To be clear:
I do think it is better to try to deliver the SMS on receipt, that is to say: add it to
the in memory "sms-queue", rather than just drop it into the database and
wait/hope for the database getter to load it into the in-memory sms-queue.
The reason why I mentioned above that something "makes these patches
unnecessary" is two-fold:
1) complete removal of sms-queue from osmo-msc. - much talked about at times, but I'm
not holding my breath for it.
2) removal of the sqlite based storage which allows a more aggressive storage to in-memory
queue getter, which somewhat mitigates the problem.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/28342
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c
Gerrit-Change-Number: 28342
Gerrit-PatchSet: 2
Gerrit-Owner: keith <keith(a)rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 30 Jan 2023 18:38:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: keith <keith(a)rhizomatica.org>
Gerrit-MessageType: comment