pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27598 ) Change subject: configure: Support libsctp < 1.0.17 without libsctp.pc ...................................................................... Patch Set 1: (1 comment) File libosmocore.pc.in: https://gerrit.osmocom.org/c/libosmocore/+/27598/comment/33ab0d16_583efd56 PS1, Line 10: Requires.private: @LIBSCTP_PC@ with this approach if the .pc is found it ends up looking like this: """ Requires.private: libsctp Libs: -L${libdir} -losmocore Libs.private: -lsctp """ It's true that the -lsctp will end up duplicated as it will be fed too by libsctp, but given they end up all in "private" section I think it's fine enough. I could have a new @LIBSCTP_MANUAL_LIBS@ but I don't think it's worth adding the complexity for that. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27598 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I241634388c2d32adffebd860c88bdd13002a6af0 Gerrit-Change-Number: 27598 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Comment-Date: Tue, 29 Mar 2022 10:04:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment