Hi, I've been following the installation directions from the wiki, Getting Started. After generating the arm-none-eabi toolchain, I proceeded with make. I get errors over system files: In file included from /usr/include/x86_64-linux-gnu/sys/socket.h:26:0, from /usr/include/netinet/in.h:23, from /usr/include/arpa/inet.h:22, from l1ctl.c:29: /usr/include/x86_64-linux-gnu/sys/uio.h: In function ‘readv’: /usr/include/x86_64-linux-gnu/sys/uio.h:40:3: error: expected declaration specifiers before ‘__wur’ __wur; ^ /usr/include/x86_64-linux-gnu/sys/uio.h:51:3: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘__wur’ __wur; ^ These includes are system files and test out fine in my programs. Any idea what's going on? TIA Nikos
I've been following the installation directions from the wiki, Getting Started. After generating the arm-none-eabi toolchain, I proceeded with make.
My guess is you first tried compiling without an arm toolchain installed and then installed the arm toolchain and didn't do a 'make clean' when retrying. Cheers, Sylvain
Thx Sylvain, For your fast response. This turned out not to be the problem, since I did several times make clean & make distclean, after I created the toolchain, before posting:) But your response helped, in that this isn't a usual problem. Therefore smt in my setup. Turned out problem was in my CPPFLAGS include dir. Early on, I faced a few problems with missing include files. 1 in particular <sys/_types.h> was nowhere in my system other than in Xilinx vivado, under /gcc-arm-none-eabi/. Once I removed it from CPPFLAGS osmocom-bb compiled fine (with a few warnings) Problem solved:) On Sun, May 13, 2018 at 10:15 AM, Sylvain Munaut <246tnt@gmail.com> wrote:
I've been following the installation directions from the wiki, Getting Started. After generating the arm-none-eabi toolchain, I proceeded with make.
My guess is you first tried compiling without an arm toolchain installed and then installed the arm toolchain and didn't do a 'make clean' when retrying.
Cheers,
Sylvain
Hi Sylvain, I didn't realize it when you responded, but <sys/_types.h> is a toolchain problem, and you just nailed it. Cool:) Early on, before it was pointed to me to use the Getting Started wiki, I used the src/README.building file, which is a normal practice for all unix developers/admins. When I couldn't find the gnuarm.com toolchain, I searched the web for ubuntu toolchains and found the linaro one, gcc-arm-linux-gnueabi, which doesn't provide <sys_types.h>. No dev version either:( So, when using that toolchain, I had to come up with the missing <sys/_types.h>, and the only one I could find was from vivado:( Is there a point to my life's story? Just to pont out into how much problems one can get with the wrong README file. I realize that building procedure must be defined and maintained in 1 place, either the wiki or the README file. The wiki is a non standard unix location, but a more convenient one. I propose to fix the info in README.building, to avoid future issues. The fix can be as simple as "Prerequisite is the armel toolchain. Check the <wiki url> for installation" HTH Nikos On Sun, May 13, 2018 at 12:11 PM, Nikos Balkanas <nbalkanas@gmail.com> wrote:
Thx Sylvain,
For your fast response. This turned out not to be the problem, since I did several times make clean & make distclean, after I created the toolchain, before posting:) But your response helped, in that this isn't a usual problem. Therefore smt in my setup.
Turned out problem was in my CPPFLAGS include dir. Early on, I faced a few problems with missing include files. 1 in particular <sys/_types.h> was nowhere in my system other than in Xilinx vivado, under /gcc-arm-none-eabi/. Once I removed it from CPPFLAGS osmocom-bb compiled fine (with a few warnings)
Problem solved:)
On Sun, May 13, 2018 at 10:15 AM, Sylvain Munaut <246tnt@gmail.com> wrote:
I've been following the installation directions from the wiki, Getting Started. After generating the arm-none-eabi toolchain, I proceeded with make.
My guess is you first tried compiling without an arm toolchain installed and then installed the arm toolchain and didn't do a 'make clean' when retrying.
Cheers,
Sylvain
On Sun, May 13, 2018 at 09:28:57PM +0300, Nikos Balkanas wrote:
The wiki is a non standard unix location, but a more convenient one. I propose to fix the info in README.building, to avoid future issues. The fix can be as simple as "Prerequisite is the armel toolchain. Check the <wiki url> for installation"
Patches welcome! osmocom-bb is managed at gerrit.osmocom.org, to post a patch see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit ~N
Got it. I'm on it:) On Mon, May 14, 2018 at 2:45 PM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Sun, May 13, 2018 at 09:28:57PM +0300, Nikos Balkanas wrote:
The wiki is a non standard unix location, but a more convenient one. I propose to fix the info in README.building, to avoid future issues. The fix can be as simple as "Prerequisite is the armel toolchain. Check the <wiki url> for installation"
Patches welcome! osmocom-bb is managed at gerrit.osmocom.org, to post a patch see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit
~N
On Mon, May 14, 2018 at 8:12 PM, Nikos Balkanas <nbalkanas@gmail.com> wrote:
Got it. I'm on it:)
Tried to submit patch to gerrit: -> git push git://gerrit.osmocom.org/osmocom-bb HEAD:refs/for/master/Minor_Typo_Fixes fatal: remote error: access denied or repository not exported: /osmocom-bb Is the path right?
On Mon, May 14, 2018 at 2:45 PM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Sun, May 13, 2018 at 09:28:57PM +0300, Nikos Balkanas wrote:
The wiki is a non standard unix location, but a more convenient one. I propose to fix the info in README.building, to avoid future issues. The fix can be as simple as "Prerequisite is the armel toolchain. Check the <wiki url> for installation"
Patches welcome! osmocom-bb is managed at gerrit.osmocom.org, to post a patch see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit
~N
Hi, On 14/05/18 20:38, Nikos Balkanas wrote:
-> git push git://gerrit.osmocom.org/osmocom-bb <http://gerrit.osmocom.org/osmocom-bb> HEAD:refs/for/master/Minor_Typo_Fixes fatal: remote error: access denied or repository not exported: /osmocom-bb
Is the path right?
No, it's not. You must use: ssh://YOUR_USER@gerrit.osmocom.org:29418/osmocom-bb.git -- - Pau Espin Pedrol <pespin@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
On Mon, May 14, 2018 at 09:38:42PM +0300, Nikos Balkanas wrote:
On Mon, May 14, 2018 at 8:12 PM, Nikos Balkanas <nbalkanas@gmail.com> wrote:
Got it. I'm on it:)
Tried to submit patch to gerrit:
-> git push git://gerrit.osmocom.org/osmocom-bb HEAD:refs/for/master/Minor_Typo_Fixes fatal: remote error: access denied or repository not exported: /osmocom-bb
Well, what can I say. Please carefully read the wiki page: https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit you will note the URL ssh://$USERNAME@gerrit.osmocom.org:29418/$PROJECT.git ~N
On Tue, May 15, 2018 at 3:38 PM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Mon, May 14, 2018 at 09:38:42PM +0300, Nikos Balkanas wrote:
On Mon, May 14, 2018 at 8:12 PM, Nikos Balkanas <nbalkanas@gmail.com> wrote:
Got it. I'm on it:)
Tried to submit patch to gerrit:
-> git push git://gerrit.osmocom.org/osmocom-bb HEAD:refs/for/master/Minor_Typo_Fixes fatal: remote error: access denied or repository not exported: /osmocom-bb
Well, what can I say. Please carefully read the wiki page: https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit you will note the URL ssh://$USERNAME@gerrit.osmocom .org:29418/$PROJECT.git
~N
I think I got it working. I got this cryptic response: -> git push ssh://osmo/osmocom-bb.git Everything up-to-date Anyway to check if changes committed? Cloning from gerrit will just give me the main osmocom-bb.git :( Nikos
On Wed, May 16, 2018 at 04:47:32AM +0300, Nikos Balkanas wrote:
I think I got it working. I got this cryptic response:
-> git push ssh://osmo/osmocom-bb.git Everything up-to-date
That is definitely not how to push a patch for review to gerrit. Look, you're the first to have trouble reading the wiki page on Gerrit submissions, I believe the information there is quite clear. If it isn't, then we should fix that. Let us know where we lose you. If you still can't get it to work, please show us your ~/.ssh/config that you apparently use, share the state your git clone is in and your complete commandline and output that you use to push the patch.
Anyway to check if changes committed? Cloning from gerrit will just give me the main osmocom-bb.git :(
You are merely allowed to push a patch for review. Cloning osmocom-bb.git will only contain your patch if we approved and merged it. Usually that takes a couple of review iterations on gerrit.osmocom.org first. You have created a user on gerrit.osmocom.org? ~N
On Wed, May 16, 2018 at 3:38 PM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Wed, May 16, 2018 at 04:47:32AM +0300, Nikos Balkanas wrote:
I think I got it working. I got this cryptic response:
-> git push ssh://osmo/osmocom-bb.git Everything up-to-date
That is definitely not how to push a patch for review to gerrit.
Look, you're the first to have trouble reading the wiki page on Gerrit submissions, I believe the information there is quite clear. If it isn't, then we should fix that. Let us know where we lose you.
Too much Information. Confusing. There should be only 3 headers aside from the introductory why you use gerrit: 1) Creating user in gerrit 2) Setting up gerrit for commits and pushing 3) Push Patch for Review The only relevant entry in there is "Push for Review", and It is wrong:( git push gerrit HEAD:refs/for/master/my_topic It is different from what you told me in this mail, and gerrit is not an FQD. When I try to use FQD for gerrit, I get pubkey errors: -> git push nbalkanas@gerrit.osmocom.org:29418 HEAD:refs/for/master/Minor_Typo_Fixes Permission denied (publickey). fatal: Could not read from remote repository. If you still can't get it to work, please show us your ~/.ssh/config that
you apparently use, share the state your git clone is in and your complete commandline and output that you use to push the patch.
- > cat .ssh/config
ServerAliveInterval = 300 Host osmo Hostname gerrit.osmocom.org Port 29418 User nbalkanas -> git status On branch master Your branch is up-to-date with 'origin/master'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory) modified: src/README.building no changes added to commit (use "git add" and/or "git commit -a") -> git add src/README.building -> git add -f src/shared/libosmocore/configure -> git push ssh://osmo/osmocom-bb.git Everything up-to-date
Anyway to check if changes committed?
Cloning from gerrit will just give me the main osmocom-bb.git :(
You are merely allowed to push a patch for review. Cloning osmocom-bb.git will only contain your patch if we approved and merged it. Usually that takes a couple of review iterations on gerrit.osmocom.org first.
That's a major shortcoming. CVS has its problems but at least you can check what you have just commited:(
You have created a user on gerrit.osmocom.org?
Yes, I created user and added public key. Otherwise I would keep getting: Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists.
~N
Hi Nikos,
-> git status
On branch master Your branch is up-to-date with 'origin/master'.
Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory)
modified: src/README.building
no changes added to commit (use "git add" and/or "git commit -a")
-> git add src/README.building -> git add -f src/shared/libosmocore/configure -> git push ssh://osmo/osmocom-bb.git
Everything up-to-date
You seem to be missing a vital step - committing. After files are added to a commit you need to “finalize it”, so to speak, by saying git commit -m “commit message” After that you can push.
Anyway to check if changes committed? Cloning from gerrit will just give me the main osmocom-bb.git :(
You are merely allowed to push a patch for review. Cloning osmocom-bb.git will only contain your patch if we approved and merged it. Usually that takes a couple of review iterations on gerrit.osmocom.org first.
That's a major shortcoming. CVS has its problems but at least you can check what you have just commited:(
Please do not compare apples to oranges. The whole point of using gerrit is to have a streamlined patch review process in place. With a little bit of patience you can learn the way git works and after that you will see it is just as easy as cvs, but you do need to learn it! I would be happy to find some introductory manual about git usage to help getting you on track. Cheers, Domi
Ty domi, I got further along with commit:) Unfortunately, it now tells me that user nbalkanas has no rights to push:( Np, I can find help for git myself, if I need to. On the bright side, git offers enough messages during push, so no checking of committed data is needed @Neels, can you please authorize me? BR, Nikos On Thu, May 17, 2018 at 12:32 AM, Tomcsányi, Domonkos <domi@tomcsanyi.net> wrote:
Hi Nikos,
-> git status
On branch master Your branch is up-to-date with 'origin/master'.
Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git checkout -- <file>..." to discard changes in working directory)
modified: src/README.building
no changes added to commit (use "git add" and/or "git commit -a")
-> git add src/README.building -> git add -f src/shared/libosmocore/configure -> git push ssh://osmo/osmocom-bb.git
Everything up-to-date
You seem to be missing a vital step - committing. After files are added to a commit you need to “finalize it”, so to speak, by saying git commit -m “commit message”
After that you can push.
Anyway to check if changes committed?
Cloning from gerrit will just give me the main osmocom-bb.git :(
You are merely allowed to push a patch for review. Cloning osmocom-bb.git will only contain your patch if we approved and merged it. Usually that takes a couple of review iterations on gerrit.osmocom.org first.
That's a major shortcoming. CVS has its problems but at least you can check what you have just commited:(
Please do not compare apples to oranges. The whole point of using gerrit is to have a streamlined patch review process in place. With a little bit of patience you can learn the way git works and after that you will see it is just as easy as cvs, but you do need to learn it!
I would be happy to find some introductory manual about git usage to help getting you on track.
Cheers, Domi
On Thu, May 17, 2018 at 12:59:55AM +0300, Nikos Balkanas wrote:
-> git push ssh://osmo/osmocom-bb.git
Admitted, the patch pushing instructions only matched the case where one added a secondary 'gerrit' remote. So I tweaked the "Push for review" section: https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Push-for-re... In another mail you posted an SSH access error. You have added your SSH public key to your gerrit user as instructed on the wiki, right? ~N
Yeah, I have done all that. I'm still confused with the "Push for review" section. -> git push gerrit HEAD:refs/for/master fatal: 'gerrit' does not appear to be a git repository fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. As I mentioned to Domi, I just need push priviledges to gerrit. This is my output: -> cat .ssh/config ServerAliveInterval = 300 Host osmo Hostname gerrit.osmocom.org Port 29418 User nbalkanas -> git push ssh://osmo/osmocom-bb.git Counting objects: 32, done. Delta compression using up to 8 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 96.37 KiB | 0 bytes/s, done. Total 7 (delta 4), reused 0 (delta 0) remote: Resolving deltas: 100% (4/4) remote: Branch refs/heads/master: remote: You are not allowed to perform this operation. remote: To push into this reference you need 'Push' rights. remote: User: nbalkanas remote: Please read the documentation and contact an administrator remote: if you feel the configuration is incorrect remote: Processing changes: refs: 1, done To ssh://osmo/osmocom-bb.git ! [remote rejected] master -> master (prohibited by Gerrit: ref update access denied) error: failed to push some refs to 'ssh://osmo/osmocom-bb.git' gerrit is not a repository:( I also don't have priviledges to post to gerrit, which is fine, it is the gerrit master, and not the gerrit review... Not that for the git push output i've posted, all pubkeys and accounts are in order... Nikos On Thu, May 17, 2018 at 3:55 AM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Thu, May 17, 2018 at 12:59:55AM +0300, Nikos Balkanas wrote:
-> git push ssh://osmo/osmocom-bb.git
Admitted, the patch pushing instructions only matched the case where one added a secondary 'gerrit' remote. So I tweaked the "Push for review" section: https://osmocom.org/projects/cellular-infrastructure/wiki/ Gerrit#Push-for-review
In another mail you posted an SSH access error. You have added your SSH public key to your gerrit user as instructed on the wiki, right?
~N
OK. Finally figured out what I was doing wrong. Did the Tip & Trick "Fetch fast from git.osmocom.org push to gerrit" and thought adding gerrit to an existing clone was redundant and maybe damaging:( So, I omitted it and proceeded to push for review. Failed. This time I added gerrit to an existing clone and proceeded with the push for review: -> git push gerrit HEAD:refs/for/master/Minor_Typo_Fixes Counting objects: 32, done. Delta compression using up to 8 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 96.41 KiB | 0 bytes/s, done. Total 7 (delta 4), reused 0 (delta 0) remote: Resolving deltas: 100% (4/4) remote: Processing changes: new: 1, done remote: remote: New Changes: remote: https://gerrit.osmocom.org/#/c/osmocom-bb/+/9209 Minor Typo Fixes remote: To ssh://nbalkanas@gerrit.osmocom.org:29418/osmocom-bb.git * [new branch] HEAD -> refs/for/master/Minor_Typo_Fixes I even got a mail alert from it Finally it's over:) Suggestion to avoid similar future issues: Delete header "Add gerrit to an existing clone" and maybe add it as a comment Place Its content under "Push to Review" Keeping it as a separate heading, made me think that It's unrelated to "Push to review" The choice of target "gerrit" in the push command is unfortunate, since it can be confused for a host, gerrit.osmocom.org BR Nikos On Thu, May 17, 2018 at 4:14 AM, Nikos Balkanas <nbalkanas@gmail.com> wrote:
Yeah, I have done all that. I'm still confused with the "Push for review" section.
-> git push gerrit HEAD:refs/for/master fatal: 'gerrit' does not appear to be a git repository fatal: Could not read from remote repository.
Please make sure you have the correct access rights and the repository exists.
As I mentioned to Domi, I just need push priviledges to gerrit. This is my output:
-> cat .ssh/config ServerAliveInterval = 300 Host osmo Hostname gerrit.osmocom.org Port 29418 User nbalkanas
-> git push ssh://osmo/osmocom-bb.git Counting objects: 32, done. Delta compression using up to 8 threads. Compressing objects: 100% (7/7), done. Writing objects: 100% (7/7), 96.37 KiB | 0 bytes/s, done. Total 7 (delta 4), reused 0 (delta 0) remote: Resolving deltas: 100% (4/4) remote: Branch refs/heads/master: remote: You are not allowed to perform this operation. remote: To push into this reference you need 'Push' rights. remote: User: nbalkanas remote: Please read the documentation and contact an administrator remote: if you feel the configuration is incorrect remote: Processing changes: refs: 1, done To ssh://osmo/osmocom-bb.git ! [remote rejected] master -> master (prohibited by Gerrit: ref update access denied) error: failed to push some refs to 'ssh://osmo/osmocom-bb.git'
gerrit is not a repository:( I also don't have priviledges to post to gerrit, which is fine, it is the gerrit master, and not the gerrit review... Not that for the git push output i've posted, all pubkeys and accounts are in order...
Nikos
On Thu, May 17, 2018 at 3:55 AM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Thu, May 17, 2018 at 12:59:55AM +0300, Nikos Balkanas wrote:
-> git push ssh://osmo/osmocom-bb.git
Admitted, the patch pushing instructions only matched the case where one added a secondary 'gerrit' remote. So I tweaked the "Push for review" section: https://osmocom.org/projects/cellular-infrastructure/wiki/Ge rrit#Push-for-review
In another mail you posted an SSH access error. You have added your SSH public key to your gerrit user as instructed on the wiki, right?
~N
participants (5)
-
Neels Hofmeyr -
Nikos Balkanas -
Pau Espin Pedrol -
Sylvain Munaut -
Tomcsányi, Domonkos