On Wed, May 16, 2018 at 3:38 PM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:

On Wed, May 16, 2018 at 04:47:32AM +0300, Nikos Balkanas wrote:
> I think I got it working. I got this cryptic response:
>
> -> git push ssh://osmo/osmocom-bb.git
> Everything up-to-date

That is definitely not how to push a patch for review to gerrit.

Look, you're the first to have trouble reading the wiki page on Gerrit
submissions, I believe the information there is quite clear. If it isn't, then
we should fix that. Let us know where we lose you.

Too much Information. Confusing.

There should be only 3 headers aside from the introductory why you use gerrit:

1) Creating user in gerrit

2) Setting up gerrit for commits and pushing

3) Push Patch for Review

The only relevant entry in there is "Push for Review", and It is wrong:(

git push gerrit HEAD:refs/for/master/my_topic

It is different from what you told me in this mail, and gerrit is not an FQD.

When I try to use FQD for gerrit, I get pubkey errors:

-> git push nbalkanas@gerrit.osmocom.org:29418 HEAD:refs/for/master/Minor_Typo_Fixes
Permission denied (publickey).

fatal: Could not read from remote repository.

If you still can't get it to work, please show us your ~/.ssh/config that you
apparently use, share the state your git clone is in and your complete
commandline and output that you use to push the patch.

> cat .ssh/config

ServerAliveInterval = 300
Host osmo
Hostname gerrit.osmocom.org
Port 29418
User nbalkanas

-> git status

On branch master
Your branch is up-to-date with 'origin/master'.

Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)

modified: src/README.building

no changes added to commit (use "git add" and/or "git commit -a")

-> git add src/README.building

-> git add -f src/shared/libosmocore/configure
-> git push ssh://osmo/osmocom-bb.git

Everything up-to-date

> Anyway to check if changes committed?
> Cloning from gerrit will just give me the main osmocom-bb.git :(

You are merely allowed to push a patch for review. Cloning osmocom-bb.git will
only contain your patch if we approved and merged it. Usually that takes a
couple of review iterations on gerrit.osmocom.org first.

That's a major shortcoming. CVS has its problems but at least you can check what you have just commited:(

You have created a user on gerrit.osmocom.org?

Yes, I created user and added public key. Otherwise I would keep getting:

Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

~N