OK. Finally figured out what I was doing wrong.

Did the Tip & Trick "Fetch fast from git.osmocom.org push to gerrit" and thought adding gerrit to an existing clone was redundant and maybe damaging:(

So, I omitted it and proceeded to push for review. Failed.

This time I added gerrit to an existing clone and proceeded with the push for review:
-> git push gerrit HEAD:refs/for/master/Minor_Typo_Fixes
Counting objects: 32, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 96.41 KiB | 0 bytes/s, done.
Total 7 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: new: 1, done
remote:
remote: New Changes:
remote:   https://gerrit.osmocom.org/#/c/osmocom-bb/+/9209 Minor Typo Fixes
remote:
To ssh://nbalkanas@gerrit.osmocom.org:29418/osmocom-bb.git
* [new branch]      HEAD -> refs/for/master/Minor_Typo_Fixes

I even got a mail alert from it

Finally it's over:)

Suggestion to avoid similar future issues:

Delete header "Add gerrit to an existing clone" and maybe add it as a comment

Place Its content under "Push to Review"

Keeping it as a separate heading, made me think that It's unrelated to "Push to review"

The choice of target "gerrit" in the push command is unfortunate, since it can be confused for a host, gerrit.osmocom.org

BR
Nikos

On Thu, May 17, 2018 at 4:14 AM, Nikos Balkanas <nbalkanas@gmail.com> wrote:

Yeah, I have done all that.
I'm still confused with the "Push for review" section.

-> git push gerrit HEAD:refs/for/master
fatal: 'gerrit' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

As I mentioned to Domi, I just need push priviledges to gerrit.
This is my output:

-> cat .ssh/config
ServerAliveInterval = 300
Host osmo
Hostname gerrit.osmocom.org
Port 29418
User nbalkanas

-> git push ssh://osmo/osmocom-bb.git
Counting objects: 32, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 96.37 KiB | 0 bytes/s, done.
Total 7 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Branch refs/heads/master:
remote: You are not allowed to perform this operation.
remote: To push into this reference you need 'Push' rights.
remote: User: nbalkanas
remote: Please read the documentation and contact an administrator
remote: if you feel the configuration is incorrect
remote: Processing changes: refs: 1, done
To ssh://osmo/osmocom-bb.git
! [remote rejected] master -> master (prohibited by Gerrit: ref update access denied)
error: failed to push some refs to 'ssh://osmo/osmocom-bb.git'

gerrit is not a repository:( I also don't have priviledges to post to gerrit, which is fine, it is the gerrit
master, and not the gerrit review...
Not that for the git push output i've posted, all pubkeys and accounts are in order...

Nikos

On Thu, May 17, 2018 at 3:55 AM, Neels Hofmeyr <nhofmeyr@sysmocom.de> wrote:
On Thu, May 17, 2018 at 12:59:55AM +0300, Nikos Balkanas wrote:
> -> git push ssh://osmo/osmocom-bb.git

Admitted, the patch pushing instructions only matched the case where one added
a secondary 'gerrit' remote. So I tweaked the "Push for review" section:
https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit#Push-for-review

In another mail you posted an SSH access error. You have added your SSH public
key to your gerrit user as instructed on the wiki, right?

~N