Attention is currently required from: laforge, manawyrm, tnt.

pespin has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-e1d/+/43643?usp=email )

Change subject: octoi: rework frame_rifo logic to decompress frames on the output side ......................................................................

Patch Set 5:

(2 comments)

File src/octoi/e1oip.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/0c2c1a76_07371acc?usp=... : PS5, Line 263: memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME);

It's not zeroed, it copies the last frame AFAICT

Ah indeed I was confused by the "= { 0 };" above, I see now it's not zeroing here ;)

File src/octoi/octoi.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/0295aebd_e19c5ffa?usp=... : PS5, Line 140: /* substitute with last received frame */

That's what the new memcpy() in frame_rifo_out() line 152 is for. […]

"subsituted in frame_rifo_out()" looks more clear yes.