Attention is currently required from: laforge, manawyrm, tnt.

View Change

2 comments:

• File src/octoi/e1oip.c:

  • Patch Set #5, Line 263: memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME);

    It's not zeroed, it copies the last frame AFAICT

    Ah indeed I was confused by the "= { 0 };" above, I see now it's not zeroing here ;)

• File src/octoi/octoi.c:

  • Patch Set #5, Line 140: /* substitute with last received frame */

    That's what the new memcpy() in frame_rifo_out() line 152 is for. […]

    "subsituted in frame_rifo_out()" looks more clear yes.

To view, visit change 43643. To unsubscribe, or for help writing mail filters, visit settings.