Attention is currently required from: laforge, pespin.

tnt has posted comments on this change by manawyrm. ( https://gerrit.osmocom.org/c/osmo-e1d/+/43643?usp=email )

Change subject: octoi: rework frame_rifo logic to decompress frames on the output side ......................................................................

Patch Set 5: Code-Review+1

(3 comments)

Patchset:

PS5: All in all, looks good to me and good fix for the issue. Comments are really minor.

File src/octoi/e1oip.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/34569e09_ebba21f0?usp=... : PS5, Line 263: memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME);

any reason to do the zeroing further up now?

It's not zeroed, it copies the last frame AFAICT

File src/octoi/frame_rifo.c:

https://gerrit.osmocom.org/c/osmo-e1d/+/43643/comment/7e52ba58_db8fa548?usp=... : PS5, Line 147: memcpy(out, rifo->last_out, BYTES_PER_FRAME); This doesn't really do anything since AFAICT the code further down will fill with 0xff if rc == -2