Attention is currently required from: laforge, pespin.
Patch set 5:Code-Review +1
3 comments:
Patchset:
All in all, looks good to me and good fix for the issue.
Comments are really minor.
File src/octoi/e1oip.c:
Patch Set #5, Line 263: memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME);
any reason to do the zeroing further up now?
It's not zeroed, it copies the last frame AFAICT
File src/octoi/frame_rifo.c:
Patch Set #5, Line 147: memcpy(out, rifo->last_out, BYTES_PER_FRAME);
This doesn't really do anything since AFAICT the code further down will fill with 0xff if rc == -2
To view, visit change 43643. To unsubscribe, or for help writing mail filters, visit settings.