20 Jun
2016
20 Jun
'16
8:29 p.m.
On Mon, Jun 20, 2016 at 09:05:30AM +0000, Aravind Sirsikar wrote:
1) https://gerrit.osmocom.org/#/c/332/ ==>Add data
structure for ARQ-II in EGPRS DL.
2) https://gerrit.osmocom.org/#/c/333/ ==>Add Accessor functions for ARQ-II in EGPRS
DL.
3) https://gerrit.osmocom.org/#/c/334/ ==>Modify DL tbf flow for ARQ-II in EGPRS DL
Retx.
4) https://gerrit.osmocom.org/#/c/335/ ==>Add test cases to support ARQ-II for EGPRS
DL Retx.
Above patches must be merged to master in the same order as mentioned above.
As mentioned before, we're now on the Rebase-If-Necessary strategy in
gerrit, which ensures the correct ordering. You will notice here
https://gerrit.osmocom.org/#/c/335/1
that on the right, there is a list of "Submitted Together", which shows me
that you have committed as expected, from a branch all at once.
It would have sufficed to just link to the last submission (335), or
actually, there is no need to comment at all. Next time you can just
submit to gerrit and you're done :)
(Strangely enough, the "submitted together" list always shows only the
preceding commits in a series, while the "related changes" always shows
all of them.)
~Neels
--
- Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Harald Welte