6 Jun
2016
6 Jun
'16
12:54 a.m.
On Thu, Jun 02, 2016 at 02:22:42PM +0200, Harald Welte wrote:
Hi Neels,
On Wed, Jun 01, 2016 at 01:51:38PM +0200, Neels Hofmeyr wrote:
Hah, nice: that was my feeling exactly, but so far I assumed that a choice had
been made to use openggsn instead (for other reasons than available time).
Let's have unit tests!
Agreed, but I would really hope we can put new efforts into a different
(cleaner, more osmocom style) GTP implementation, rather than
implementing comprehensive unit tests for OpenGGSN's libgtp. I think at the moment we (at sysmocom) unfortunately
have lots of higher
priority items to work on[...]
Ok; after my analysis of the surrounding code I actually feel more or less
comfortable to merge the obvious fix without insisting on tests.
Merged to openggsn master, with a commit message tweak containing a link to
this message thread.
~Neels