Re: [libosmocore PATCH 1/5] abis_nm: Added the new tlv_definition abis_nm_osmo_att_tlvdef in the abis header

On Tue, May 20, 2014 at 07:34:16AM +0200, Alvaro Neira Ayuso wrote: Hi, in the subject you are using past tense ("Added") in general one will use the imperative/present tense. A search points me to this file in the git sources: http://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPatches… " Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour. Try to make sure your explanation can be understood without external resources. Instead of giving a URL to a mailing list archive, summarize the relevant points of the discussion. " I will re-write the subject.