[libosmocore PATCH 1/5] abis_nm: Added the new tlv_definition abis_nm_osmo_att_tlvdef in the abis header
From: Álvaro Neira Ayuso <anayuso@sysmocom.de> Signed-off-by: Alvaro Neira Ayuso <anayuso@sysmocom.de> --- include/osmocom/gsm/abis_nm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/osmocom/gsm/abis_nm.h b/include/osmocom/gsm/abis_nm.h index 4682ead..86b97eb 100644 --- a/include/osmocom/gsm/abis_nm.h +++ b/include/osmocom/gsm/abis_nm.h @@ -30,6 +30,7 @@ extern const struct tlv_definition abis_nm_att_tlvdef; const char *abis_nm_opstate_name(uint8_t os); const char *abis_nm_avail_name(uint8_t avail); const char *abis_nm_test_name(uint8_t test); +extern const struct tlv_definition abis_nm_osmo_att_tlvdef; /*! \brief write a human-readable OML header to the debug log * \param[in] ss Logging sub-system -- 1.7.10.4
Hi Alvaro, On Tue, May 20, 2014 at 07:34:16AM +0200, Alvaro Neira Ayuso wrote:
+extern const struct tlv_definition abis_nm_osmo_att_tlvdef;
thanks, applied. Regards, Harald -- - Harald Welte <hwelte@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Schivelbeiner Str. 5 * 10439 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte
On Tue, May 20, 2014 at 07:34:16AM +0200, Alvaro Neira Ayuso wrote: Hi, in the subject you are using past tense ("Added") in general one will use the imperative/present tense. A search points me to this file in the git sources: http://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPatches?... " Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour. Try to make sure your explanation can be understood without external resources. Instead of giving a URL to a mailing list archive, summarize the relevant points of the discussion. " I will re-write the subject. cheers holger
Good Morning El 20/05/14 08:45, Holger Hans Peter Freyther escribió:
On Tue, May 20, 2014 at 07:34:16AM +0200, Alvaro Neira Ayuso wrote:
Hi,
in the subject you are using past tense ("Added") in general one will use the imperative/present tense. A search points me to this file in the git sources:
http://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPatches?...
" Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour. Try to make sure your explanation can be understood without external resources. Instead of giving a URL to a mailing list archive, summarize the relevant points of the discussion. "
I will re-write the subject.
I didn't know that. Thanks Holger. I'm going to take a look and the next patches, I'm going to write the subject like you have explained me. Cheers Álvaro
participants (4)
-
Alvaro Neira Ayuso -
Harald Welte -
Holger Hans Peter Freyther -
Álvaro Neira Ayuso