Attention is currently required from: jolly.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34029 )

Change subject: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714 ......................................................................

Patch Set 1:

(2 comments)

File src/osmo-bsc/vgcs_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34029/comment/1597b2a4_60331e25 PS1, Line 1083: struct gsm_lchan *lchan; this also doesn't look like a fix for a warning, but an actual random-memory-dererference bug.

https://gerrit.osmocom.org/c/osmo-bsc/+/34029/comment/2705d2a3_d4eda2bf PS1, Line 542: if (!conn->vgcs_call.fi) { : cause = GSM0808_CAUSE_INCORRECT_VALUE; : goto reject; : } this doesn't look like a fix for a compiler warning, but an actual bugfix where prior to this patch the code was sending uninitialized memory as cause value. Please change the commit log accordingly.