Attention is currently required from: jolly.

View Change

2 comments:

• File src/osmo-bsc/vgcs_fsm.c:

  • Patch Set #1, Line 1083: struct gsm_lchan *lchan;

    this also doesn't look like a fix for a warning, but an actual random-memory-dererference bug.

  • Patch Set #1, Line 542:

    if (!conn->vgcs_call.fi) {
    		cause = GSM0808_CAUSE_INCORRECT_VALUE;
    		goto reject;
    	}
    

    this doesn't look like a fix for a compiler warning, but an actual bugfix where prior to this patch the code was sending uninitialized memory as cause value. Please change the commit log accordingly.

To view, visit change 34029. To unsubscribe, or for help writing mail filters, visit settings.