Attention is currently required from: dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34154 )
Change subject: sim-rest-server: fix REST method info
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I'm not entirely sure this is an improvement. The real "port to the present" would be to use the general pySim filesystem classes for reading/decoding files (like pySim-shell), not doing a low-level (scc) read and then manually calling a decoder function directly.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34154
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib0178823abb18187404249cfed71cfb3123d1d74
Gerrit-Change-Number: 34154
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 21 Aug 2023 13:27:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment