Attention is currently required from: dexter.

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43541?usp=email )

Change subject: ota: add TS 102 226 5.2 Expanded Remote Application data format ......................................................................

Patch Set 2:

(2 comments)

File pySim/ota.py:

https://gerrit.osmocom.org/c/pysim/+/43541/comment/df49afa9_28d0043b?usp=ema... : PS2, Line 323:

I would recommend to add API docstrings for the other parameters, in particular the apdu parameter, […]

The type literally tells me in the most expressive way what apdu is? This is in line with the previous code, no docs for obscure internal en/decoding methods.

https://gerrit.osmocom.org/c/pysim/+/43541/comment/f0f9ff10_3435f242?usp=ema... : PS2, Line 333:

same here, I think we should document all parameters.

Ok, but this is not related to this patchset, the comments are in line with the existing code.