Attention is currently required from: dexter.

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43540?usp=email )

Change subject: bip: move the BIP relay into pySim.bip ......................................................................

Patch Set 2:

(2 comments)

File tests/unittests/test_bip_relay.py:

https://gerrit.osmocom.org/c/pysim/+/43540/comment/1b7e0c4f_ab8270a6?usp=ema... : PS1, Line 28: with a card that sends one, and one that has one must get the PDU."""

I only see sms_sink? Were there crashes before, did you change the code when moving it to the bip mo […]

No idea see the make bip commit for handlers. These commits are mostly made up and were not tested (beyond running the related tests) independently as usual but split and rearranged from the actual commits to make them pretty/work with our rebase workflow, so all of this is just intermediate steps to what works in the end at the top of this pile of commits. Reviewing the intermediate commits is basically pointless unless we want to spend forever exercising half finished features for no benefit, there is not much I can do about this.

In any case, these tests currently pass with this move change, and the make bip work commit adds its own more specific tests, so I dont see a reason to change much here. I could squash related commits, but then we would discuss splitting them instead...

https://gerrit.osmocom.org/c/pysim/+/43540/comment/33a0e6cb_469959f3?usp=ema... : PS1, Line 40: Proact(sms_sink=seen.append).send_sms_via_smpp(self._submit())

maybe create the Proact object first and use it then. […]

No idea, this was originally part of the make bip work changes until the changes and file move/rename were split, does it matter? Some of the tests were just experiments to figure something out while I was working on the actual features. I guess we can clean up outdated tests later.