Attention is currently required from: dexter.

View Change

2 comments:

• File pySim/ota.py:

  • Patch Set #2, Line 323:

    I would recommend to add API docstrings for the other parameters, in particular the apdu parameter, […]

    The type literally tells me in the most expressive way what apdu is? This is in line with the previous code, no docs for obscure internal en/decoding methods.

  • Patch Set #2, Line 333:

    same here, I think we should document all parameters.

    Ok, but this is not related to this patchset, the comments are in line with the existing code.

To view, visit change 43541. To unsubscribe, or for help writing mail filters, visit settings.