[S] Change in osmo-remsim[master]: Add optional timeout to mapping
Attention is currently required from: laforge, lynxis, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email ) Change subject: Add optional timeout to mapping ...................................................................... Patch Set 7: (4 comments) File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/469c9606_650d05f3?u... : PS6, Line 415: {
Add some logging regarding the timeout her? Done
https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/84373a05_990e19ff?u... : PS6, Line 463: osmo_timer_setup(&map->timer, mapping_timeout, map);
This timer/timeout looks really related to the "map" object, not the "conn" one, which means this ti […] The timer belongs to the mapping ("map"). It is controlled here by handling the client connection ("conn"). The timeout handler here also controls the client connection. I moved the control of timer to the slotmap code, but left the timeout handler in the code handling the client connection.
https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/18a5f8d8_f1cc5c84?u... : PS6, Line 464: osmo_timer_schedule(&map->timer, map->timeout, 0);
if map->timeout > 0 Done
File src/slotmap.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43746/comment/082251dc_d38138b5?u... : PS6, Line 174: osmo_timer_del(&map->timer);
There we go, the timer is deleted here, so the set up of the timer and arming it also probably belng […] I removed the osmo_timer_del() call from the connection handling code, because it was redunant.
-- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43746?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I2f7ee24e6c926b65876af2b14da3534555398769 Gerrit-Change-Number: 43746 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Fri, 13 Nov 2026 08:46:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>
participants (1)
-
jolly