[M] Change in osmo-remsim[master]: Add priority mapping support to osmo-remsim-server
Attention is currently required from: laforge, lynxis, pespin. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email ) Change subject: Add priority mapping support to osmo-remsim-server ...................................................................... Patch Set 7: (6 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/9dc41432_0c5c9648?u... : PS6, Line 15: mapping, the normal mapping is suspended. The maintenance mapping hat
mappings wearing hats is nice, but I guess you meant: "The maintenance mapping *has* priority over t […] The commit message is rephrased.
https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/0b84daf8_58a7bfbf?u... : PS6, Line 16: priority over the mapping. The following steps are performed:
The following steps are perfomed when? which scenario? The commit message is rephrased.
https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/0e84e3d1_3639bc93?u... : PS6, Line 19: * The normal mapping is deleted and put into INACTIVE state.
how can it be deleted then put into INACTIVE? deletion means doesn't exist anymore right? The commit message is rephrased.
File src/server/rest_api.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/ca2eb6db_f68c241f?u... : PS6, Line 373: /* If we are suspended an exisisting mapping, we stay inactive until the mapping was removed. */
Rephrase this sentence, it has at least a couple wrong grammar issues regarding verb tenses which ma […] Done
File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/f61c03ed_6c4fdacf?u... : PS6, Line 438: if (map->suspend) {
can we rename this to "suspend_requested" or similar? the "suspend" naming is a bit confusing on wha […] Done
File src/slotmap.h: https://gerrit.osmocom.org/c/osmo-remsim/+/43745/comment/c850c2ec_5483ef4a?u... : PS6, Line 65: /* this mapping is (to be) suspended */
Ok, so it can actually mean 2 different things, which is actually quite confusing ;) […] I renamed the flag to "suspend_requested", as you suggested. this flag states what we want: to suspend. The "state" shows us when if the mapping has been suspended (INACTIVE) or not.
-- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/43745?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I885b3b529276f46fbbe6d86be2170b0bffbb8434 Gerrit-Change-Number: 43745 Gerrit-PatchSet: 7 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: lynxis <lynxis@fe80.eu> Gerrit-Comment-Date: Fri, 13 Nov 2026 08:46:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>
participants (1)
-
jolly