Attention is currently required from: laforge, lynxis, pespin.
4 comments:
File src/server/rspro_server.c:
Add some logging regarding the timeout her?
Done
Patch Set #6, Line 463: osmo_timer_setup(&map->timer, mapping_timeout, map);
This timer/timeout looks really related to the "map" object, not the "conn" one, which means this ti […]
The timer belongs to the mapping ("map"). It is controlled here by handling the client connection ("conn"). The timeout handler here also controls the client connection. I moved the control of timer to the slotmap code, but left the timeout handler in the code handling the client connection.
Patch Set #6, Line 464: osmo_timer_schedule(&map->timer, map->timeout, 0);
if map->timeout > 0
Done
File src/slotmap.c:
Patch Set #6, Line 174: osmo_timer_del(&map->timer);
There we go, the timer is deleted here, so the set up of the timer and arming it also probably belng […]
I removed the osmo_timer_del() call from the connection handling code, because it was redunant.
To view, visit change 43746. To unsubscribe, or for help writing mail filters, visit settings.