Attention is currently required from: jolly.

dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43652?usp=email )

Change subject: Add index to ipa_es10b_get_eim_cfg_data_filter ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

File src/ipa/libipa/es10b_get_eim_cfg_data.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/299b7784_ef11d15a?... : PS2, Line 297: maybe set *eim_cfg_data_item = NULL; for good measure?

https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/c5cc518c_54431b77?... : PS2, Line 309: /* In case no eim_id is specified, just pick the item from the list that is specified by index */ Maybe rephrase the comment a bit?

In case no eim_id is specified, pick the eim_cfg_data_item by its index and exit.

https://gerrit.osmocom.org/c/onomondo-ipa/+/43652/comment/fe053812_c7f2f967?... : PS2, Line 317: Maybe add a comment?

Otherwise find the eim_cfg_data_item by the specified eim_id and exit.